gnome/nautilus
gnome/nautilus
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/nautilus synced 2024-07-17 02:37:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

view-model: Drop find()

Browse source 
This wraps a linear search in an apparently simple call, which invites
lazy coding and invites future performance regressions.

This is not to say there is no need to iterate the model linearly. But
when doing so, it's best to do it explicitly, in a for/while loop, to
make it easy to spot performance issues.
This commit is contained in:
António Fernandes 2024-01-11 13:32:51 +00:00
parent c93c320d58
commit 607176359d
2 changed files with 0 additions and 40 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

38
src/nautilus-view-model.c
View file

@ -554,44 +554,6 @@ nautilus_view_model_add_items (NautilusViewModel *self,
}
}
/**
* nautilus_view_model_find:
*
* @item: The item to find.
*
* Iterate the model linearly to find the index of @item. Avoid using in a loop.
*
* Returns: The position of the item in the list, or G_MAXUINT if not found.
*/
guint
nautilus_view_model_find (NautilusViewModel *self,
NautilusViewItem *item)
{
guint n_items;
guint i = 0;
n_items = g_list_model_get_n_items (G_LIST_MODEL (self->sort_model));
while (i < n_items)
{
g_autoptr (GtkTreeListRow) row = NULL;
g_autoptr (NautilusViewItem) item_i = NULL;
row = g_list_model_get_item (G_LIST_MODEL (self->sort_model), i);
g_warn_if_fail (GTK_IS_TREE_LIST_ROW (row));
item_i = gtk_tree_list_row_get_item (row);
g_warn_if_fail (NAUTILUS_IS_VIEW_ITEM (item_i));
if (item_i == item)
{
return i;
}
i++;
}
return G_MAXUINT;
}
void
nautilus_view_model_clear_subdirectory (NautilusViewModel *self,
NautilusViewItem *item)

2
src/nautilus-view-model.h
View file

@ -30,8 +30,6 @@ void nautilus_view_model_add_item (NautilusViewModel *self,
NautilusViewItem *item);
void nautilus_view_model_add_items (NautilusViewModel *self,
GList *items);
guint nautilus_view_model_find (NautilusViewModel *self,
NautilusViewItem *item);
void nautilus_view_model_clear_subdirectory (NautilusViewModel *self,
NautilusViewItem *item);
void nautilus_view_model_expand_as_a_tree (NautilusViewModel *self,