mirror of
https://gitlab.gnome.org/GNOME/nautilus
synced 2024-09-20 00:02:12 +00:00
Added more bug numbers to FIXMEs. 142 to go.
* src/nautilus-view-frame-nautilus-view.c: (load_location), (stop_loading), (selection_changed), (title_changed): * src/nautilus-view-frame.c: (nautilus_view_frame_handle_client_destroy), (nautilus_view_frame_set_active_errors): * src/nautilus-window-manage-views.c: (nautilus_window_report_load_underway), (nautilus_window_report_load_complete), (nautilus_window_report_load_failed), (nautilus_window_update_view), (nautilus_window_load_sidebar_panel), (open_location), (nautilus_window_update_state), (nautilus_window_end_location_change_callback): * src/nautilus-window-menus.c: (get_static_bookmarks_file_path): * src/nautilus-window.c: (nautilus_window_load_content_view_menu): * tools/leak-checker/nautilus-leak-checker.c: (detect_reentry): * tools/leak-checker/nautilus-leak-hash-table.c: (nautilus_leak_hash_element_vector_add), (nautilus_leak_hash_table_remove):
This commit is contained in:
parent
97e19ed2d4
commit
5f2663cc76
24
ChangeLog
24
ChangeLog
|
@ -1,3 +1,27 @@
|
|||
2000-08-28 John Sullivan <sullivan@eazel.com>
|
||||
|
||||
Added more bug numbers to FIXMEs. 142 to go.
|
||||
|
||||
* src/nautilus-view-frame-nautilus-view.c: (load_location),
|
||||
(stop_loading), (selection_changed), (title_changed):
|
||||
* src/nautilus-view-frame.c:
|
||||
(nautilus_view_frame_handle_client_destroy),
|
||||
(nautilus_view_frame_set_active_errors):
|
||||
* src/nautilus-window-manage-views.c:
|
||||
(nautilus_window_report_load_underway),
|
||||
(nautilus_window_report_load_complete),
|
||||
(nautilus_window_report_load_failed),
|
||||
(nautilus_window_update_view),
|
||||
(nautilus_window_load_sidebar_panel), (open_location),
|
||||
(nautilus_window_update_state),
|
||||
(nautilus_window_end_location_change_callback):
|
||||
* src/nautilus-window-menus.c: (get_static_bookmarks_file_path):
|
||||
* src/nautilus-window.c: (nautilus_window_load_content_view_menu):
|
||||
* tools/leak-checker/nautilus-leak-checker.c: (detect_reentry):
|
||||
* tools/leak-checker/nautilus-leak-hash-table.c:
|
||||
(nautilus_leak_hash_element_vector_add),
|
||||
(nautilus_leak_hash_table_remove):
|
||||
|
||||
2000-08-28 Robey Pointer <robey@eazel.com>
|
||||
|
||||
components/services/install/nautilus-view/nautilus-service-install-
|
||||
|
|
|
@ -759,8 +759,8 @@ get_static_bookmarks_file_path (void)
|
|||
char *xml_file_path;
|
||||
|
||||
/* For now at least, the static bookmarks file is kept in the standard shared data directory. */
|
||||
/* FIXME: The service might want to overwrite this file. Can it do so in this
|
||||
* location?
|
||||
/* FIXME bugzilla.eazel.com 1826:
|
||||
* The service might want to overwrite this file. Can it do so in this location?
|
||||
*/
|
||||
|
||||
xml_file_path = nautilus_make_path (NAUTILUS_DATADIR, STATIC_BOOKMARKS_FILE_NAME);
|
||||
|
|
|
@ -71,7 +71,7 @@
|
|||
/* GNOME Dock Items */
|
||||
#define URI_ENTRY_DOCK_ITEM "uri_entry"
|
||||
|
||||
/* default web search uri - FIXME: this will be changed to point to the Eazel service */
|
||||
/* default web search uri - FIXME bugzilla.eazel.com 2465: this will be changed to point to the Eazel service */
|
||||
#define DEFAULT_SEARCH_WEB_URI "http://www.google.com"
|
||||
|
||||
enum {
|
||||
|
@ -830,7 +830,7 @@ nautilus_window_load_content_view_menu (NautilusWindow *window)
|
|||
* it's better than nothing.
|
||||
*/
|
||||
method = nautilus_mime_get_short_list_methods_for_uri (window->location);
|
||||
/* FIXME: Name of the function is plural, but it returns only
|
||||
/* FIXME bugzilla.eazel.com 2466: Name of the function is plural, but it returns only
|
||||
* one item. That must be fixed.
|
||||
*/
|
||||
if (method != NULL) {
|
||||
|
|
|
@ -71,7 +71,7 @@
|
|||
/* GNOME Dock Items */
|
||||
#define URI_ENTRY_DOCK_ITEM "uri_entry"
|
||||
|
||||
/* default web search uri - FIXME: this will be changed to point to the Eazel service */
|
||||
/* default web search uri - FIXME bugzilla.eazel.com 2465: this will be changed to point to the Eazel service */
|
||||
#define DEFAULT_SEARCH_WEB_URI "http://www.google.com"
|
||||
|
||||
enum {
|
||||
|
@ -830,7 +830,7 @@ nautilus_window_load_content_view_menu (NautilusWindow *window)
|
|||
* it's better than nothing.
|
||||
*/
|
||||
method = nautilus_mime_get_short_list_methods_for_uri (window->location);
|
||||
/* FIXME: Name of the function is plural, but it returns only
|
||||
/* FIXME bugzilla.eazel.com 2466: Name of the function is plural, but it returns only
|
||||
* one item. That must be fixed.
|
||||
*/
|
||||
if (method != NULL) {
|
||||
|
|
|
@ -71,7 +71,7 @@
|
|||
/* GNOME Dock Items */
|
||||
#define URI_ENTRY_DOCK_ITEM "uri_entry"
|
||||
|
||||
/* default web search uri - FIXME: this will be changed to point to the Eazel service */
|
||||
/* default web search uri - FIXME bugzilla.eazel.com 2465: this will be changed to point to the Eazel service */
|
||||
#define DEFAULT_SEARCH_WEB_URI "http://www.google.com"
|
||||
|
||||
enum {
|
||||
|
@ -830,7 +830,7 @@ nautilus_window_load_content_view_menu (NautilusWindow *window)
|
|||
* it's better than nothing.
|
||||
*/
|
||||
method = nautilus_mime_get_short_list_methods_for_uri (window->location);
|
||||
/* FIXME: Name of the function is plural, but it returns only
|
||||
/* FIXME bugzilla.eazel.com 2466: Name of the function is plural, but it returns only
|
||||
* one item. That must be fixed.
|
||||
*/
|
||||
if (method != NULL) {
|
||||
|
|
|
@ -87,7 +87,7 @@ load_location(NautilusViewFrame *view, Nautilus_URI location, CORBA_Environment
|
|||
Nautilus_View_load_location(nvi->view_client, location, ev);
|
||||
|
||||
if(ev->_major != CORBA_NO_EXCEPTION)
|
||||
/* FIXME: Is a destroy really sufficient here? Who does the unref? */
|
||||
/* FIXME bugzilla.eazel.com 2455: Is a destroy really sufficient here? Who does the unref? */
|
||||
gtk_object_destroy(GTK_OBJECT(view));
|
||||
}
|
||||
|
||||
|
@ -99,7 +99,7 @@ stop_loading(NautilusViewFrame *view, CORBA_Environment *ev)
|
|||
Nautilus_View_stop_loading(nvi->view_client, ev);
|
||||
|
||||
if(ev->_major != CORBA_NO_EXCEPTION)
|
||||
/* FIXME: Is a destroy really sufficient here? Who does the unref? */
|
||||
/* FIXME bugzilla.eazel.com 2455 bugzilla.eazel.com 2455: Is a destroy really sufficient here? Who does the unref? */
|
||||
gtk_object_destroy(GTK_OBJECT(view));
|
||||
}
|
||||
|
||||
|
@ -111,7 +111,7 @@ selection_changed(NautilusViewFrame *view, const Nautilus_URIList *selection, CO
|
|||
Nautilus_View_selection_changed(nvi->view_client, selection, ev);
|
||||
|
||||
if(ev->_major != CORBA_NO_EXCEPTION)
|
||||
/* FIXME: Is a destroy really sufficient here? Who does the unref? */
|
||||
/* FIXME bugzilla.eazel.com 2455: Is a destroy really sufficient here? Who does the unref? */
|
||||
gtk_object_destroy(GTK_OBJECT(view));
|
||||
}
|
||||
|
||||
|
@ -126,7 +126,7 @@ title_changed (NautilusViewFrame *view, CORBA_Environment *ev)
|
|||
Nautilus_View_title_changed(nvi->view_client, ev);
|
||||
|
||||
if(ev->_major != CORBA_NO_EXCEPTION)
|
||||
/* FIXME: Is a destroy really sufficient here? Who does the unref? */
|
||||
/* FIXME bugzilla.eazel.com 2455: Is a destroy really sufficient here? Who does the unref? */
|
||||
gtk_object_destroy(GTK_OBJECT(view));
|
||||
|
||||
}
|
||||
|
|
|
@ -272,7 +272,7 @@ extern NautilusViewComponentType bonobo_control_component_type; /* ntl-view-bono
|
|||
static void
|
||||
nautilus_view_frame_handle_client_destroy (GtkWidget *widget, NautilusViewFrame *view)
|
||||
{
|
||||
/* FIXME: Is a destroy really sufficient here? Who does the unref? */
|
||||
/* FIXME bugzilla.eazel.com 2455: Is a destroy really sufficient here? Who does the unref? */
|
||||
gtk_object_destroy (GTK_OBJECT (view));
|
||||
}
|
||||
|
||||
|
@ -832,7 +832,9 @@ nautilus_view_frame_set_active_errors (NautilusViewFrame *view, gboolean enabled
|
|||
g_return_if_fail (NAUTILUS_IS_VIEW_FRAME (view));
|
||||
if (enabled) {
|
||||
if (view->timer_id == 0) {
|
||||
/* FIXME: Is a hard-coded 2-second timeout acceptable? */
|
||||
/* FIXME bugzilla.eazel.com 2456:
|
||||
* Is a hard-coded 2-second timeout acceptable?
|
||||
*/
|
||||
view->timer_id = g_timeout_add (2000, check_object, view);
|
||||
}
|
||||
} else {
|
||||
|
|
|
@ -124,8 +124,8 @@ void
|
|||
nautilus_window_report_load_underway (NautilusWindow *window,
|
||||
NautilusViewFrame *view)
|
||||
{
|
||||
/* FIXME: OK to ignore progress from sidebar views? */
|
||||
/* FIXME: Is progress from either old or new really equally interesting? */
|
||||
/* FIXME bugzilla.eazel.com 2460: OK to ignore progress from sidebar views? */
|
||||
/* FIXME bugzilla.eazel.com 2461: Is progress from either old or new really equally interesting? */
|
||||
if (view == window->new_content_view
|
||||
|| view == window->content_view) {
|
||||
nautilus_window_set_state_info
|
||||
|
@ -148,8 +148,8 @@ void
|
|||
nautilus_window_report_load_complete (NautilusWindow *window,
|
||||
NautilusViewFrame *view)
|
||||
{
|
||||
/* FIXME: OK to ignore progress from sidebar views? */
|
||||
/* FIXME: Is progress from either old or new really equally interesting? */
|
||||
/* FIXME bugzilla.eazel.com 2460: OK to ignore progress from sidebar views? */
|
||||
/* FIXME bugzilla.eazel.com 2461: Is progress from either old or new really equally interesting? */
|
||||
if (view == window->new_content_view
|
||||
|| view == window->content_view) {
|
||||
nautilus_window_set_state_info
|
||||
|
@ -163,8 +163,8 @@ void
|
|||
nautilus_window_report_load_failed (NautilusWindow *window,
|
||||
NautilusViewFrame *view)
|
||||
{
|
||||
/* FIXME: OK to ignore progress from sidebar views? */
|
||||
/* FIXME: Is progress from either old or new really equally interesting? */
|
||||
/* FIXME bugzilla.eazel.com 2460: OK to ignore progress from sidebar views? */
|
||||
/* FIXME bugzilla.eazel.com 2461: Is progress from either old or new really equally interesting? */
|
||||
if (view == window->new_content_view
|
||||
|| view == window->content_view) {
|
||||
nautilus_window_set_state_info
|
||||
|
@ -514,7 +514,7 @@ nautilus_window_update_view (NautilusWindow *window,
|
|||
nautilus_view_frame_load_location (view, new_location);
|
||||
}
|
||||
|
||||
/* FIXME: Is NULL a way to indicate no selection, or no change? */
|
||||
/* FIXME bugzilla.eazel.com 2462: Is NULL a way to indicate no selection, or no change? */
|
||||
if (new_selection != NULL) {
|
||||
nautilus_view_frame_selection_changed (view, new_selection);
|
||||
}
|
||||
|
@ -663,7 +663,7 @@ nautilus_window_load_sidebar_panel (NautilusWindow *window,
|
|||
}
|
||||
|
||||
if (sidebar_panel != NULL) {
|
||||
/* FIXME: Do we really want to ref even in the case
|
||||
/* FIXME bugzilla.eazel.com 2463: Do we really want to ref even in the case
|
||||
* where we just made the panel?
|
||||
*/
|
||||
gtk_object_ref (GTK_OBJECT (sidebar_panel));
|
||||
|
@ -743,7 +743,8 @@ open_location (NautilusWindow *window,
|
|||
g_assert (view_if_already_loading == NULL);
|
||||
|
||||
/* Determine if a window with this uri is already open. If so, activate it */
|
||||
/* FIXME: This may be the desired bahavior, but the prefs UI still says open
|
||||
/* FIXME bugzilla.eazel.com 2464:
|
||||
* This may be the desired bahavior, but the prefs UI still says open
|
||||
* new window. How can we resolve this inconsistancy?
|
||||
*/
|
||||
for (element = nautilus_application_windows (); element != NULL; element = element->next) {
|
||||
|
@ -1092,7 +1093,7 @@ nautilus_window_update_state (gpointer data)
|
|||
location, selection,
|
||||
window->new_requesting_view, window->new_content_view);
|
||||
} else {
|
||||
/* FIXME: Silent error here! */
|
||||
/* FIXME bugzilla.eazel.com 2457: Silent error here! */
|
||||
window->cv_progress_error = TRUE;
|
||||
}
|
||||
|
||||
|
@ -1356,7 +1357,7 @@ nautilus_window_end_location_change_callback (NautilusNavigationResult result_co
|
|||
|
||||
case NAUTILUS_NAVIGATION_RESULT_SERVICE_NOT_AVAILABLE:
|
||||
if (nautilus_is_search_uri (requested_uri)) {
|
||||
/* FIXME: Need to give the user some advice about what to do here. */
|
||||
/* FIXME bugzilla.eazel.com 2458: Need to give the user some advice about what to do here. */
|
||||
error_message = g_strdup_printf (_("Sorry, searching can't be used now. In the future this message will be more helpful."));
|
||||
break;
|
||||
} /* else fall through */
|
||||
|
@ -1376,7 +1377,7 @@ nautilus_window_end_location_change_callback (NautilusNavigationResult result_co
|
|||
/* Destroy never-had-a-chance-to-be-seen window. This case
|
||||
* happens when a new window cannot display its initial URI.
|
||||
*/
|
||||
/* FIXME: Is a destroy really sufficient here? Who does the unref? */
|
||||
/* FIXME bugzilla.eazel.com 2459: Is a destroy really sufficient here? Who does the unref? */
|
||||
gtk_object_destroy (GTK_OBJECT (window));
|
||||
nautilus_error_dialog (error_message, NULL);
|
||||
} else {
|
||||
|
|
|
@ -759,8 +759,8 @@ get_static_bookmarks_file_path (void)
|
|||
char *xml_file_path;
|
||||
|
||||
/* For now at least, the static bookmarks file is kept in the standard shared data directory. */
|
||||
/* FIXME: The service might want to overwrite this file. Can it do so in this
|
||||
* location?
|
||||
/* FIXME bugzilla.eazel.com 1826:
|
||||
* The service might want to overwrite this file. Can it do so in this location?
|
||||
*/
|
||||
|
||||
xml_file_path = nautilus_make_path (NAUTILUS_DATADIR, STATIC_BOOKMARKS_FILE_NAME);
|
||||
|
|
|
@ -71,7 +71,7 @@
|
|||
/* GNOME Dock Items */
|
||||
#define URI_ENTRY_DOCK_ITEM "uri_entry"
|
||||
|
||||
/* default web search uri - FIXME: this will be changed to point to the Eazel service */
|
||||
/* default web search uri - FIXME bugzilla.eazel.com 2465: this will be changed to point to the Eazel service */
|
||||
#define DEFAULT_SEARCH_WEB_URI "http://www.google.com"
|
||||
|
||||
enum {
|
||||
|
@ -830,7 +830,7 @@ nautilus_window_load_content_view_menu (NautilusWindow *window)
|
|||
* it's better than nothing.
|
||||
*/
|
||||
method = nautilus_mime_get_short_list_methods_for_uri (window->location);
|
||||
/* FIXME: Name of the function is plural, but it returns only
|
||||
/* FIXME bugzilla.eazel.com 2466: Name of the function is plural, but it returns only
|
||||
* one item. That must be fixed.
|
||||
*/
|
||||
if (method != NULL) {
|
||||
|
|
|
@ -219,7 +219,8 @@ detect_reentry (void *parent_caller)
|
|||
* check to detect the recursion, 0x40 bytes should be a large enough distance
|
||||
* from the start of the malloc call to the point where the old malloc call is
|
||||
* being called.
|
||||
* FIXME: this the value 0x40 works well only with certain function sizes, optimization levels,
|
||||
* FIXME bugzilla.eazel.com 2467:
|
||||
* The value 0x40 works well only with certain function sizes, optimization levels,
|
||||
* etc. need a more robust way of doing this. One way might be adding stuffing into the
|
||||
* __libc_* calls that is never executed but makes the funcitons longer. We could
|
||||
* then up the value without the danger of hitting the next function
|
||||
|
|
|
@ -125,7 +125,7 @@ nautilus_leak_hash_element_vector_add (NautilusHashEntryVector *vector)
|
|||
g_warning ("leak checker out of memory");
|
||||
abort();
|
||||
}
|
||||
/* FIXME: only clean the unused part */
|
||||
/* FIXME bugzilla.eazel.com 2469: only clean the unused part */
|
||||
memset (new_data, 0, new_size * sizeof(NautilusHashEntry));
|
||||
|
||||
/* copy all the existing items over*/
|
||||
|
@ -320,7 +320,8 @@ nautilus_leak_hash_table_remove (NautilusLeakHashTable *table, unsigned long key
|
|||
|
||||
element = nautilus_leak_hash_table_find (table, key);
|
||||
if (element != NULL) {
|
||||
/* FIXME: this could be faster if we just found the element
|
||||
/* FIXME bugzilla.eazel.com 2470:
|
||||
* this could be faster if we just found the element
|
||||
* here and deleted it.
|
||||
*/
|
||||
nautilus_leak_hash_table_remove_element (table, element);
|
||||
|
|
Loading…
Reference in a new issue