gnome/nautilus
gnome/nautilus
1
0
Fork 0
mirror of https://gitlab.gnome.org/GNOME/nautilus synced 2024-11-05 16:04:31 +00:00
Code Issues Projects Releases Packages Wiki Activity

reviewed by: Darin Adler <darin@eazel.com>

Browse source 
Fixed bug 8122 (Folders opened from the desktop should not
	reuse frontmost window). The previous behavior was intended to
	match the behavior of web browsers, but user feedback made it
	clear that it was confusing and annoying people too much.

	* src/nautilus-window-manage-views.c:
	(get_topmost_nautilus_window_in_current_workspace_and_area):
	Removed this no-longer-needed function.
	(open_location): Always create a new window in the desktop case.
This commit is contained in:
John Sullivan 2001-05-07 21:33:03 +00:00
parent 3646403e78
commit 48df98602d
2 changed files with 24 additions and 35 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
ChangeLog
View file

@ -1,3 +1,17 @@
2001-05-07 John Sullivan <sullivan@eazel.com>
reviewed by: Darin Adler <darin@eazel.com>
Fixed bug 8122 (Folders opened from the desktop should not
reuse frontmost window). The previous behavior was intended to
match the behavior of web browsers, but user feedback made it
clear that it was confusing and annoying people too much.
* src/nautilus-window-manage-views.c:
(get_topmost_nautilus_window_in_current_workspace_and_area):
Removed this no-longer-needed function.
(open_location): Always create a new window in the desktop case.
2001-05-07 Darin Adler <darin@eazel.com>
reviewed by: John Sullivan <sullivan@eazel.com>

45
src/nautilus-window-manage-views.c
View file

@ -673,28 +673,6 @@ location_has_really_changed (NautilusWindow *window)
}
static NautilusWindow *
get_topmost_nautilus_window_in_current_workspace_and_area (void)
{
GList *window_list, *node;
NautilusWindow *result;
window_list = eel_get_window_list_ordered_front_to_back ();
result = NULL;
for (node = window_list; node != NULL; node = node->next) {
if (NAUTILUS_IS_WINDOW (node->data)
&& eel_gtk_window_is_on_current_workspace_and_area (GTK_WINDOW (node->data))) {
result = NAUTILUS_WINDOW (node->data);
break;
}
}
g_list_free (window_list);
return result;
}
static void
open_location (NautilusWindow *window,
const char *location,
@ -711,21 +689,18 @@ open_location (NautilusWindow *window,
* We should use inheritance instead of these special cases
* for the desktop window.
*/
/* When loading a location on the desktop (in "open within
* same window mode"), always use another window. Either use
* the topmost window, or create a new window if the desktop
* is the topmost (and only).
*/
/* We used to have behavior here that worked like this: when
* loading a location on the desktop in "open within same window
* mode", always use another window. Either use the topmost window,
* or create a new window if the desktop is the topmost (and only).
* However, this behavior was nearly universally disliked (see
* bugzilla.eazel.com bug 8122).
*/
if (!create_new_window && NAUTILUS_IS_DESKTOP_WINDOW (window)) {
if (NAUTILUS_DESKTOP_WINDOW(window)->affect_desktop_on_next_location_change == FALSE) {
target_window = get_topmost_nautilus_window_in_current_workspace_and_area ();
if (target_window == NULL || target_window == window) {
create_new_window = TRUE;
} else {
eel_gtk_window_present (GTK_WINDOW (target_window));
}
if (!NAUTILUS_DESKTOP_WINDOW (window)->affect_desktop_on_next_location_change) {
create_new_window = TRUE;
} else {
NAUTILUS_DESKTOP_WINDOW(window)->affect_desktop_on_next_location_change = FALSE;
NAUTILUS_DESKTOP_WINDOW (window)->affect_desktop_on_next_location_change = FALSE;
}
}