mirror of
https://gitlab.gnome.org/GNOME/gparted
synced 2024-08-27 11:40:03 +00:00
fdbd86f1ea
The current code uses push_back() and insert() to copy Partition objects
into the vector of pointers. This has a few issues:
1) Unnecessary copying of Partition objects;
2) Hides the nature of the PartitionVector class as a manager of
pointers to Partition objects by providing copy semantics to add
items. It is generally better to be explicit;
3) C++ doesn't provide polymorphic copy construction directly, but this
is easily worked around by following the Virtual Constructor idiom
[1], which would allow PartitionLUKS derived class objects to be
copied into the vector.
Add push_back_adopt() and insert_adopt() methods which add a pointer to
a Partition object into the PartitionVector adopting ownership.
[1] Wikibooks: More C++ Idioms / Virtual Constructor
https://en.wikibooks.org/wiki/More_C%2B%2B_Idioms/Virtual_Constructor
Bug 759726 - Implement Partition object polymorphism
84 lines
2.9 KiB
C++
84 lines
2.9 KiB
C++
/* Copyright (C) 2015 Mike Fleetwood
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
/* Minimal implementation of a class with some behaviours like a std::vector<Partition>.
|
|
* However internally the class manages pointers to Partition objects allowing for
|
|
* Partition object polymorphism.
|
|
* Reference:
|
|
* C++ Reference to std::vector
|
|
* http://www.cplusplus.com/reference/vector/vector/
|
|
*/
|
|
|
|
#ifndef GPARTED_PARTITIONVECTOR_H
|
|
#define GPARTED_PARTITIONVECTOR_H
|
|
|
|
#include "../include/Partition.h"
|
|
|
|
#include <cstddef>
|
|
#include <vector>
|
|
|
|
namespace GParted
|
|
{
|
|
|
|
class Partition; // Forward declarations as Partition and PartitionVector are
|
|
class PartitionVector; // mutually recursive classes.
|
|
// References:
|
|
// Mutually recursive classes
|
|
// http://stackoverflow.com/questions/3410637/mutually-recursive-classes
|
|
// recursive definition in CPP
|
|
// http://stackoverflow.com/questions/4300420/recursive-definition-in-cpp
|
|
|
|
class PartitionVector {
|
|
public:
|
|
typedef size_t size_type;
|
|
typedef std::vector<Partition *>::iterator iterator;
|
|
|
|
PartitionVector() {};
|
|
PartitionVector( const PartitionVector & src );
|
|
~PartitionVector();
|
|
void swap( PartitionVector & other );
|
|
PartitionVector & operator=( PartitionVector rhs );
|
|
|
|
// Iterators
|
|
iterator begin() { return v.begin(); };
|
|
|
|
// Capacity
|
|
bool empty() const { return v.empty(); };
|
|
|
|
// Element access
|
|
Partition & operator[]( size_type n ) { return *v[n]; };
|
|
const Partition & operator[]( size_type n ) const { return *v[n]; };
|
|
size_type size() const { return v.size(); };
|
|
const Partition & front() const { return *v.front(); };
|
|
const Partition & back() const { return *v.back(); };
|
|
|
|
// Modifiers
|
|
void pop_back();
|
|
void erase( const iterator position );
|
|
void clear();
|
|
void push_back( const Partition & partition );
|
|
void insert( iterator position, const Partition & partition );
|
|
void push_back_adopt( Partition * partition );
|
|
void insert_adopt( iterator position, Partition * partition );
|
|
|
|
private:
|
|
std::vector<Partition *> v;
|
|
};
|
|
|
|
} //GParted
|
|
|
|
#endif /* GPARTED_PARTITIONVECTOR_H */
|