mirror of
https://gitlab.gnome.org/GNOME/gparted
synced 2024-10-12 10:52:59 +00:00
584137b32b
GParted waits forever when attempting to set a FAT16/32 file system
label which contains prohibited characters [1][2]. This is because
mlabel asks a question and is waiting for input. Force cancelling the
operation doesn't work either as GParted sends signal 2 (interrupt i.e.
[Ctrl-C]) but mtools commands specifically ignores this and a number of
other signals. Have to kill mlabel with signal 9 (kill) to regain
control of GParted.
Mlabel command with prohibited characters in the label:
# export MTOOLS_SKIP_CHECK=1
# mlabel ::"MYLABEL/ " -i /dev/sdb10
Long file name "MYLABEL/ " contains illegal character(s).
a)utorename A)utorename-all r)ename R)ename-all
s)kip S)kip-all q)uit (aArRsSq):
Remove prohibited characters from FAT16/32 file systems labels when
creating and labelling them. Also upper case the label to meet label
requirements [1][2]. This silently corrects the label and the actual
label applied will be displayed when GParted refreshes after applying
the operation.
[1] Microsoft TechNet: Label
https://technet.microsoft.com/en-us/library/bb490925.aspx
[2] Replicated in Wikikedia: label (command)
https://en.wikipedia.org/wiki/Label_%28command%29
Bug 755608 - Labeling fat16/fat32 partitions hangs if certain characters
included in label
52 lines
1.8 KiB
C++
52 lines
1.8 KiB
C++
/* Copyright (C) 2004 Bart
|
|
* Copyright (C) 2008, 2009, 2010 Curtis Gedak
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
|
|
#ifndef GPARTED_FAT16_H
|
|
#define GPARTED_FAT16_H
|
|
|
|
#include "../include/FileSystem.h"
|
|
|
|
namespace GParted
|
|
{
|
|
|
|
class fat16 : public FileSystem
|
|
{
|
|
const enum FILESYSTEM specific_type ;
|
|
Glib::ustring create_cmd ;
|
|
Glib::ustring check_cmd ;
|
|
public:
|
|
fat16( enum FILESYSTEM type ) : specific_type( type ), create_cmd( "" ), check_cmd( "" ) {} ;
|
|
const Glib::ustring get_custom_text( CUSTOM_TEXT ttype, int index = 0 ) const;
|
|
FS get_filesystem_support() ;
|
|
void set_used_sectors( Partition & partition ) ;
|
|
void read_label( Partition & partition ) ;
|
|
bool write_label( const Partition & partition, OperationDetail & operationdetail ) ;
|
|
void read_uuid( Partition & partition ) ;
|
|
bool write_uuid( const Partition & partition, OperationDetail & operationdetail ) ;
|
|
bool create( const Partition & new_partition, OperationDetail & operationdetail ) ;
|
|
bool check_repair( const Partition & partition, OperationDetail & operationdetail ) ;
|
|
|
|
private:
|
|
static const Glib::ustring Change_UUID_Warning [] ;
|
|
const Glib::ustring sanitize_label( const Glib::ustring & label ) const;
|
|
};
|
|
|
|
} //GParted
|
|
|
|
#endif /* GPARTED_FAT16_H */
|