mirror of
https://gitlab.gnome.org/GNOME/gparted
synced 2024-10-01 13:44:34 +00:00
21dd6fe00b
A number of GParted methods named get_*() are returning properties and
are return-by-value. For objects this implies the returned value is
copy constructed and later destroyed when it goes out of scope. Change
them to use return-by-constant-reference to avoid unnecessary object
duplication. Just have to make sure the reference goes out of scope
before the referenced object is destroyed to avoid having a reference
(pointer) to freed memory. Assigning to a local variable instead of
of a local reference still duplicates the object so can be used when the
lifetime of the gotten object needs to be longer that the referenced
object.
Previously done for other getters here:
d948cbcb91
Make get_custom_text() and get_generic_text() return by reference
This change just makes Device::get_path() return a constant reference
and updates uses to match to avoid copy constructing the returned value.
Closes !94 - Make more getter methods use return-by-constant-reference
71 lines
1.8 KiB
C++
71 lines
1.8 KiB
C++
/* Copyright (C) 2004 Bart
|
|
* Copyright (C) 2010 Curtis Gedak
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#ifndef GPARTED_DEVICE_H
|
|
#define GPARTED_DEVICE_H
|
|
|
|
#include "Partition.h"
|
|
#include "PartitionVector.h"
|
|
#include "Utils.h"
|
|
|
|
#include <glibmm/ustring.h>
|
|
|
|
|
|
namespace GParted
|
|
{
|
|
|
|
class Device
|
|
{
|
|
|
|
public:
|
|
Device() ;
|
|
~Device() ;
|
|
|
|
Device get_copy_without_partitions() const;
|
|
void set_path( const Glib::ustring & path );
|
|
const Glib::ustring& get_path() const;
|
|
void enable_partition_naming( int length ); // > 0 => enable partition naming support
|
|
bool partition_naming_supported() const;
|
|
int get_max_partition_name_length() const;
|
|
|
|
bool operator==( const Device & device ) const ;
|
|
bool operator!=( const Device & device ) const ;
|
|
|
|
void Reset() ;
|
|
PartitionVector partitions;
|
|
Sector length;
|
|
Sector heads ;
|
|
Sector sectors ;
|
|
Sector cylinders ;
|
|
Sector cylsize ;
|
|
Glib::ustring model;
|
|
Glib::ustring serial_number;
|
|
Glib::ustring disktype;
|
|
int sector_size ;
|
|
int max_prims ;
|
|
int highest_busy ;
|
|
bool readonly ;
|
|
|
|
private:
|
|
Glib::ustring path;
|
|
int max_partition_name_length; // > 0 => naming of partitions is supported on this device
|
|
};
|
|
|
|
} //GParted
|
|
|
|
#endif /* GPARTED_DEVICE_H */
|