Add create_with_label flag to struct FS (#701569)

It was difficult to retrieve whether a filesystem's label can be set on reformat.

The read_label flag can't be used as it decides whether to use the logic in the filesystem class
rather than the fallback in GParted::set_device_partitions, to determine the label of a partition.

The create_with_label flag is NONE for file systems that we cannot format with a
label (or that we cannot format at all).
The value is usually EXTERNAL for file systems that we can format with a label.

include/Utils.h

@@ -126,6 +126,7 @@ struct FS
 	Support read_uuid ;
 	Support write_uuid ;
 	Support create ;
+	Support create_with_label ;  //Can and how to format file system with label
 	Support grow ;
 	Support shrink ;
 	Support move ; //startpoint and endpoint
@@ -139,8 +140,8 @@ struct FS
 	
 	FS()
 	{
-		read = read_label = write_label = read_uuid = write_uuid = create = grow = shrink =
+		read = read_label = write_label = read_uuid = write_uuid = create = create_with_label =
-		move = check = copy = remove = online_read = NONE ;
+		grow = shrink = move = check = copy = remove = online_read = NONE ;
 		MIN = MAX = 0 ;
 	} 
 } ;

src/btrfs.cc

@@ -33,7 +33,10 @@ FS btrfs::get_filesystem_support()
 	fs .filesystem = GParted::FS_BTRFS ;
 
 	if ( ! Glib::find_program_in_path( "mkfs.btrfs" ) .empty() )
+	{
 		fs .create = GParted::FS::EXTERNAL ;
+		fs .create_with_label = GParted::FS::EXTERNAL ;
+	}
 
 	if ( ! Glib::find_program_in_path( "btrfsck" ) .empty() )
 		fs .check = GParted::FS::EXTERNAL ;

src/ext2.cc

@@ -33,6 +33,7 @@ FS ext2::get_filesystem_support()
 	if ( ! Glib::find_program_in_path( "mkfs." + Utils::get_filesystem_string( specific_type ) ).empty() )
 	{
 		fs .create = FS::EXTERNAL ;
+		fs .create_with_label = FS::EXTERNAL ;
 
 		if ( ! Glib::find_program_in_path( "dumpe2fs" ) .empty() )
 			fs .read = FS::EXTERNAL ;

src/f2fs.cc

@@ -28,7 +28,10 @@ FS f2fs::get_filesystem_support()
 	fs .filesystem = FS_F2FS ;
 
 	if ( ! Glib::find_program_in_path( "mkfs.f2fs" ) .empty() )
+	{
 		fs .create = GParted::FS::EXTERNAL ;
+		fs .create_with_label = GParted::FS::EXTERNAL ;
+	}
 
 	fs .copy = FS::GPARTED ;
 	fs .move = FS::GPARTED ;

src/fat16.cc

@@ -68,7 +68,10 @@ FS fat16::get_filesystem_support()
 
 	//find out if we can create fat file systems
 	if ( ! Glib::find_program_in_path( "mkdosfs" ) .empty() )
+	{
 		fs .create = GParted::FS::EXTERNAL ;
+		fs .create_with_label = GParted::FS::EXTERNAL ;
+	}
 
 	if ( ! Glib::find_program_in_path( "dosfsck" ) .empty() )
 	{

src/hfs.cc

@@ -34,7 +34,10 @@ FS hfs::get_filesystem_support()
 #endif
 
 	if ( ! Glib::find_program_in_path( "hformat" ) .empty() )
+	{
 		fs .create = GParted::FS::EXTERNAL ;
+		fs .create_with_label = GParted::FS::EXTERNAL ;
+	}
 
 	if ( ! Glib::find_program_in_path( "hfsck" ) .empty() )
 		fs .check = FS::EXTERNAL ;

src/hfsplus.cc

@@ -34,7 +34,10 @@ FS hfsplus::get_filesystem_support()
 #endif
 
 	if ( ! Glib::find_program_in_path( "mkfs.hfsplus" ) .empty() )
+	{
 		fs .create = GParted::FS::EXTERNAL ;
+		fs .create_with_label = GParted::FS::EXTERNAL ;
+	}
 
 	if ( ! Glib::find_program_in_path( "fsck.hfsplus" ) .empty() )
 		fs .check = FS::EXTERNAL ;

src/jfs.cc

@@ -39,7 +39,10 @@ FS jfs::get_filesystem_support()
 	}
 
 	if ( ! Glib::find_program_in_path( "mkfs.jfs" ) .empty() )
+	{
 		fs .create = GParted::FS::EXTERNAL ;
+		fs .create_with_label = GParted::FS::EXTERNAL ;
+	}
 
 	if ( ! Glib::find_program_in_path( "jfs_fsck" ) .empty() )
 		fs .check = GParted::FS::EXTERNAL ;

src/linux_swap.cc

@@ -46,6 +46,7 @@ FS linux_swap::get_filesystem_support()
 	if ( ! Glib::find_program_in_path( "mkswap" ) .empty() )
 	{
 		fs .create = GParted::FS::EXTERNAL ;
+		fs .create_with_label = GParted::FS::EXTERNAL ;
 		fs .grow = GParted::FS::EXTERNAL ;
 		fs .shrink = GParted::FS::EXTERNAL ;
 	}

src/nilfs2.cc

@@ -29,6 +29,7 @@ FS nilfs2::get_filesystem_support()
 	if ( ! Glib::find_program_in_path( "mkfs.nilfs2" ) .empty() )
 	{
 		fs .create = GParted::FS::EXTERNAL ;
+		fs .create_with_label = GParted::FS::EXTERNAL ;
 	}
 
 	if ( ! Glib::find_program_in_path( "nilfs-tune" ) .empty() )

src/ntfs.cc

@@ -85,7 +85,10 @@ FS ntfs::get_filesystem_support()
 	}
 
 	if ( ! Glib::find_program_in_path( "mkntfs" ) .empty() )
+	{
 		fs .create = GParted::FS::EXTERNAL ;
+		fs .create_with_label = GParted::FS::EXTERNAL ;
+	}
 
 	//resizing is a delicate process ...
 	if ( fs .read && fs .check )

src/reiser4.cc

@@ -35,7 +35,10 @@ FS reiser4::get_filesystem_support()
 	}
 
 	if ( ! Glib::find_program_in_path( "mkfs.reiser4" ) .empty() )
+	{
 		fs .create = GParted::FS::EXTERNAL ;
+		fs .create_with_label = GParted::FS::EXTERNAL ;
+	}
 	
 	if ( ! Glib::find_program_in_path( "fsck.reiser4" ) .empty() )
 		fs .check = GParted::FS::EXTERNAL ;

src/reiserfs.cc

@@ -41,7 +41,10 @@ FS reiserfs::get_filesystem_support()
 	}
 
 	if ( ! Glib::find_program_in_path( "mkreiserfs" ) .empty() )
+	{
 		fs .create = GParted::FS::EXTERNAL ;
+		fs .create_with_label = GParted::FS::EXTERNAL ;
+	}
 	
 	if ( ! Glib::find_program_in_path( "reiserfsck" ) .empty() )
 		fs .check = GParted::FS::EXTERNAL ;

src/xfs.cc

@@ -41,7 +41,10 @@ FS xfs::get_filesystem_support()
 	}
 
 	if ( ! Glib::find_program_in_path( "mkfs.xfs" ) .empty() )
+	{
 		fs .create = GParted::FS::EXTERNAL ;
+		fs .create_with_label = GParted::FS::EXTERNAL ;
+	}
 	
 	if ( ! Glib::find_program_in_path( "xfs_repair" ) .empty() ) 	
 		fs .check = GParted::FS::EXTERNAL ;