gedit is not fully ready for the 'system' theme variant setting.
The GSettings and the preferences dialog UI for the style/color schemes
(coming from libgedit-gtksourceview) need some work to be able to choose
the one that is set for a light GTK theme, and the one that is set for a
dark GTK theme.
So in the meantime, in order for gedit to be in a releasable state, use
the simplified API from Tepl. Only "force light" and "force dark" are
supported, so gedit doesn't take into account the system setting.
However with some scripting it would be possible to achieve the desired
behavior when the system setting for the GTK theme changes, adapting
automatically the style/color scheme.
There are currently a lot of these warnings, and fixing them all will
take some time. Basic casts can be done, but it's better to see if
changing one of the variable type (gint <-> guint) would be a better
solution. This needs to look at what the code actually does, what
functions are called, etc.
The inline_side_panel_switcher is implied by the fact that there is an
headerbar or not.
The GEDIT_HAS_HEADERBAR macroconstant still needs to be used in other
places, to actually create the headerbars or not.
Always #define it, and rename to OS_MACOS.
By always having the macroconstant (either set to 0 or 1), we can use
'#if', and with '#if' the config.h always needs to be included.
config.h was not included in gedit-file-bookmarks-store.c, so this
commit normally fixes a bug.
The warning was:
WARNING: You should add the boolean check kwarg to the run_command call.
It currently defaults to false,
but it will default to true in future releases of meson.
See also: https://github.com/mesonbuild/meson/issues/9300
The gedit 43.x versions have the API version 43.
The API version of gedit only needs to be bumped when there is an API or
ABI break. Which isn't the case for the moment.
Amtk 5.5.2 is needed for
amtk_application_window_create_open_recent_menu_base().
When using amtk_application_window_create_open_recent_menu() (so the
more complete one), it calls g_application_open() which is not suitable
in gedit, because it calls _gedit_cmd_load_files_from_prompt(). From
prompt, if the file doesn't exist, it sets the 'create' param to TRUE,
which creates the file, so it doesn't show a warning infobar if the file
doesn't exist.
When opening a file from the recent menu, we *want* a warning infobar if
the file doesn't exist instead of showing an empty document. (if it
shows an empty document, we may think that the file *exists* and is
empty).
When briefly looking at the API docs of these two functions, it's hard
to know if they are implemented exactly the same.
But when looking at the *implementation* of g_pattern_match(), it just
calls directly g_pattern_spec_match() with the same args.
Tested with printf-debugging, the pattern correctly matches *.la files
(from a built Autotools project).
So everything should be fine, and the feature still works.
This reverts commit 661db63099, reversing
changes made to a8cb2b57f9.
It is to basically come back to:
commit a8cb2b57f9
the previous version of gedit based on the Tepl library.
The goal is to continue the gedit development (on master), but based on
the Tepl library.
