From a4d30a3a2abfd66c9d1961bae3ca10f9868e71b7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=A9bastien=20Wilmet?= <swilmet@mailfence.com>
Date: Sun, 24 Mar 2024 02:55:57 +0100
Subject: [PATCH] Window: remove the ::tabs-reordered signal (unused)

---
 docs/reference/api-breaks.xml |  8 ++++++++
 gedit/gedit-window.c          | 12 ------------
 gedit/gedit-window.h          | 10 ++++------
 3 files changed, 12 insertions(+), 18 deletions(-)

diff --git a/docs/reference/api-breaks.xml b/docs/reference/api-breaks.xml
index 26b954927..1afa76fa6 100644
--- a/docs/reference/api-breaks.xml
+++ b/docs/reference/api-breaks.xml
@@ -32,6 +32,14 @@
           not an essential API).
         </para>
       </listitem>
+      <listitem>
+        <para>
+          The <code>GeditWindow::tabs-reordered</code> signal has been removed.
+          It was unused. Also, functions like
+          <link linkend="gedit-window-get-documents">gedit_window_get_documents()</link>
+          don't specify the order in which the objects are listed.
+        </para>
+      </listitem>
       <listitem>
         <para>
           The <code>gedit_utils_location_get_dirname_for_display()</code>
diff --git a/gedit/gedit-window.c b/gedit/gedit-window.c
index 913fead13..13572b4c5 100644
--- a/gedit/gedit-window.c
+++ b/gedit/gedit-window.c
@@ -133,7 +133,6 @@ enum
 {
 	SIGNAL_TAB_ADDED,
 	SIGNAL_TAB_REMOVED,
-	SIGNAL_TABS_REORDERED,
 	SIGNAL_ACTIVE_TAB_CHANGED,
 	N_SIGNALS
 };
@@ -461,15 +460,6 @@ gedit_window_class_init (GeditWindowClass *klass)
 			      1,
 			      GEDIT_TYPE_TAB);
 
-	signals[SIGNAL_TABS_REORDERED] =
-		g_signal_new ("tabs-reordered",
-			      G_OBJECT_CLASS_TYPE (object_class),
-			      G_SIGNAL_RUN_FIRST,
-			      G_STRUCT_OFFSET (GeditWindowClass, tabs_reordered),
-			      NULL, NULL, NULL,
-			      G_TYPE_NONE,
-			      0);
-
 	/**
 	 * GeditWindow::active-tab-changed:
 	 * @window: the #GeditWindow emitting the signal.
@@ -1821,8 +1811,6 @@ on_page_reordered (GeditMultiNotebook *multi,
                    GeditWindow        *window)
 {
 	update_actions_sensitivity (window);
-
-	g_signal_emit (G_OBJECT (window), signals[SIGNAL_TABS_REORDERED], 0);
 }
 
 static GtkNotebook *
diff --git a/gedit/gedit-window.h b/gedit/gedit-window.h
index f2d4d678a..b64515cbe 100644
--- a/gedit/gedit-window.h
+++ b/gedit/gedit-window.h
@@ -73,13 +73,11 @@ struct _GeditWindowClass
 	GtkApplicationWindowClass parent_class;
 
 	/* Signals */
-	void	(* tab_added)			(GeditWindow *window,
-						 GeditTab    *tab);
+	void	(* tab_added)	(GeditWindow *window,
+				 GeditTab    *tab);
 
-	void	(* tab_removed)			(GeditWindow *window,
-						 GeditTab    *tab);
-
-	void	(* tabs_reordered)		(GeditWindow *window);
+	void	(* tab_removed)	(GeditWindow *window,
+				 GeditTab    *tab);
 };
 
 /* Public methods */