Commit graph

8276 commits

Author SHA1 Message Date
Mathieu Comandon 8eeeadbb7e
Update README.rst 2023-02-02 14:53:47 -08:00
Daniel Johnson 372adfd66a Check 'Launch Game' only if there's one file
Since it will prevent installation of multiple ROMs we shouldn't do that
by default.
2023-02-01 18:53:52 -05:00
Mathieu Comandon 17decbfb28 Avoid crash if configuration file is not present 2023-02-01 13:34:41 -08:00
Daniel Johnson 32cd1b72cf Also fire 'game-updated' for each ROM imported.
This causes the LutrisWindow to update and show the imported game.
2023-01-31 19:39:00 -05:00
Daniel Johnson 032b18ba68 Merge remote-tracking branch 'origin/master' 2023-01-31 19:18:43 -05:00
Daniel Johnson 2efd583fa1 Enable multiple ROMs to be imported via drag & drop.
The 'launch game' UI works rather poorly with multiple ROMs, but I tried
to preserve the UI as much as possible for this commit. If 'launch game'
 is checked, as is the default, it will stop after finding or installing
  a game, and not install any more. Not great.

It will install at most game per file, and accepts the first match that
works.
2023-01-31 19:18:25 -05:00
Mathieu Comandon 4d3d04d4ec Minor adjustment to prefix scanner 2023-01-31 15:57:05 -08:00
Mathieu Comandon 40cd119aea Prefix scanning implementation 2023-01-31 13:21:40 -08:00
Mathieu Comandon 03581a121b Fix crash preventing adding installed version of a game 2023-01-30 23:11:46 -08:00
Mathieu Comandon 7f4e3ba672 Skip MAME roms referenced by their ID 2023-01-30 22:40:19 -08:00
Mathieu Comandon ff21da97bf Add Jaguar to default installers 2023-01-30 21:56:08 -08:00
Mathieu Comandon af63d72bf0 Add missing games section in the side bar 2023-01-30 21:52:23 -08:00
Mathieu Comandon 7eceeaeb8c Improve path cache generation 2023-01-30 19:56:23 -08:00
Mathieu Comandon 021a687fea Build a cache with game paths 2023-01-30 19:25:16 -08:00
Mathieu Comandon cbec00994f Don't say a non existent path is 'protected' 2023-01-30 16:40:12 -08:00
Daniel Johnson a0f3806972 Use OrderedDict to track filenames
Instead of tampering with the dict() that search_tosec_by_md5 returns,
we can make the filename a key. Much cleaner.

Current Python3 dict() is ordered, but we support some older versions,
so I use OrderedDict explicitly just to be safe.
2023-01-29 10:33:52 -05:00
Daniel Johnson 7a8c93400b Add the less hyphenated form for Atari 2600 2023-01-29 10:06:50 -05:00
Daniel Johnson a26b8ed611 Update progress message on GUI main thread
It seems like it is working, but I do not think it is safe to update
labels from a worker thread.

This change uses idle_add to do this on the main thread.

This creates a race condition, when the progress idle operation might
arrive after the game results are displayed. To avoid this, I've
introduced more labels that are shown or hidden at the end, so this
won't be visible.
2023-01-29 09:48:37 -05:00
Daniel Johnson 047a021acc More Import ROM Dialog Error Handling
Errors that occur during the hash search get piped back to the UI and
displayed.

I've added an error for ROMs that are just unknown.
2023-01-29 09:25:59 -05:00
Daniel Johnson 47949ca116 Some visual tweaks for the Import ROM Dialog
Not too much, but not having margin on the right was bugging me!
2023-01-29 09:00:27 -05:00
Daniel Johnson 8bc155b2e4 Add error reporting to Import ROM dialog
I put in another label in the stack to be shown if an import has an
error, with red italic text.

I've also added errors for unknown platforms (scandalously, the
Fairchild Channel F is not known!) and for missing default installers.
2023-01-29 08:52:06 -05:00
Daniel Johnson 945c310b5b Tweak that bug-fix a bit
Let's not search for steam twice in a row, and let's not accept an empty
path either.
2023-01-29 08:16:05 -05:00
Daniel Johnson c57b22049e
Merge pull request #4728 from semjon00/master
Fix failure to start a game if Steam is not installed and Proton-GE is used
2023-01-29 08:11:41 -05:00
semjon00 4600390afc Fixes failure to start a game
if Steam is not installed and Proton-GE is used
2023-01-29 15:07:54 +02:00
Daniel Johnson f43ba06dd4 Do not launch games on a worker thread
Raising the game-launch signal can cause dialogs to be shown, and doing this on a worker thread make X very unhappy. Lutris will outright crash.

Therefore, we now pack the game up in the result list-of-dicts-thing and detect it in the search_result_finished().

This approach should let us support dropping multiple ROMs someday, I think.
2023-01-28 19:42:53 -05:00
Daniel Johnson c6fef12a23 Satisfy PyLint
Mostly this adjusts whitespace, and adds some # pylint: disable directives to go with # noqa.

However, this also replaces a very obscure misuse of and/or with if/else. Because really it's just one character longer this way and much more obvious.
2023-01-28 18:28:51 -05:00
Daniel Johnson 9bce481c68 Cprrect spelling error 2023-01-28 18:08:51 -05:00
Mathieu Comandon d5eaf58214
Merge pull request #4690 from GoGoOtaku/master
Add itch.io service
2023-01-28 11:44:29 -08:00
Daniel Johnson 6e332e152d Add @watch_errors() to various signal handlers 2023-01-28 10:56:53 -05:00
Mathieu Comandon 0f03fc212f Fix some IDs 2023-01-28 05:29:22 -08:00
Ophelia Beatrice de Sica b819bb8b8a Fix code quality with make sc 2023-01-28 14:26:33 +01:00
Ophelia Beatrice de Sica f0c49a46f3 Add itch.io service 2023-01-28 14:15:10 +01:00
Mathieu Comandon bcfcf92bf4 Add support for Battle.net 2023-01-28 05:05:15 -08:00
Mathieu Comandon fca970713c Add HTTP client for Battle.net from Galaxy integration 2023-01-27 16:02:25 -08:00
Mathieu Comandon 8682b271c6 Remove unneeded log message 2023-01-27 16:00:19 -08:00
Mathieu Comandon 8d6cbe043f Remove print statement 2023-01-27 15:49:03 -08:00
Mathieu Comandon 395aa53fbf Also save playtime with lastplayed 2023-01-26 21:13:30 -08:00
Mathieu Comandon 18965f1e47 Remove pixbuf debug message 2023-01-26 19:29:52 -08:00
Mathieu Comandon bbb90af445 More complete message for the HB cookie importer 2023-01-26 19:21:51 -08:00
Mathieu Comandon 12ec851f5c Provide alternate method to login to Humble Bundle 2023-01-26 17:38:47 -08:00
Daniel Johnson c82d6eb5af Fix little merge oopsie
The DVD icon was removed in the PR; it wasn't a replacement for the '>'.
2023-01-26 18:57:33 -05:00
Mathieu Comandon d9c15d4fb4
Merge pull request #4689 from geajack/issue-4680
Change "Install Windows game" button to better reflect intent
2023-01-26 15:50:03 -08:00
Mathieu Comandon 133c1990e1
Merge branch 'master' into issue-4680 2023-01-26 15:49:47 -08:00
Dwahgon ae21d7738c fix: show Steam source if Steam is flatpaked 2023-01-26 15:48:16 -08:00
Daniel Johnson d18708a770 Update some UI text with @strycore's suggestions 2023-01-26 15:47:47 -08:00
Daniel Johnson 230b86aa5d Add 'Import a ROM' to the add games window 2023-01-26 15:47:47 -08:00
Daniel Johnson 9d00485ebf Provide a checkbox for 32-bit Wine prefixes in the add-games window.
This appears only on 64-bit systems and is not recommended; but if you don't set this up front, you can't change it later.

Resolves #4708
2023-01-26 15:47:47 -08:00
Daniel Johnson f217af5def Use more grids for a more consistent, more tightly packed layout. 2023-01-26 15:47:47 -08:00
Daniel Johnson 409edbf23a Add an identifier field to the install-from-setup page 2023-01-26 15:47:47 -08:00
Daniel Johnson 2e85059ac8 Corrent spellink eerror. 2023-01-26 15:47:47 -08:00