gaming/lutris
gaming/lutris
1
0
Fork 0
mirror of https://github.com/lutris/lutris synced 2024-10-02 22:14:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

Do editable-grids (environment vars) in options with boxes, not Gtk.Grid.

Browse source 
Gtk.Grid is madness on toast, and confuses not just be but GTK's layout engine, which bugs out and places this wrongly when you filter the options. It also mis-sizes the buttons under the grid.

Replace the Gtk.Grid with a couple of Gtk.Box. Caveman brain know Box. Also, size-requests for things.

I've sized the editable grid so that it looks like a nice even number of rows for me. Heavy knows what will happen when your favorite theme though.
This commit is contained in:
Daniel Johnson 2023-11-12 05:56:14 -05:00
parent 3462c5ec59
commit fe55eda11f
1 changed files with 9 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
lutris/gui/widgets/common.py
View file

@ -348,16 +348,12 @@ class VBox(Gtk.Box):
super().__init__(orientation=Gtk.Orientation.VERTICAL, margin_top=18, **kwargs)
class EditableGrid(Gtk.Grid):
class EditableGrid(Gtk.Box):
__gsignals__ = {"changed": (GObject.SIGNAL_RUN_FIRST, None, ())}
def __init__(self, data, columns):
self.columns = columns
super().__init__()
self.set_column_homogeneous(True)
self.set_row_homogeneous(True)
self.set_row_spacing(6)
self.set_column_spacing(6)
super().__init__(orientation=Gtk.Orientation.VERTICAL, spacing=6)
self.liststore = Gtk.ListStore(str, str)
for item in data:
@ -386,14 +382,16 @@ class EditableGrid(Gtk.Grid):
self.delete_button.connect("clicked", self.on_delete)
self.scrollable_treelist = Gtk.ScrolledWindow()
self.scrollable_treelist.set_vexpand(True)
self.scrollable_treelist.set_size_request(-1, 209)
self.scrollable_treelist.add(self.treeview)
self.scrollable_treelist.set_shadow_type(Gtk.ShadowType.IN)
self.attach(self.scrollable_treelist, 0, 0, 5, 5)
self.attach(self.add_button, 5 - len(self.buttons), 6, 1, 1)
for i, button in enumerate(self.buttons[1:]):
self.attach_next_to(button, self.buttons[i], Gtk.PositionType.RIGHT, 1, 1)
self.pack_start(self.scrollable_treelist, True, True, 0)
button_box = Gtk.Box(orientation=Gtk.Orientation.HORIZONTAL, spacing=6)
for button in reversed(self.buttons):
button.set_size_request(80, -1)
button_box.pack_end(button, False, False, 0)
self.pack_end(button_box, False, False, 0)
self.show_all()
def on_add(self, widget): # pylint: disable=unused-argument