diff --git a/.pylintrc b/.pylintrc index fc44bd11c..bc580abcb 100644 --- a/.pylintrc +++ b/.pylintrc @@ -56,12 +56,10 @@ disable= global-statement, invalid-name, missing-docstring, - no-self-use, too-few-public-methods, unexpected-keyword-arg, ungrouped-imports, useless-object-inheritance, - bad-continuation, inconsistent-return-statements, unsubscriptable-object, not-an-iterable, @@ -261,12 +259,6 @@ max-line-length=120 # Maximum number of lines in a module max-module-lines=1000 -# List of optional constructs for which whitespace checking is disabled. `dict- -# separator` is used to allow tabulation in dicts, etc.: {1 : 1,\n222: 2}. -# `trailing-comma` allows a space between comma and closing bracket: (a, ). -# `empty-line` allows space-only lines. -no-space-check=trailing-comma,dict-separator - # Allow the body of a class to be on the same line as the declaration if body # contains single statement. single-line-class-stmt=no @@ -278,36 +270,21 @@ single-line-if-stmt=no [BASIC] -# Naming hint for argument names -argument-name-hint=(([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$ - # Regular expression matching correct argument names argument-rgx=(([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$ -# Naming hint for attribute names -attr-name-hint=(([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$ - # Regular expression matching correct attribute names attr-rgx=(([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$ # Bad variable names which should always be refused, separated by a comma bad-names=foo,bar,baz,toto,tutu,tata -# Naming hint for class attribute names -class-attribute-name-hint=([A-Za-z_][A-Za-z0-9_]{2,30}|(__.*__))$ - # Regular expression matching correct class attribute names class-attribute-rgx=([A-Za-z_][A-Za-z0-9_]{2,30}|(__.*__))$ -# Naming hint for class names -class-name-hint=[A-Z_][a-zA-Z0-9]+$ - # Regular expression matching correct class names class-rgx=[A-Z_][a-zA-Z0-9]+$ -# Naming hint for constant names -const-name-hint=(([A-Z_][A-Z0-9_]*)|(__.*__))$ - # Regular expression matching correct constant names const-rgx=(([A-Z_][A-Z0-9_]*)|(__.*__))$ @@ -315,9 +292,6 @@ const-rgx=(([A-Z_][A-Z0-9_]*)|(__.*__))$ # ones are exempt. docstring-min-length=-1 -# Naming hint for function names -function-name-hint=(([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$ - # Regular expression matching correct function names function-rgx=(([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$ @@ -327,21 +301,12 @@ good-names=i,j,k,ex,Run,_ # Include a hint for the correct naming format with invalid-name include-naming-hint=no -# Naming hint for inline iteration names -inlinevar-name-hint=[A-Za-z_][A-Za-z0-9_]*$ - # Regular expression matching correct inline iteration names inlinevar-rgx=[A-Za-z_][A-Za-z0-9_]*$ -# Naming hint for method names -method-name-hint=(([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$ - # Regular expression matching correct method names method-rgx=(([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$ -# Naming hint for module names -module-name-hint=(([a-z_][a-z0-9_]*)|([A-Z][a-zA-Z0-9]+))$ - # Regular expression matching correct module names module-rgx=(([a-z_][a-z0-9_]*)|([A-Z][a-zA-Z0-9]+))$ @@ -357,9 +322,6 @@ no-docstring-rgx=^_ # to this list to register other decorators that produce valid properties. property-classes=abc.abstractproperty -# Naming hint for variable names -variable-name-hint=(([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$ - # Regular expression matching correct variable names variable-rgx=(([a-z][a-z0-9_]{2,30})|(_[a-z0-9_]*))$ diff --git a/lutris/command.py b/lutris/command.py index 0ef90ca6a..22eda7be2 100644 --- a/lutris/command.py +++ b/lutris/command.py @@ -167,7 +167,7 @@ class MonitoredCommand: """Add the line to the associated LogBuffer object""" self.log_buffer.insert(self.log_buffer.get_end_iter(), line, -1) - def log_handler_console_output(self, line): # pylint: disable=no-self-use + def log_handler_console_output(self, line): """Print the line to stdout""" with contextlib.suppress(BlockingIOError): sys.stdout.write(line) diff --git a/lutris/services/base.py b/lutris/services/base.py index 2fc4e7def..6f30466c8 100644 --- a/lutris/services/base.py +++ b/lutris/services/base.py @@ -13,7 +13,7 @@ from lutris.database.games import add_game, get_game_by_field, get_games from lutris.database.services import ServiceGameCollection from lutris.game import Game from lutris.gui.dialogs import NoticeDialog -from lutris.gui.dialogs.webconnect_dialog import WebConnectDialog, DEFAULT_USER_AGENT +from lutris.gui.dialogs.webconnect_dialog import DEFAULT_USER_AGENT, WebConnectDialog from lutris.gui.views.media_loader import download_media from lutris.gui.widgets.utils import BANNER_SIZE, ICON_SIZE from lutris.installer import get_installers diff --git a/lutris/util/steam/vdf/vdict.py b/lutris/util/steam/vdf/vdict.py index 8e9f2a1e0..e42283273 100644 --- a/lutris/util/steam/vdf/vdict.py +++ b/lutris/util/steam/vdf/vdict.py @@ -1,4 +1,4 @@ -# pylint: disable=no-member +# pylint: disable=no-member,unnecessary-dunder-call from collections import Counter _iter_values = 'values'