gaming/lutris
gaming/lutris
1
0
Fork 0
mirror of https://github.com/lutris/lutris synced 2024-10-15 04:02:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Enforce the same ordering of services as before this PR

Browse source 
Platforms and runners are alphabetical, but services have a fixed order.

That order puts Lutris first. I think I see what's up here.
This commit is contained in:
Daniel Johnson 2023-04-02 18:42:42 -04:00 committed by Mathieu Comandon
parent cb65db4f02
commit da288d7799
1 changed files with 23 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
lutris/gui/widgets/sidebar.py
View file

@ -15,6 +15,7 @@ from lutris.gui.dialogs import ErrorDialog
from lutris.gui.dialogs.runner_install import RunnerInstallDialog
from lutris.gui.widgets.utils import has_stock_icon
from lutris.installer.interpreter import ScriptInterpreter
from lutris.services import SERVICES
from lutris.services.base import AuthTokenExpired, BaseService
from lutris.util.jobs import AsyncCall
@ -24,6 +25,8 @@ ICON = 2
LABEL = 3
GAMECOUNT = 4
SERVICE_INDICES = {name: index for index, name in enumerate(SERVICES.keys())}
class SidebarRow(Gtk.ListBoxRow):
"""A row in the sidebar containing possible action buttons"""
@ -69,6 +72,12 @@ class SidebarRow(Gtk.ListBoxRow):
self.spinner = Gtk.Spinner()
self.box.pack_end(self.spinner, False, False, 0)
@property
def sort_key(self):
"""An index indicate the place this row has within its type. The id is used
as a tie-breaker."""
return 0
def get_actions(self):
return []
@ -124,6 +133,10 @@ class ServiceSidebarRow(SidebarRow):
)
self.service = service
@property
def sort_key(self):
return SERVICE_INDICES[self.id]
def get_actions(self):
"""Return the definition of buttons to be added to the row"""
displayed_buttons = []
@ -440,7 +453,7 @@ class LutrisSidebar(Gtk.ListBox):
together, and rows in a hopefully reasonable order as we insert them."""
header_row = self.row_headers.get(row.type) if row.type else None
header_index = header_row.header_index if header_row else 0
return header_index, row.id
return header_index, row.sort_key, row.id
def insert_row(row):
"""Find the best place to insert the row, to maintain order, and inserts it there."""
@ -513,16 +526,19 @@ class LutrisSidebar(Gtk.ListBox):
return True
def on_service_auth_changed(self, service):
self.service_rows[service.id].create_button_box()
self.service_rows[service.id].update_buttons()
if service.id in self.service_rows:
self.service_rows[service.id].create_button_box()
self.service_rows[service.id].update_buttons()
return True
def on_service_games_updating(self, service):
self.service_rows[service.id].is_updating = True
self.service_rows[service.id].update_buttons()
if service.id in self.service_rows:
self.service_rows[service.id].is_updating = True
self.service_rows[service.id].update_buttons()
return True
def on_service_games_updated(self, service):
self.service_rows[service.id].is_updating = False
self.service_rows[service.id].update_buttons()
if service.id in self.service_rows:
self.service_rows[service.id].is_updating = False
self.service_rows[service.id].update_buttons()
return True