gaming/lutris
gaming/lutris
1
0
Fork 0
mirror of https://github.com/lutris/lutris synced 2024-09-30 04:54:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

WIP: Further perf fixes

Browse source
This commit is contained in:
Patrick Griffis 2017-06-01 20:54:40 -04:00
parent 2588e5b6ab
commit d34f4650e8
2 changed files with 8 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
lutris/gui/gameviews.py
View file

@ -129,7 +129,6 @@ class GameStore(GObject.Object):
for row in self.store:
if row[COL_ID] == id_:
row[COL_ICON] = pixbuf
self.emit('icons-changed', self.icon_type) # Obsolete, only for GridView
break
else:
logger.debug('Got pixbuf for unknown id {}'.format(id_))
@ -271,9 +270,6 @@ class GameView(object):
else:
logger.debug('Got pixbuf for unknown id {}'.format(id_))
if type(self) is GameGridView:
GLib.idle_add(self.queue_draw)
def update_image(self, game_id, is_installed=False):
"""Update game icon."""
row = self.get_row_by_id(game_id)

20
lutris/gui/widgets/utils.py
View file

@ -25,7 +25,7 @@ IMAGE_SIZES = {
}
def get_pixbuf(image, size, callback, fallback=None):
def get_pixbuf(image, size, callback, fallback=None, transparent=False):
"""Return a pixbuf from file `image` at `size` or fallback to `fallback`"""
def read_file(image):
@ -39,7 +39,12 @@ def get_pixbuf(image, size, callback, fallback=None):
pixbuf = GdkPixbuf.Pixbuf.new_from_file_at_size(fallback, x, y)
else:
raise
GLib.idle_add(callback, pixbuf)
if transparent:
transparent_pixbuf = get_overlay(size).copy()
pixbuf.composite(transparent_pixbuf, 0, 0, size[0], size[1],
0, 0, 1, 1, GdkPixbuf.InterpType.NEAREST, 100)
pixbuf = transparent_pixbuf
GLib.idle_add(callback, pixbuf, priority=GLib.PRIORITY_LOW)
thread = threading.Thread(target=read_file, args=(image,))
thread.start()
@ -85,13 +90,4 @@ def get_pixbuf_for_game(game_slug, icon_type, callback, is_installed=True):
return
size = IMAGE_SIZES[icon_type]
def on_not_installed_pixbuf(pixbuf):
transparent_pixbuf = get_overlay(size).copy()
# TODO: Composite off main thread?
pixbuf.composite(transparent_pixbuf, 0, 0, size[0], size[1],
0, 0, 1, 1, GdkPixbuf.InterpType.NEAREST, 100)
callback(transparent_pixbuf)
finish_callback = on_not_installed_pixbuf if not is_installed else callback
get_pixbuf(icon_path, size, finish_callback, fallback=default_icon_path)
get_pixbuf(icon_path, size, callback, fallback=default_icon_path, transparent=is_installed)