gaming/lutris
gaming/lutris
1
0
Fork 0
mirror of https://github.com/lutris/lutris synced 2024-10-14 19:53:53 +00:00
Code Issues Packages Projects Releases Wiki Activity

None of the callers of get_runner_module() or import_runner() or import_task() check for None; so use an exception to crash with better style.

Browse source
This commit is contained in:
Daniel Johnson 2024-01-01 10:28:47 -05:00
parent b047ef688d
commit 859b681388
1 changed files with 4 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
lutris/runners/__init__.py
View file

@ -67,7 +67,10 @@ class NonInstallableRunnerError(LutrisError):
def get_runner_module(runner_name):
if runner_name not in __all__:
raise InvalidRunnerError("Invalid runner name '%s'" % runner_name)
return __import__("lutris.runners.%s" % runner_name, globals(), locals(), [runner_name], 0)
module = __import__("lutris.runners.%s" % runner_name, globals(), locals(), [runner_name], 0)
if not module:
raise InvalidRunnerError("Runner module for '%s' could not be imported." % runner_name)
return module
def import_runner(runner_name):
@ -76,16 +79,12 @@ def import_runner(runner_name):
return ADDON_RUNNERS[runner_name]
runner_module = get_runner_module(runner_name)
if not runner_module:
return None
return getattr(runner_module, runner_name)
def import_task(runner, task):
"""Return a runner task."""
runner_module = get_runner_module(runner)
if not runner_module:
return None
return getattr(runner_module, task)