gaming/lutris
gaming/lutris
1
0
Fork 0
mirror of https://github.com/lutris/lutris synced 2024-09-21 00:31:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

Also check for removeability when cancelling an installation

Browse source 
This protects the same directories as when removing games,
and also checks of the target_dir even exists yet.

If we can't remove the dir, this simply omits the checkbox entirely.

Resolves #4330
This commit is contained in:
Daniel Johnson 2022-07-16 09:27:46 -04:00
parent 941a233638
commit 4685090684
1 changed files with 14 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
lutris/gui/installerwindow.py
View file

@ -4,6 +4,7 @@ from gettext import gettext as _
from gi.repository import GLib, Gtk
from lutris.config import LutrisConfig
from lutris.exceptions import UnavailableGame
from lutris.game import Game
from lutris.gui.dialogs import DirectoryDialog, InstallerSourceDialog, QuestionDialog
@ -19,6 +20,7 @@ from lutris.util import xdgshortcuts
from lutris.util.log import logger
from lutris.util.steam import shortcut as steam_shortcut
from lutris.util.strings import add_url_tags, gtk_safe, human_size
from lutris.util.system import is_removeable, path_contains
class InstallerWindow(BaseApplicationWindow): # pylint: disable=too-many-public-methods
@ -551,15 +553,24 @@ class InstallerWindow(BaseApplicationWindow): # pylint: disable=too-many-public
def confirm_cancel(self, _widget=None):
"""Ask a confirmation before cancelling the install"""
widgets = []
remove_checkbox = Gtk.CheckButton.new_with_label(_("Remove game files"))
if self.interpreter and self.interpreter.target_path:
remove_checkbox.set_active(self.interpreter.game_dir_created)
remove_checkbox.show()
config = LutrisConfig()
default_game_path = config.system_config.get("game_path")
if is_removeable(self.interpreter.target_path) and \
not path_contains(self.interpreter.target_path, default_game_path, resolve_symlinks=False):
remove_checkbox.set_active(self.interpreter.game_dir_created)
remove_checkbox.show()
widgets.append(remove_checkbox)
confirm_cancel_dialog = QuestionDialog(
{
"question": _("Are you sure you want to cancel the installation?"),
"title": _("Cancel installation?"),
"widgets": [remove_checkbox]
"widgets": widgets
}
)
if confirm_cancel_dialog.result != Gtk.ResponseType.YES: