Sort by suffix first for versions (Closes #3059)

This commit is contained in:
Mathieu Comandon 2020-10-05 22:17:57 -07:00
parent 38d506dfa3
commit 0ff96b94ab
2 changed files with 2 additions and 2 deletions

View file

@ -74,7 +74,7 @@ def parse_version(version):
version_number = version_match.groups()[0]
prefix = version[0:version_match.span()[0]]
suffix = version[version_match.span()[1]:]
return [int(p) for p in version_number.split(".")], prefix, suffix
return [int(p) for p in version_number.split(".")], suffix, prefix
def version_sort(versions, reverse=False):

View file

@ -94,7 +94,7 @@ class TestStringUtils(TestCase):
class TestVersionSort(TestCase):
def test_parse_version(self):
self.assertEqual(strings.parse_version("3.6-staging"), ([3, 6], '', '-staging'))
self.assertEqual(strings.parse_version("3.6-staging"), ([3, 6], '-staging', ''))
def test_versions_are_correctly_sorted(self):
versions = ['1.8', '1.7.4', '1.9.1', '1.9.10', '1.9.4']