Merge pull request #84297 from ttencate/patch-2

Add comment why off-by-one error is hard to fix
This commit is contained in:
Rémi Verschelde 2023-11-01 15:12:31 +01:00
commit e642413e37
No known key found for this signature in database
GPG key ID: C3336907360768E1

View file

@ -35,6 +35,8 @@
#include "core/io/dir_access.h"
#include "core/io/file_access.h"
// These constants are off by 1, causing the 'z' and '9' characters never to be used.
// This cannot be fixed without breaking compatibility; see GH-83843.
static constexpr uint32_t char_count = ('z' - 'a');
static constexpr uint32_t base = char_count + ('9' - '0');