mirror of
https://github.com/godotengine/godot
synced 2024-09-05 14:18:29 +00:00
Fix use-after-free for VkAttachmentReference
In the flow where VK_KHR_CREATE_RENDERPASS_2_EXTENSION_NAME does not exist VkAttachmentReference are created inside a loop and their backing buffer is referenced in the subpass object. the VkAttachmentReference vectors are freed once the loop exists, causing the subpass to point to freed data. Add all the VkAttachmentReference to a vector in the scope of the entire function, to ensure they are not freed until vkCreateRenderPass is called
This commit is contained in:
parent
9f68d06ec2
commit
d104d8447b
|
@ -101,6 +101,7 @@ VkResult VulkanContext::vkCreateRenderPass2KHR(VkDevice p_device, const VkRender
|
|||
attachments.push_back(att);
|
||||
}
|
||||
|
||||
Vector<Vector<VkAttachmentReference>> attachment_references;
|
||||
Vector<VkSubpassDescription> subpasses;
|
||||
for (uint32_t i = 0; i < p_create_info->subpassCount; i++) {
|
||||
// Here we need to do more, again it's just stripping out type and next
|
||||
|
@ -124,6 +125,10 @@ VkResult VulkanContext::vkCreateRenderPass2KHR(VkDevice p_device, const VkRender
|
|||
p_create_info->pSubpasses[i].preserveAttachmentCount, /* preserveAttachmentCount */
|
||||
p_create_info->pSubpasses[i].pPreserveAttachments /* pPreserveAttachments */
|
||||
};
|
||||
attachment_references.push_back(input_attachments);
|
||||
attachment_references.push_back(color_attachments);
|
||||
attachment_references.push_back(resolve_attachments);
|
||||
attachment_references.push_back(depth_attachments);
|
||||
|
||||
subpasses.push_back(subpass);
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue