mirror of
https://github.com/godotengine/godot
synced 2024-09-05 05:38:35 +00:00
Core: Identity compare objects by id, not by pointers
This commit is contained in:
parent
6296b46008
commit
c5f7a89b0f
|
@ -3499,7 +3499,7 @@ bool Variant::identity_compare(const Variant &p_variant) const {
|
|||
|
||||
switch (type) {
|
||||
case OBJECT: {
|
||||
return _get_obj().obj == p_variant._get_obj().obj;
|
||||
return _get_obj().id == p_variant._get_obj().id;
|
||||
} break;
|
||||
|
||||
case DICTIONARY: {
|
||||
|
|
|
@ -1056,6 +1056,14 @@ TEST_CASE("[Variant] Identity comparison") {
|
|||
Variant obj_null_two_var = Variant((Object *)nullptr);
|
||||
CHECK(obj_null_one_var.identity_compare(obj_null_one_var));
|
||||
CHECK(obj_null_one_var.identity_compare(obj_null_two_var));
|
||||
|
||||
Object *freed_one = new Object();
|
||||
Variant freed_one_var = freed_one;
|
||||
delete freed_one;
|
||||
Object *freed_two = new Object();
|
||||
Variant freed_two_var = freed_two;
|
||||
delete freed_two;
|
||||
CHECK_FALSE(freed_one_var.identity_compare(freed_two_var));
|
||||
}
|
||||
|
||||
TEST_CASE("[Variant] Nested array comparison") {
|
||||
|
|
Loading…
Reference in a new issue