gaming/godot
gaming/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot synced 2024-11-02 14:03:02 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #54078 from Rubonnek/add_hex_messages_master

Browse source 
Add error messages to `String::hex_to_int`, and accept capital X in prefix
This commit is contained in:
Rémi Verschelde 2021-10-21 19:37:11 +02:00 committed by GitHub
commit b6f4f23a5e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
core/string/ustring.cpp
View file

@ -2137,7 +2137,7 @@ int64_t String::hex_to_int() const {
s++;
}
if (len > 2 && s[0] == '0' && s[1] == 'x') {
if (len > 2 && s[0] == '0' && lower_case(s[1]) == 'x') {
s += 2;
}
@ -2151,7 +2151,7 @@ int64_t String::hex_to_int() const {
} else if (c >= 'a' && c <= 'f') {
n = (c - 'a') + 10;
} else {
return 0;
ERR_FAIL_COND_V_MSG(true, 0, "Invalid hexadecimal notation character \"" + chr(*s) + "\" in string \"" + *this + "\".");
}
// Check for overflow/underflow, with special case to ensure INT64_MIN does not result in error
bool overflow = ((hex > INT64_MAX / 16) && (sign == 1 || (sign == -1 && hex != (INT64_MAX >> 4) + 1))) || (sign == -1 && hex == (INT64_MAX >> 4) + 1 && c > '0');