Changing method signature in other class in not recognized in working class in typed GDScript #28685

This commit is contained in:
Goral 2019-05-08 18:49:49 +02:00
parent b96cd577c3
commit aabd9980d1
10 changed files with 25 additions and 1 deletions

View file

@ -1302,11 +1302,14 @@ void CodeTextEditor::_on_settings_change() {
}
void CodeTextEditor::_text_changed_idle_timeout() {
_validate_script();
emit_signal("validate_script");
}
void CodeTextEditor::validate_script() {
idle->start();
}
void CodeTextEditor::_warning_label_gui_input(const Ref<InputEvent> &p_event) {
Ref<InputEventMouseButton> mb = p_event;
if (mb.is_valid() && mb->is_pressed() && mb->get_button_index() == BUTTON_LEFT) {

View file

@ -236,6 +236,8 @@ public:
void set_code_complete_func(CodeTextEditorCodeCompleteFunc p_code_complete_func, void *p_ud);
void validate_script();
CodeTextEditor();
};

View file

@ -429,6 +429,8 @@ void ScriptEditor::_go_to_tab(int p_idx) {
if (script != NULL) {
notify_script_changed(script);
}
Object::cast_to<ScriptEditorBase>(c)->validate();
}
if (Object::cast_to<EditorHelp>(c)) {

View file

@ -116,6 +116,8 @@ public:
virtual Control *get_edit_menu() = 0;
virtual void clear_edit_menu() = 0;
virtual void validate() = 0;
ScriptEditorBase() {}
};

View file

@ -1744,3 +1744,7 @@ void ScriptTextEditor::register_editor() {
ScriptEditor::register_create_script_editor_function(create_editor);
}
void ScriptTextEditor::validate() {
this->code_editor->validate_script();
}

View file

@ -215,6 +215,8 @@ public:
virtual void clear_edit_menu();
static void register_editor();
virtual void validate();
ScriptTextEditor();
};

View file

@ -622,3 +622,6 @@ TextEditor::TextEditor() {
code_editor->get_text_edit()->set_drag_forwarding(this);
}
void TextEditor::validate() {
}

View file

@ -140,6 +140,8 @@ public:
virtual Control *get_edit_menu();
virtual void clear_edit_menu();
virtual void validate();
static void register_editor();
TextEditor();

View file

@ -3754,4 +3754,7 @@ void _VisualScriptEditor::_bind_methods() {
ClassDB::bind_method(D_METHOD("remove_custom_node", "name", "category"), &_VisualScriptEditor::remove_custom_node);
ADD_SIGNAL(MethodInfo("custom_nodes_updated"));
}
void VisualScriptEditor::validate() {
}
#endif

View file

@ -280,6 +280,7 @@ public:
virtual Control *get_edit_menu();
virtual void clear_edit_menu();
virtual bool can_lose_focus_on_node_selection() { return false; }
virtual void validate();
static void register_editor();