gaming/godot
gaming/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot synced 2024-09-16 00:48:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Tighter light culling - fix directional lights colinear case

Browse source 
Exactly the same fix as done already for non-directional lights.
This commit is contained in:
lawnjelly 2024-05-10 09:13:05 +01:00
parent da5714ad6e
commit a76243a549
1 changed files with 10 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
servers/rendering/rendering_light_culler.cpp
View file

@ -279,9 +279,11 @@ bool RenderingLightCuller::add_light_camera_planes_directional(LightCullPlanes &
// Create a third point from the light direction. // Create a third point from the light direction.
Vector3 pt2 = pt0 - p_light_source.dir; Vector3 pt2 = pt0 - p_light_source.dir;
// Create plane from 3 points. if (!_is_colinear_tri(pt0, pt1, pt2)) {
Plane p(pt0, pt1, pt2); // Create plane from 3 points.
r_cull_planes.add_cull_plane(p); Plane p(pt0, pt1, pt2);
r_cull_planes.add_cull_plane(p);
}
} }
// Last to 0 edge. // Last to 0 edge.
@ -295,9 +297,11 @@ bool RenderingLightCuller::add_light_camera_planes_directional(LightCullPlanes &
// Create a third point from the light direction. // Create a third point from the light direction.
Vector3 pt2 = pt0 - p_light_source.dir; Vector3 pt2 = pt0 - p_light_source.dir;
// Create plane from 3 points. if (!_is_colinear_tri(pt0, pt1, pt2)) {
Plane p(pt0, pt1, pt2); // Create plane from 3 points.
r_cull_planes.add_cull_plane(p); Plane p(pt0, pt1, pt2);
r_cull_planes.add_cull_plane(p);
}
} }
#ifdef LIGHT_CULLER_DEBUG_LOGGING #ifdef LIGHT_CULLER_DEBUG_LOGGING