gaming/godot
gaming/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot synced 2024-09-16 01:12:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Ensure that rim lighting uses a exponent base greater than zero

Browse source 
This avoids the undefined behavior that happens if the base is zero and the exponent is zero
This commit is contained in:
clayjohn 2022-12-12 13:25:40 -08:00
parent ae86d907e7
commit a062798b76
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
servers/rendering/renderer_rd/shaders/scene_forward_lights_inc.glsl
View file

@ -134,7 +134,8 @@ void light_compute(vec3 N, vec3 L, vec3 V, float A, vec3 light_color, float atte
#endif
#if defined(LIGHT_RIM_USED)
float rim_light = pow(max(0.0, 1.0 - cNdotV), max(0.0, (1.0 - roughness) * 16.0));
// Epsilon min to prevent pow(0, 0) singularity which results in undefined behavior.
float rim_light = pow(max(1e-4, 1.0 - cNdotV), max(0.0, (1.0 - roughness) * 16.0));
diffuse_light += rim_light * rim * mix(vec3(1.0), albedo, rim_tint) * light_color;
#endif