gaming/godot
gaming/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot synced 2024-10-14 09:32:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #71553 from RandomShaper/no_catastrophic_relayout

Browse source 
Prevent infinite cascade of re-layout after label text reshaping
This commit is contained in:
Rémi Verschelde 2023-01-17 15:00:11 +01:00
parent ee7beff3c4 ed8c5cd52f
commit 9ebb3e3107
No known key found for this signature in database
GPG key ID: C3336907360768E1
2 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
scene/gui/label.cpp
View file

@ -222,6 +222,7 @@ void Label::_shape() {
}
}
lines_dirty = false;
lines_shaped_last_width = get_size().width;
}
_update_visible();
@ -596,7 +597,13 @@ void Label::_notification(int p_what) {
} break;
case NOTIFICATION_RESIZED: {
lines_dirty = true;
// It may happen that the reshaping due to this size change triggers a cascade of re-layout
// across the hierarchy where this label belongs to in a way that its size changes multiple
// times, but ending up with the original size it was already shaped for.
// This check prevents the catastrophic, freezing infinite cascade of re-layout.
if (lines_shaped_last_width != get_size().width) {
lines_dirty = true;
}
} break;
}
}

2
scene/gui/label.h
View file

@ -49,6 +49,8 @@ private:
bool uppercase = false;
bool lines_dirty = true;
int lines_shaped_last_width = -1;
bool dirty = true;
bool font_dirty = true;
RID text_rid;