gaming/godot
gaming/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot synced 2024-09-18 20:21:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #84832 from alesliehughes/fix_use_after_free

Browse source 
Fix VisualShader connection use after free.
This commit is contained in:
Rémi Verschelde 2023-11-14 00:03:45 +01:00
parent 8d731b17f1 a30dc67007
commit 8b705af9e5
No known key found for this signature in database
GPG key ID: C3336907360768E1
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
scene/resources/visual_shader.cpp
View file

@ -963,13 +963,13 @@ void VisualShader::remove_node(Type p_type, int p_id) {
for (List<Connection>::Element *E = g->connections.front(); E;) {
List<Connection>::Element *N = E->next();
if (E->get().from_node == p_id || E->get().to_node == p_id) {
g->connections.erase(E);
if (E->get().from_node == p_id) {
g->nodes[E->get().to_node].prev_connected_nodes.erase(p_id);
g->nodes[E->get().to_node].node->set_input_port_connected(E->get().to_port, false);
} else if (E->get().to_node == p_id) {
g->nodes[E->get().from_node].next_connected_nodes.erase(p_id);
}
g->connections.erase(E);
}
E = N;
}