gaming/godot
gaming/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot synced 2024-10-14 17:27:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

drivers/vulkan: limit pEngineName to only the engine name, without its version

Browse source 
It's supposed to be something stable that can be used to identify the engine
(using an equality check), so having the version number in there defeats
the purpose.

While at it, there is no need to prefix it with a second `"GodotEngine"`, nor
to copy the static C string into a C++ string to then extract a C string
from it :)
This commit is contained in:
Eric Engestrom 2021-12-24 01:10:13 +00:00
parent 9d02cfa6b4
commit 83333f7e15
1 changed files with 1 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/vulkan/vulkan_context.cpp
View file

@ -628,14 +628,12 @@ Error VulkanContext::_create_physical_device() {
}
CharString cs = ProjectSettings::get_singleton()->get("application/config/name").operator String().utf8();
String name = "GodotEngine " + String(VERSION_FULL_NAME);
CharString namecs = name.utf8();
const VkApplicationInfo app = {
/*sType*/ VK_STRUCTURE_TYPE_APPLICATION_INFO,
/*pNext*/ nullptr,
/*pApplicationName*/ cs.get_data(),
/*applicationVersion*/ 0,
/*pEngineName*/ namecs.get_data(),
/*pEngineName*/ VERSION_NAME,
/*engineVersion*/ VK_MAKE_VERSION(VERSION_MAJOR, VERSION_MINOR, VERSION_PATCH),
/*apiVersion*/ VK_MAKE_VERSION(vulkan_major, vulkan_minor, 0)
};