gaming/godot
gaming/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot synced 2024-09-05 01:28:44 +00:00
Code Issues Packages Projects Releases Wiki Activity

C#: Avoid GodotSharp as project assembly name

Browse source 
The name GodotSharp conflicts with the name of the Godot assembly,
this causes a cyclic dependency.
This commit is contained in:
Raul Santos 2023-06-15 11:41:56 +02:00
parent 7734146060
commit 7a031be769
No known key found for this signature in database
GPG key ID: B532473AE3A803E4
1 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
modules/mono/utils/path_utils.cpp
View file

@ -232,10 +232,12 @@ String relative_to(const String &p_path, const String &p_relative_to) {
return relative_to_impl(path_abs_norm, relative_to_abs_norm);
}
const Vector<String> reserved_assembly_names = { "GodotSharp", "GodotSharpEditor", "Godot.SourceGenerators" };
String get_csharp_project_name() {
String name = ProjectSettings::get_singleton()->get_setting_with_override("dotnet/project/assembly_name");
String name = GLOBAL_GET("dotnet/project/assembly_name");
if (name.is_empty()) {
name = ProjectSettings::get_singleton()->get_setting_with_override("application/config/name");
name = GLOBAL_GET("application/config/name");
Vector<String> invalid_chars = Vector<String>({ //
// Windows reserved filename chars.
":", "*", "?", "\"", "<", ">", "|",
@ -248,9 +250,16 @@ String get_csharp_project_name() {
name = name.replace(invalid_chars[i], "-");
}
}
if (name.is_empty()) {
name = "UnnamedProject";
}
// Avoid reserved names that conflict with Godot assemblies.
if (reserved_assembly_names.has(name)) {
name += "_";
}
return name;
}