From 3c82f4a37165570985a049be1ab57dcdd2b8fa72 Mon Sep 17 00:00:00 2001 From: Anutrix Date: Thu, 5 Oct 2023 22:11:05 +0530 Subject: [PATCH] Added docs for DRAW_ORDER_REVERSE_LIFETIME constant and minor XR log improvement --- doc/classes/CPUParticles2D.xml | 2 +- doc/classes/CPUParticles3D.xml | 2 +- doc/classes/GPUParticles2D.xml | 3 ++- doc/classes/GPUParticles3D.xml | 3 ++- doc/classes/RenderingServer.xml | 3 ++- servers/xr_server.cpp | 4 +--- 6 files changed, 9 insertions(+), 8 deletions(-) diff --git a/doc/classes/CPUParticles2D.xml b/doc/classes/CPUParticles2D.xml index 051635cb4882..92a57007bdd2 100644 --- a/doc/classes/CPUParticles2D.xml +++ b/doc/classes/CPUParticles2D.xml @@ -297,7 +297,7 @@ Particles are drawn in the order emitted. - Particles are drawn in order of remaining lifetime. + Particles are drawn in order of remaining lifetime. In other words, the particle with the highest lifetime is drawn at the front. Use with [method set_param_min], [method set_param_max], and [method set_param_curve] to set initial velocity properties. diff --git a/doc/classes/CPUParticles3D.xml b/doc/classes/CPUParticles3D.xml index 9d16f3e8a4ce..27404b68bba3 100644 --- a/doc/classes/CPUParticles3D.xml +++ b/doc/classes/CPUParticles3D.xml @@ -322,7 +322,7 @@ Particles are drawn in the order emitted. - Particles are drawn in order of remaining lifetime. + Particles are drawn in order of remaining lifetime. In other words, the particle with the highest lifetime is drawn at the front. Particles are drawn in order of depth. diff --git a/doc/classes/GPUParticles2D.xml b/doc/classes/GPUParticles2D.xml index 08dc6a533177..2308ec43c5e6 100644 --- a/doc/classes/GPUParticles2D.xml +++ b/doc/classes/GPUParticles2D.xml @@ -141,9 +141,10 @@ Particles are drawn in the order emitted. - Particles are drawn in order of remaining lifetime. + Particles are drawn in order of remaining lifetime. In other words, the particle with the highest lifetime is drawn at the front. + Particles are drawn in reverse order of remaining lifetime. In other words, the particle with the lowest lifetime is drawn at the front. Particle starts at the specified position. diff --git a/doc/classes/GPUParticles3D.xml b/doc/classes/GPUParticles3D.xml index a982c7e40e58..b5af63a8f43e 100644 --- a/doc/classes/GPUParticles3D.xml +++ b/doc/classes/GPUParticles3D.xml @@ -166,9 +166,10 @@ Particles are drawn in the order emitted. - Particles are drawn in order of remaining lifetime. + Particles are drawn in order of remaining lifetime. In other words, the particle with the highest lifetime is drawn at the front. + Particles are drawn in reverse order of remaining lifetime. In other words, the particle with the lowest lifetime is drawn at the front. Particles are drawn in order of depth. diff --git a/doc/classes/RenderingServer.xml b/doc/classes/RenderingServer.xml index e5409a6e8aca..da075827734d 100644 --- a/doc/classes/RenderingServer.xml +++ b/doc/classes/RenderingServer.xml @@ -4505,9 +4505,10 @@ Draw particles in the order that they appear in the particles array. - Sort particles based on their lifetime. + Sort particles based on their lifetime. In other words, the particle with the highest lifetime is drawn at the front. + Sort particles based on the inverse of their lifetime. In other words, the particle with the lowest lifetime is drawn at the front. Sort particles based on their distance to the camera. diff --git a/servers/xr_server.cpp b/servers/xr_server.cpp index 7e2c512554fc..dae342a037c3 100644 --- a/servers/xr_server.cpp +++ b/servers/xr_server.cpp @@ -198,9 +198,7 @@ void XRServer::remove_interface(const Ref &p_interface) { }; ERR_FAIL_COND_MSG(idx == -1, "Interface not found."); - - print_verbose("XR: Removed interface" + p_interface->get_name()); - + print_verbose("XR: Removed interface \"" + p_interface->get_name() + "\""); emit_signal(SNAME("interface_removed"), p_interface->get_name()); interfaces.remove_at(idx); };