gaming/godot
gaming/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot synced 2024-07-19 20:26:19 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity

Merge pull request #76483 from vnen/gdscript-dont-fail-returning-freed-object

Browse source 
GDScript: Don't fail when freed object is return
This commit is contained in:
Rémi Verschelde 2023-04-27 08:47:04 +02:00
parent 58439ac22c abbdf80643
commit 352ebe9725
No known key found for this signature in database
GPG key ID: C3336907360768E1
3 changed files with 17 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
modules/gdscript/gdscript_vm.cpp
View file

@ -1651,10 +1651,6 @@ Variant GDScriptFunction::call(GDScriptInstance *p_instance, const Variant **p_a
bool was_freed = false;
Object *obj = ret->get_validated_object_with_check(was_freed);
if (was_freed) {
err_text = "Got a freed object as a result of the call.";
OPCODE_BREAK;
}
if (obj && obj->is_class_ptr(GDScriptFunctionState::get_class_ptr_static())) {
err_text = R"(Trying to call an async function without "await".)";
OPCODE_BREAK;

15
modules/gdscript/tests/scripts/runtime/features/getter_with_freed_object.gd Normal file
View file

@ -0,0 +1,15 @@
# https://github.com/godotengine/godot/issues/68184
var node: Node:
get:
return node
set(n):
node = n
func test():
node = Node.new()
node.free()
if !is_instance_valid(node):
print("It is freed")

2
modules/gdscript/tests/scripts/runtime/features/getter_with_freed_object.out Normal file
View file

@ -0,0 +1,2 @@
GDTEST_OK
It is freed