gaming/godot
gaming/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot synced 2024-10-14 15:52:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #91677 from KoBeWi/duplication_went_wrong

Browse source 
Fix crash when adding a child while duplicating a node
This commit is contained in:
Rémi Verschelde 2024-05-08 00:34:27 +02:00 committed by GitHub
parent ec78dde748 5c0f7968e3
commit 24ce82727f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
scene/main/node.cpp
View file

@ -2930,8 +2930,10 @@ void Node::_duplicate_properties_node(const Node *p_root, const Node *p_original
}
}
for (int i = 0; i < p_copy->get_child_count(); i++) {
_duplicate_properties_node(p_root, p_original->get_child(i), p_copy->get_child(i));
for (int i = 0; i < p_original->get_child_count(); i++) {
Node *copy_child = p_copy->get_child(i);
ERR_FAIL_NULL_MSG(copy_child, "Child node disappeared while duplicating.");
_duplicate_properties_node(p_root, p_original->get_child(i), copy_child);
}
}