gaming/godot
gaming/godot
1
0
Fork 0
mirror of https://github.com/godotengine/godot synced 2024-09-05 01:58:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #79404 from raulsntos/dotnet/lines-open-in-external-editor

Browse source 
C#: Fix line in OpenInExternalEditor
This commit is contained in:
Rémi Verschelde 2023-08-02 12:17:31 +02:00
parent 2a9aaae8a5 132a1daf1a
commit 2132638937
No known key found for this signature in database
GPG key ID: C3336907360768E1
3 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
editor/editor_interface.cpp
View file

@ -289,7 +289,7 @@ void EditorInterface::edit_node(Node *p_node) {
}
void EditorInterface::edit_script(const Ref<Script> &p_script, int p_line, int p_col, bool p_grab_focus) {
ScriptEditor::get_singleton()->edit(p_script, p_line, p_col, p_grab_focus);
ScriptEditor::get_singleton()->edit(p_script, p_line - 1, p_col - 1, p_grab_focus);
}
void EditorInterface::open_scene_from_path(const String &scene_path) {

6
editor/plugins/script_editor_plugin.cpp
View file

@ -2332,7 +2332,7 @@ bool ScriptEditor::edit(const Ref<Resource> &p_resource, int p_line, int p_col,
}
if (p_line > 0) {
se->goto_line(p_line - 1);
se->goto_line(p_line);
}
}
_update_script_names();
@ -2427,8 +2427,8 @@ bool ScriptEditor::edit(const Ref<Resource> &p_resource, int p_line, int p_col,
_test_script_times_on_disk(p_resource);
_update_modified_scripts_for_external_editor(p_resource);
if (p_line > 0) {
se->goto_line(p_line - 1);
if (p_line >= 0) {
se->goto_line(p_line);
}
notify_script_changed(p_resource);

3
modules/mono/editor/GodotTools/GodotTools/Build/BuildOutputView.cs
View file

@ -138,7 +138,8 @@ namespace GodotTools.Build
{
var script = (Script)ResourceLoader.Load(file, typeHint: Internal.CSharpLanguageType);
if (script != null && Internal.ScriptEditorEdit(script, issue.Line, issue.Column))
// Godot's ScriptEditor.Edit is 0-based but the issue lines are 1-based.
if (script != null && Internal.ScriptEditorEdit(script, issue.Line - 1, issue.Column - 1))
Internal.EditorNodeShowScriptScreen();
}
}