mirror of
https://github.com/godotengine/godot
synced 2024-09-05 04:48:26 +00:00
Quote MSBuild arguments. Fixes #11892
This commit is contained in:
parent
fdc3de009c
commit
14280ac44b
|
@ -106,7 +106,7 @@ namespace GodotSharpTools.Build
|
|||
|
||||
private string BuildArguments(string loggerAssemblyPath, string loggerOutputDir, string[] customProperties)
|
||||
{
|
||||
string arguments = string.Format("{0} /v:normal /t:Build /p:{1} /l:{2},{3};{4}",
|
||||
string arguments = string.Format(@"""{0}"" /v:normal /t:Build ""/p:{1}"" ""/l:{2},{3};{4}""",
|
||||
solution,
|
||||
"Configuration=" + config,
|
||||
typeof(GodotBuildLogger).FullName,
|
||||
|
|
|
@ -461,6 +461,10 @@ void GodotSharpBuilds::BuildProcess::start(bool p_blocking) {
|
|||
if (p_blocking) {
|
||||
exited = true;
|
||||
exit_code = klass->get_field("exitCode")->get_int_value(mono_object);
|
||||
|
||||
if (exit_code != 0 && OS::get_singleton()->is_stdout_verbose())
|
||||
OS::get_singleton()->print(String("MSBuild finished with exit code " + itos(exit_code) + "\n").utf8());
|
||||
|
||||
build_tab->on_build_exit(exit_code == 0 ? MonoBuildTab::RESULT_SUCCESS : MonoBuildTab::RESULT_ERROR);
|
||||
} else {
|
||||
build_instance = MonoGCHandle::create_strong(mono_object);
|
||||
|
|
Loading…
Reference in a new issue