From 045f81023b25cd4ca0ec1e43b1a2ab19ad645d1b Mon Sep 17 00:00:00 2001 From: Juan Linietsky Date: Wed, 20 Dec 2017 13:55:30 -0300 Subject: [PATCH] Properly silence buffer while not in use, fixes #14866 --- servers/audio/audio_stream.cpp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/servers/audio/audio_stream.cpp b/servers/audio/audio_stream.cpp index 15d4a11223ef..6048c4734745 100644 --- a/servers/audio/audio_stream.cpp +++ b/servers/audio/audio_stream.cpp @@ -76,14 +76,14 @@ void AudioStreamPlaybackResampled::mix(AudioFrame *p_buffer, float p_rate_scale, internal_buffer[1] = internal_buffer[INTERNAL_BUFFER_LEN + 1]; internal_buffer[2] = internal_buffer[INTERNAL_BUFFER_LEN + 2]; internal_buffer[3] = internal_buffer[INTERNAL_BUFFER_LEN + 3]; - if (!is_playing()) { - for (int i = 4; i < INTERNAL_BUFFER_LEN; ++i) { - internal_buffer[i] = AudioFrame(0, 0); + if (is_playing()) { + _mix_internal(internal_buffer + 4, INTERNAL_BUFFER_LEN); + } else { + //fill with silence, not playing + for (int i = 0; i < INTERNAL_BUFFER_LEN; ++i) { + internal_buffer[i + 4] = AudioFrame(0, 0); } - - return; } - _mix_internal(internal_buffer + 4, INTERNAL_BUFFER_LEN); mix_offset -= (INTERNAL_BUFFER_LEN << FP_BITS); } }