From 0433d0f54ddc77fd0af143ed8562ff9014d963f4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?R=C3=A9mi=20Verschelde?= Date: Fri, 15 Oct 2021 09:43:23 +0200 Subject: [PATCH] SCons: Remove MD5-timestamp and implicit cache optimizations They haven't really helped save much time on incremental rebuilds, and they do cause potential issues with build correctness (and possibly even one of the cause for overly eager incremental rebuilds). --- SConstruct | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/SConstruct b/SConstruct index b539dc59b723..f952c4d0f6f5 100644 --- a/SConstruct +++ b/SConstruct @@ -314,16 +314,6 @@ if env_base["use_precise_math_checks"]: if env_base["target"] == "debug": env_base.Append(CPPDEFINES=["DEBUG_MEMORY_ALLOC", "DISABLE_FORCED_INLINE"]) - # The two options below speed up incremental builds, but reduce the certainty that all files - # will properly be rebuilt. As such, we only enable them for debug (dev) builds, not release. - - # To decide whether to rebuild a file, use the MD5 sum only if the timestamp has changed. - # https://scons.org/doc/production/HTML/scons-user/ch06.html#idm139837621851792 - env_base.Decider("MD5-timestamp") - # Use cached implicit dependencies by default. Can be overridden by specifying `--implicit-deps-changed` in the command line. - # https://scons.org/doc/production/HTML/scons-user/ch06s04.html - env_base.SetOption("implicit_cache", 1) - if env_base["no_editor_splash"]: env_base.Append(CPPDEFINES=["NO_EDITOR_SPLASH"])