mirror of
https://github.com/Microsoft/vscode
synced 2024-10-30 01:37:20 +00:00
5e92794be6
Resubmission of #157532 with the following changes: - Use `eslint-plugin-local` instead of `yarn` link to run our plugins - Move our plugins to a top level `.eslintplugin` dir (as required by `eslint-plugin-local`) - Update all names to `local/`
40 lines
1.4 KiB
TypeScript
40 lines
1.4 KiB
TypeScript
/*---------------------------------------------------------------------------------------------
|
|
* Copyright (c) Microsoft Corporation. All rights reserved.
|
|
* Licensed under the MIT License. See License.txt in the project root for license information.
|
|
*--------------------------------------------------------------------------------------------*/
|
|
|
|
import * as eslint from 'eslint';
|
|
import { TSESTree, AST_NODE_TYPES } from '@typescript-eslint/experimental-utils';
|
|
|
|
export = new class ApiLiteralOrTypes implements eslint.Rule.RuleModule {
|
|
|
|
readonly meta: eslint.Rule.RuleMetaData = {
|
|
docs: { url: 'https://github.com/microsoft/vscode/wiki/Extension-API-guidelines#creating-objects' },
|
|
messages: { sync: '`createXYZ`-functions are constructor-replacements and therefore must return sync', }
|
|
};
|
|
|
|
create(context: eslint.Rule.RuleContext): eslint.Rule.RuleListener {
|
|
|
|
return {
|
|
['TSDeclareFunction Identifier[name=/create.*/]']: (node: any) => {
|
|
|
|
const decl = <TSESTree.FunctionDeclaration>(<TSESTree.Identifier>node).parent;
|
|
|
|
if (decl.returnType?.typeAnnotation.type !== AST_NODE_TYPES.TSTypeReference) {
|
|
return;
|
|
}
|
|
if (decl.returnType.typeAnnotation.typeName.type !== AST_NODE_TYPES.Identifier) {
|
|
return;
|
|
}
|
|
|
|
const ident = decl.returnType.typeAnnotation.typeName.name;
|
|
if (ident === 'Promise' || ident === 'Thenable') {
|
|
context.report({
|
|
node,
|
|
messageId: 'sync'
|
|
});
|
|
}
|
|
}
|
|
};
|
|
}
|
|
};
|