mirror of
https://github.com/Microsoft/vscode
synced 2024-10-12 22:37:41 +00:00
155cd6db22
* debt - don't make `_insertSuggestion` force-public https://github.com/microsoft/vscode/issues/166603 * fix most implict public making https://github.com/microsoft/vscode/issues/166603 * implict public making causes a build failure * fix one more violation
605 lines
18 KiB
TypeScript
605 lines
18 KiB
TypeScript
/*---------------------------------------------------------------------------------------------
|
|
* Copyright (c) Microsoft Corporation. All rights reserved.
|
|
* Licensed under the MIT License. See License.txt in the project root for license information.
|
|
*--------------------------------------------------------------------------------------------*/
|
|
|
|
import * as ts from 'typescript';
|
|
import * as path from 'path';
|
|
import * as fs from 'fs';
|
|
import { argv } from 'process';
|
|
import { Mapping, SourceMapGenerator } from 'source-map';
|
|
import { pathToFileURL } from 'url';
|
|
|
|
class ShortIdent {
|
|
|
|
private static _keywords = new Set(['await', 'break', 'case', 'catch', 'class', 'const', 'continue', 'debugger',
|
|
'default', 'delete', 'do', 'else', 'export', 'extends', 'false', 'finally', 'for', 'function', 'if',
|
|
'import', 'in', 'instanceof', 'let', 'new', 'null', 'return', 'static', 'super', 'switch', 'this', 'throw',
|
|
'true', 'try', 'typeof', 'var', 'void', 'while', 'with', 'yield']);
|
|
|
|
private static _alphabet = 'abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ'.split('');
|
|
|
|
private _value = 0;
|
|
private readonly _isNameTaken: (name: string) => boolean;
|
|
|
|
constructor(isNameTaken: (name: string) => boolean) {
|
|
this._isNameTaken = name => ShortIdent._keywords.has(name) || isNameTaken(name);
|
|
}
|
|
|
|
next(): string {
|
|
const candidate = ShortIdent.convert(this._value);
|
|
this._value++;
|
|
if (this._isNameTaken(candidate)) {
|
|
// try again
|
|
return this.next();
|
|
}
|
|
return candidate;
|
|
}
|
|
|
|
private static convert(n: number): string {
|
|
const base = this._alphabet.length;
|
|
let result = '';
|
|
do {
|
|
const rest = n % base;
|
|
result += this._alphabet[rest];
|
|
n = (n / base) | 0;
|
|
} while (n > 0);
|
|
return result;
|
|
}
|
|
}
|
|
|
|
const enum FieldType {
|
|
Public,
|
|
Protected,
|
|
Private
|
|
}
|
|
|
|
class ClassData {
|
|
|
|
fields = new Map<string, { type: FieldType; pos: number }>();
|
|
|
|
private replacements: Map<string, string> | undefined;
|
|
|
|
parent: ClassData | undefined;
|
|
children: ClassData[] | undefined;
|
|
|
|
constructor(
|
|
readonly fileName: string,
|
|
readonly node: ts.ClassDeclaration | ts.ClassExpression,
|
|
) {
|
|
// analyse all fields (properties and methods). Find usages of all protected and
|
|
// private ones and keep track of all public ones (to prevent naming collisions)
|
|
|
|
const candidates: (ts.NamedDeclaration)[] = [];
|
|
for (const member of node.members) {
|
|
if (ts.isMethodDeclaration(member)) {
|
|
// method `foo() {}`
|
|
candidates.push(member);
|
|
|
|
} else if (ts.isPropertyDeclaration(member)) {
|
|
// property `foo = 234`
|
|
candidates.push(member);
|
|
|
|
} else if (ts.isGetAccessor(member)) {
|
|
// getter: `get foo() { ... }`
|
|
candidates.push(member);
|
|
|
|
} else if (ts.isSetAccessor(member)) {
|
|
// setter: `set foo() { ... }`
|
|
candidates.push(member);
|
|
|
|
} else if (ts.isConstructorDeclaration(member)) {
|
|
// constructor-prop:`constructor(private foo) {}`
|
|
for (const param of member.parameters) {
|
|
if (hasModifier(param, ts.SyntaxKind.PrivateKeyword)
|
|
|| hasModifier(param, ts.SyntaxKind.ProtectedKeyword)
|
|
|| hasModifier(param, ts.SyntaxKind.PublicKeyword)
|
|
|| hasModifier(param, ts.SyntaxKind.ReadonlyKeyword)
|
|
) {
|
|
candidates.push(param);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
for (const member of candidates) {
|
|
const ident = ClassData._getMemberName(member);
|
|
if (!ident) {
|
|
continue;
|
|
}
|
|
const type = ClassData._getFieldType(member);
|
|
this.fields.set(ident, { type, pos: member.name!.getStart() });
|
|
}
|
|
}
|
|
|
|
private static _getMemberName(node: ts.NamedDeclaration): string | undefined {
|
|
if (!node.name) {
|
|
return undefined;
|
|
}
|
|
const { name } = node;
|
|
let ident = name.getText();
|
|
if (name.kind === ts.SyntaxKind.ComputedPropertyName) {
|
|
if (name.expression.kind !== ts.SyntaxKind.StringLiteral) {
|
|
// unsupported: [Symbol.foo] or [abc + 'field']
|
|
return;
|
|
}
|
|
// ['foo']
|
|
ident = name.expression.getText().slice(1, -1);
|
|
}
|
|
|
|
return ident;
|
|
}
|
|
|
|
private static _getFieldType(node: ts.Node): FieldType {
|
|
if (hasModifier(node, ts.SyntaxKind.PrivateKeyword)) {
|
|
return FieldType.Private;
|
|
} else if (hasModifier(node, ts.SyntaxKind.ProtectedKeyword)) {
|
|
return FieldType.Protected;
|
|
} else {
|
|
return FieldType.Public;
|
|
}
|
|
}
|
|
|
|
static _shouldMangle(type: FieldType): boolean {
|
|
return type === FieldType.Private
|
|
|| type === FieldType.Protected
|
|
;
|
|
}
|
|
|
|
static makeImplicitPublicActuallyPublic(data: ClassData, reportViolation: (name: string, what: string, why: string) => void): void {
|
|
// TS-HACK
|
|
// A subtype can make an inherited protected field public. To prevent accidential
|
|
// mangling of public fields we mark the original (protected) fields as public...
|
|
for (const [name, info] of data.fields) {
|
|
if (info.type !== FieldType.Public) {
|
|
continue;
|
|
}
|
|
let parent: ClassData | undefined = data.parent;
|
|
while (parent) {
|
|
if (parent.fields.get(name)?.type === FieldType.Protected) {
|
|
const parentPos = parent.node.getSourceFile().getLineAndCharacterOfPosition(parent.fields.get(name)!.pos);
|
|
const infoPos = data.node.getSourceFile().getLineAndCharacterOfPosition(info.pos);
|
|
reportViolation(name, `'${name}' from ${parent.fileName}:${parentPos.line + 1}`, `${data.fileName}:${infoPos.line + 1}`);
|
|
|
|
parent.fields.get(name)!.type = FieldType.Public;
|
|
}
|
|
parent = parent.parent;
|
|
}
|
|
}
|
|
}
|
|
|
|
static fillInReplacement(data: ClassData) {
|
|
|
|
if (data.replacements) {
|
|
// already done
|
|
return;
|
|
}
|
|
|
|
// fill in parents first
|
|
if (data.parent) {
|
|
ClassData.fillInReplacement(data.parent);
|
|
}
|
|
|
|
data.replacements = new Map();
|
|
|
|
const identPool = new ShortIdent(name => {
|
|
|
|
// locally taken
|
|
if (data._isNameTaken(name)) {
|
|
return true;
|
|
}
|
|
|
|
// parents
|
|
let parent: ClassData | undefined = data.parent;
|
|
while (parent) {
|
|
if (parent._isNameTaken(name)) {
|
|
return true;
|
|
}
|
|
parent = parent.parent;
|
|
}
|
|
|
|
// children
|
|
if (data.children) {
|
|
const stack = [...data.children];
|
|
while (stack.length) {
|
|
const node = stack.pop()!;
|
|
if (node._isNameTaken(name)) {
|
|
return true;
|
|
}
|
|
if (node.children) {
|
|
stack.push(...node.children);
|
|
}
|
|
}
|
|
}
|
|
|
|
return false;
|
|
});
|
|
|
|
for (const [name, info] of data.fields) {
|
|
if (ClassData._shouldMangle(info.type)) {
|
|
const shortName = identPool.next();
|
|
data.replacements.set(name, shortName);
|
|
}
|
|
}
|
|
}
|
|
|
|
// a name is taken when a field that doesn't get mangled exists or
|
|
// when the name is already in use for replacement
|
|
private _isNameTaken(name: string) {
|
|
if (this.fields.has(name) && !ClassData._shouldMangle(this.fields.get(name)!.type)) {
|
|
// public field
|
|
return true;
|
|
}
|
|
if (this.replacements) {
|
|
for (const shortName of this.replacements.values()) {
|
|
if (shortName === name) {
|
|
// replaced already (happens wih super types)
|
|
return true;
|
|
}
|
|
}
|
|
}
|
|
if ((<any>this.node.getSourceFile()).identifiers instanceof Map) {
|
|
// taken by any other usage
|
|
if ((<any>this.node.getSourceFile()).identifiers.has(name)) {
|
|
return true;
|
|
}
|
|
}
|
|
return false;
|
|
}
|
|
|
|
lookupShortName(name: string): string {
|
|
let value = this.replacements!.get(name)!;
|
|
let parent = this.parent;
|
|
while (parent) {
|
|
if (parent.replacements!.has(name) && parent.fields.get(name)?.type === FieldType.Protected) {
|
|
value = parent.replacements!.get(name)! ?? value;
|
|
}
|
|
parent = parent.parent;
|
|
}
|
|
return value;
|
|
}
|
|
|
|
// --- parent chaining
|
|
|
|
addChild(child: ClassData) {
|
|
this.children ??= [];
|
|
this.children.push(child);
|
|
child.parent = this;
|
|
}
|
|
}
|
|
|
|
class StaticLanguageServiceHost implements ts.LanguageServiceHost {
|
|
|
|
private readonly _cmdLine: ts.ParsedCommandLine;
|
|
private readonly _scriptSnapshots: Map<string, ts.IScriptSnapshot> = new Map();
|
|
|
|
constructor(readonly projectPath: string) {
|
|
const existingOptions: Partial<ts.CompilerOptions> = {};
|
|
const parsed = ts.readConfigFile(projectPath, ts.sys.readFile);
|
|
if (parsed.error) {
|
|
throw parsed.error;
|
|
}
|
|
this._cmdLine = ts.parseJsonConfigFileContent(parsed.config, ts.sys, path.dirname(projectPath), existingOptions);
|
|
if (this._cmdLine.errors.length > 0) {
|
|
throw parsed.error;
|
|
}
|
|
}
|
|
getCompilationSettings(): ts.CompilerOptions {
|
|
return this._cmdLine.options;
|
|
}
|
|
getScriptFileNames(): string[] {
|
|
return this._cmdLine.fileNames;
|
|
}
|
|
getScriptVersion(_fileName: string): string {
|
|
return '1';
|
|
}
|
|
getProjectVersion(): string {
|
|
return '1';
|
|
}
|
|
getScriptSnapshot(fileName: string): ts.IScriptSnapshot | undefined {
|
|
let result: ts.IScriptSnapshot | undefined = this._scriptSnapshots.get(fileName);
|
|
if (result === undefined) {
|
|
const content = ts.sys.readFile(fileName);
|
|
if (content === undefined) {
|
|
return undefined;
|
|
}
|
|
result = ts.ScriptSnapshot.fromString(content);
|
|
this._scriptSnapshots.set(fileName, result);
|
|
}
|
|
return result;
|
|
}
|
|
getCurrentDirectory(): string {
|
|
return path.dirname(this.projectPath);
|
|
}
|
|
getDefaultLibFileName(options: ts.CompilerOptions): string {
|
|
return ts.getDefaultLibFilePath(options);
|
|
}
|
|
directoryExists = ts.sys.directoryExists;
|
|
getDirectories = ts.sys.getDirectories;
|
|
fileExists = ts.sys.fileExists;
|
|
readFile = ts.sys.readFile;
|
|
readDirectory = ts.sys.readDirectory;
|
|
// this is necessary to make source references work.
|
|
realpath = ts.sys.realpath;
|
|
}
|
|
|
|
export interface MangleOutput {
|
|
out: string;
|
|
sourceMap?: string;
|
|
}
|
|
|
|
/**
|
|
* TypeScript2TypeScript transformer that mangles all private and protected fields
|
|
*
|
|
* 1. Collect all class fields (properties, methods)
|
|
* 2. Collect all sub and super-type relations between classes
|
|
* 3. Compute replacement names for each field
|
|
* 4. Lookup rename locations for these fields
|
|
* 5. Prepare and apply edits
|
|
*/
|
|
export class Mangler {
|
|
|
|
private readonly allClassDataByKey = new Map<string, ClassData>();
|
|
|
|
private readonly service: ts.LanguageService;
|
|
|
|
constructor(readonly projectPath: string, readonly log: typeof console.log = () => { }) {
|
|
this.service = ts.createLanguageService(new StaticLanguageServiceHost(projectPath));
|
|
}
|
|
|
|
computeNewFileContents(strictImplicitPublicHandling?: Set<string>): Map<string, MangleOutput> {
|
|
|
|
// STEP: find all classes and their field info
|
|
|
|
const visit = (node: ts.Node): void => {
|
|
if (ts.isClassDeclaration(node) || ts.isClassExpression(node)) {
|
|
const anchor = node.name ?? node;
|
|
const key = `${node.getSourceFile().fileName}|${anchor.getStart()}`;
|
|
if (this.allClassDataByKey.has(key)) {
|
|
throw new Error('DUPE?');
|
|
}
|
|
this.allClassDataByKey.set(key, new ClassData(node.getSourceFile().fileName, node));
|
|
}
|
|
ts.forEachChild(node, visit);
|
|
};
|
|
|
|
for (const file of this.service.getProgram()!.getSourceFiles()) {
|
|
if (!file.isDeclarationFile) {
|
|
ts.forEachChild(file, visit);
|
|
}
|
|
}
|
|
this.log(`Done collecting classes: ${this.allClassDataByKey.size}`);
|
|
|
|
|
|
// STEP: connect sub and super-types
|
|
|
|
const setupParents = (data: ClassData) => {
|
|
const extendsClause = data.node.heritageClauses?.find(h => h.token === ts.SyntaxKind.ExtendsKeyword);
|
|
if (!extendsClause) {
|
|
// no EXTENDS-clause
|
|
return;
|
|
}
|
|
|
|
const info = this.service.getDefinitionAtPosition(data.fileName, extendsClause.types[0].expression.getEnd());
|
|
if (!info || info.length === 0) {
|
|
// throw new Error('SUPER type not found');
|
|
return;
|
|
}
|
|
|
|
if (info.length !== 1) {
|
|
// inherits from declared/library type
|
|
return;
|
|
}
|
|
|
|
const [definition] = info;
|
|
const key = `${definition.fileName}|${definition.textSpan.start}`;
|
|
const parent = this.allClassDataByKey.get(key);
|
|
if (!parent) {
|
|
// throw new Error(`SUPER type not found: ${key}`);
|
|
return;
|
|
}
|
|
parent.addChild(data);
|
|
};
|
|
for (const data of this.allClassDataByKey.values()) {
|
|
setupParents(data);
|
|
}
|
|
|
|
// STEP: make implicit public (actually protected) field really public
|
|
const violations = new Map<string, string[]>();
|
|
let violationsCauseFailure = false;
|
|
for (const data of this.allClassDataByKey.values()) {
|
|
ClassData.makeImplicitPublicActuallyPublic(data, (name: string, what, why) => {
|
|
const arr = violations.get(what);
|
|
if (arr) {
|
|
arr.push(why);
|
|
} else {
|
|
violations.set(what, [why]);
|
|
}
|
|
|
|
if (strictImplicitPublicHandling && !strictImplicitPublicHandling.has(name)) {
|
|
violationsCauseFailure = true;
|
|
}
|
|
});
|
|
}
|
|
for (const [why, whys] of violations) {
|
|
this.log(`WARN: ${why} became PUBLIC because of: ${whys.join(' , ')}`);
|
|
}
|
|
if (violationsCauseFailure) {
|
|
const message = 'Protected fields have been made PUBLIC. This hurts minification and is therefore not allowed. Review the WARN messages further above';
|
|
this.log(`ERROR: ${message}`);
|
|
throw new Error(message);
|
|
}
|
|
|
|
// STEP: compute replacement names for each class
|
|
for (const data of this.allClassDataByKey.values()) {
|
|
ClassData.fillInReplacement(data);
|
|
}
|
|
this.log(`Done creating replacements`);
|
|
|
|
// STEP: prepare rename edits
|
|
type Edit = { newText: string; offset: number; length: number };
|
|
const editsByFile = new Map<string, Edit[]>();
|
|
|
|
const appendEdit = (fileName: string, edit: Edit) => {
|
|
const edits = editsByFile.get(fileName);
|
|
if (!edits) {
|
|
editsByFile.set(fileName, [edit]);
|
|
} else {
|
|
edits.push(edit);
|
|
}
|
|
};
|
|
|
|
for (const data of this.allClassDataByKey.values()) {
|
|
|
|
if (hasModifier(data.node, ts.SyntaxKind.DeclareKeyword)) {
|
|
continue;
|
|
}
|
|
|
|
fields: for (const [name, info] of data.fields) {
|
|
if (!ClassData._shouldMangle(info.type)) {
|
|
continue fields;
|
|
}
|
|
|
|
// TS-HACK: protected became public via 'some' child
|
|
// and because of that we might need to ignore this now
|
|
let parent = data.parent;
|
|
while (parent) {
|
|
if (parent.fields.get(name)?.type === FieldType.Public) {
|
|
continue fields;
|
|
}
|
|
parent = parent.parent;
|
|
}
|
|
|
|
const newText = data.lookupShortName(name);
|
|
const locations = this.service.findRenameLocations(data.fileName, info.pos, false, false, true) ?? [];
|
|
for (const loc of locations) {
|
|
appendEdit(loc.fileName, {
|
|
newText: (loc.prefixText || '') + newText + (loc.suffixText || ''),
|
|
offset: loc.textSpan.start,
|
|
length: loc.textSpan.length
|
|
});
|
|
}
|
|
}
|
|
}
|
|
|
|
this.log(`Done preparing edits: ${editsByFile.size} files`);
|
|
|
|
// STEP: apply all rename edits (per file)
|
|
const result = new Map<string, MangleOutput>();
|
|
let savedBytes = 0;
|
|
|
|
for (const item of this.service.getProgram()!.getSourceFiles()) {
|
|
|
|
const { mapRoot, sourceRoot } = this.service.getProgram()!.getCompilerOptions();
|
|
const projectDir = path.dirname(this.projectPath);
|
|
const sourceMapRoot = mapRoot ?? pathToFileURL(sourceRoot ?? projectDir).toString();
|
|
|
|
// source maps
|
|
let generator: SourceMapGenerator | undefined;
|
|
|
|
let newFullText: string;
|
|
const edits = editsByFile.get(item.fileName);
|
|
if (!edits) {
|
|
// just copy
|
|
newFullText = item.getFullText();
|
|
|
|
} else {
|
|
// source map generator
|
|
const relativeFileName = normalize(path.relative(projectDir, item.fileName));
|
|
const mappingsByLine = new Map<number, Mapping[]>();
|
|
|
|
// apply renames
|
|
edits.sort((a, b) => b.offset - a.offset);
|
|
const characters = item.getFullText().split('');
|
|
|
|
let lastEdit: Edit | undefined;
|
|
|
|
for (const edit of edits) {
|
|
if (lastEdit && lastEdit.offset === edit.offset) {
|
|
//
|
|
if (lastEdit.length !== edit.length || lastEdit.newText !== edit.newText) {
|
|
this.log('ERROR: Overlapping edit', item.fileName, edit.offset, edits);
|
|
throw new Error('OVERLAPPING edit');
|
|
} else {
|
|
continue;
|
|
}
|
|
}
|
|
lastEdit = edit;
|
|
const mangledName = characters.splice(edit.offset, edit.length, edit.newText).join('');
|
|
savedBytes += mangledName.length - edit.newText.length;
|
|
|
|
// source maps
|
|
const pos = item.getLineAndCharacterOfPosition(edit.offset);
|
|
|
|
|
|
let mappings = mappingsByLine.get(pos.line);
|
|
if (!mappings) {
|
|
mappings = [];
|
|
mappingsByLine.set(pos.line, mappings);
|
|
}
|
|
mappings.unshift({
|
|
source: relativeFileName,
|
|
original: { line: pos.line + 1, column: pos.character },
|
|
generated: { line: pos.line + 1, column: pos.character },
|
|
name: mangledName
|
|
}, {
|
|
source: relativeFileName,
|
|
original: { line: pos.line + 1, column: pos.character + edit.length },
|
|
generated: { line: pos.line + 1, column: pos.character + edit.newText.length },
|
|
});
|
|
}
|
|
|
|
// source map generation, make sure to get mappings per line correct
|
|
generator = new SourceMapGenerator({ file: path.basename(item.fileName), sourceRoot: sourceMapRoot });
|
|
generator.setSourceContent(relativeFileName, item.getFullText());
|
|
for (const [, mappings] of mappingsByLine) {
|
|
let lineDelta = 0;
|
|
for (const mapping of mappings) {
|
|
generator.addMapping({
|
|
...mapping,
|
|
generated: { line: mapping.generated.line, column: mapping.generated.column - lineDelta }
|
|
});
|
|
lineDelta += mapping.original.column - mapping.generated.column;
|
|
}
|
|
}
|
|
|
|
newFullText = characters.join('');
|
|
}
|
|
result.set(item.fileName, { out: newFullText, sourceMap: generator?.toString() });
|
|
}
|
|
|
|
this.log(`Done: ${savedBytes / 1000}kb saved`);
|
|
return result;
|
|
}
|
|
}
|
|
|
|
// --- ast utils
|
|
|
|
function hasModifier(node: ts.Node, kind: ts.SyntaxKind) {
|
|
const modifiers = ts.canHaveModifiers(node) ? ts.getModifiers(node) : undefined;
|
|
return Boolean(modifiers?.find(mode => mode.kind === kind));
|
|
}
|
|
|
|
function normalize(path: string): string {
|
|
return path.replace(/\\/g, '/');
|
|
}
|
|
|
|
async function _run() {
|
|
|
|
const projectPath = path.join(__dirname, '../../src/tsconfig.json');
|
|
const projectBase = path.dirname(projectPath);
|
|
const newProjectBase = path.join(path.dirname(projectBase), path.basename(projectBase) + '2');
|
|
|
|
for await (const [fileName, contents] of new Mangler(projectPath, console.log).computeNewFileContents(new Set(['saveState']))) {
|
|
const newFilePath = path.join(newProjectBase, path.relative(projectBase, fileName));
|
|
await fs.promises.mkdir(path.dirname(newFilePath), { recursive: true });
|
|
await fs.promises.writeFile(newFilePath, contents.out);
|
|
if (contents.sourceMap) {
|
|
await fs.promises.writeFile(newFilePath + '.map', contents.sourceMap);
|
|
}
|
|
}
|
|
}
|
|
|
|
if (__filename === argv[1]) {
|
|
_run();
|
|
}
|