vscode/test/smoke
Connor Peet 2138622b04
build: add watch/compile tasks for CLI (#182344)
* build: add watch/compile tasks for CLI

I spent time this morning working on the 'developer experience' of the
CLI in vscode, mainly getting the CLI to cross-compile chasing our
initial idea of having it auto-build in a devcontainer.

After some effort and disabling tunnels connections (to avoid having to
pull in OpenSSL which is a huge pain to cross compile), I was able to
get it to cross-compile from Linux to Windows, using the mingw linker.
I could probably figure out how to get macOS working as well with more
effort. However, I'm not a big fan of this, effectively it's one more
'platform' of build we need to support and test.

I think a better approach is downloading the latest compiled CLI from
the update server instead, as needed. That's what this PR does. It just
places the CLI where it _would_ normally get compiled to by cargo; so
far we don't need to do anything special outside of that.
A notice is shown to users if this fallback happens.

* update from review
2023-06-20 14:34:11 -07:00
..
src Data loss smoke test failures (fix #181952) (#182059) 2023-05-10 14:23:12 +00:00
test Remove legacy smoke test driver (#147393) 2022-04-13 19:19:58 +02:00
.gitignore smoke: fix vscode-test cache location 2021-07-16 15:23:48 +02:00
Audit.md Fix capitalization of GitHub org 2020-09-17 11:43:03 +02:00
package.json build: add watch/compile tasks for CLI (#182344) 2023-06-20 14:34:11 -07:00
README.md smoke - better use of tree-kill 2022-04-05 19:08:33 +02:00
tsconfig.json Enable strict mode and bump target for test/smoke (#165296) 2022-11-02 19:23:58 -07:00
yarn.lock build: add watch/compile tasks for CLI (#182344) 2023-06-20 14:34:11 -07:00

VS Code Smoke Test

Make sure you are on Node v12.x.

Quick Overview

# Build extensions in the VS Code repo (if needed)
yarn && yarn compile

# Dev (Electron)
yarn smoketest

# Dev (Web - Must be run on distro)
yarn smoketest --web --browser [chromium|webkit]

# Build (Electron)
yarn smoketest --build <path to latest version>
example: yarn smoketest --build /Applications/Visual\ Studio\ Code\ -\ Insiders.app

# Build (Web - read instructions below)
yarn smoketest --build <path to server web build (ends in -web)> --web --browser [chromium|webkit]

# Remote (Electron)
yarn smoketest --build <path to latest version> --remote

* This step is necessary only when running without --build and OSS doesn't already exist in the .build/electron directory.

Running for a release (Endgame)

You must always run the smoketest version that matches the release you are testing. So, if you want to run the smoketest for a release build (e.g. release/1.22), you need to check out that version of the smoke tests too:

git fetch
git checkout release/1.22
yarn && yarn compile
yarn --cwd test/smoke

Web

There is no support for testing an old version to a new one yet. Instead, simply configure the --build command line argument to point to the absolute path of the extracted server web build folder (e.g. <rest of path here>/vscode-server-darwin-x64-web for macOS). The server web build is available from the builds page (see previous subsection).

macOS: if you have downloaded the server with web bits, make sure to run the following command before unzipping it to avoid security issues on startup:

xattr -d com.apple.quarantine <path to server with web folder zip>

Note: make sure to point to the server that includes the client bits!

Debug

  • --verbose logs all the low level driver calls made to Code;
  • -f PATTERN (alias -g PATTERN) filters the tests to be run. You can also use pretty much any mocha argument;
  • --headless will run playwright in headless mode when --web is used.

Note: you can enable verbose logging of playwright library by setting a DEBUG environment variable before running the tests (https://playwright.dev/docs/debug#verbose-api-logs), for example to pw:browser.

Develop

cd test/smoke
yarn watch

Troubleshooting

Error: Could not get a unique tmp filename, max tries reached

On Windows, check for the folder C:\Users\<username>\AppData\Local\Temp\t. If this folder exists, the tmp module can't run properly, resulting in the error above. In this case, delete the t folder.

Pitfalls

  • Beware of workbench state. The tests within a single suite will share the same state.

  • Beware of singletons. This evil can, and will, manifest itself under the form of FS paths, TCP ports, IPC handles. Whenever writing a test, or setting up more smoke test architecture, make sure it can run simultaneously with any other tests and even itself. All test suites should be able to run many times in parallel.

  • Beware of focus. Never depend on DOM elements having focus using .focused classes or :focus pseudo-classes, since they will lose that state as soon as another window appears on top of the running VS Code window. A safe approach which avoids this problem is to use the waitForActiveElement API. Many tests use this whenever they need to wait for a specific element to have focus.

  • Beware of timing. You need to read from or write to the DOM... but is it the right time to do that? Can you 100% guarantee that input box will be visible at that point in time? Or are you just hoping that it will be so? Hope is your worst enemy in UI tests. Example: just because you triggered Quick Access with F1, it doesn't mean that it's open and you can just start typing; you must first wait for the input element to be in the DOM as well as be the current active element.

  • Beware of waiting. Never wait longer than a couple of seconds for anything, unless it's justified. Think of it as a human using Code. Would a human take 10 minutes to run through the Search viewlet smoke test? Then, the computer should even be faster. Don't use setTimeout just because. Think about what you should wait for in the DOM to be ready and wait for that instead.