Michael Lively
6671589cdc
fix setting description for #159091
2022-08-24 12:20:38 -07:00
Michael Lively
614c7dd5f4
fix conflict demo
2022-08-24 10:37:37 -07:00
Michael Lively
02cb45c3cb
demo merge conflict
2022-08-23 16:10:56 -07:00
Michael Lively
ae1167bd94
refactor with updated metadata properties
2022-08-23 16:09:30 -07:00
Matt Bierner
f00fde0f24
Mark that notebook metadata is readonly
( #158960 )
...
Mark that metadata is `readonly`
Fixes #158955
We freeze the object here 0656d21d11/src/vs/workbench/api/common/extHostNotebookDocument.ts (L70)
2022-08-23 14:52:00 -07:00
Matt Bierner
b72671133b
Fix any types and extract method ( #158967 )
...
`currentCell` and `notebookUri` are currently any types, which hides type errors. To fix this and clean up the code, I've extracted a new `getCellFromCellDocument` method
2022-08-23 13:57:44 -07:00
Michael Lively
6f7189b7bb
refactor metadata into own fxn
2022-08-18 11:58:44 -07:00
Michael Lively
880fda6ed9
fix pasting image into newly created cell bug
2022-08-17 12:17:39 -07:00
Michael Lively
38477bf5f5
change dir of cellAttachmentRenderer ( #157671 )
...
* change dir of cellAttachmentRenderer
* add new directories to `.vscodeignore`
* add the .js directories back in...
* hopefully now understanding `.vscodeignore`
2022-08-09 20:00:24 +02:00
Michael Lively
9225503c85
Support for pasting images into markdown notebook cells ( #156847 )
...
* dataflow support for updated metadata
* update cellAttachmentRenderer.ts to reflect metadata being a getter() inside MarkupCell
* document paste additions
* update condition to re-render cells, now includes metadata changes
* paste API working, debugging command added
* paste working with metadata. needs numbering, and cleaning upon delete
* paste screenshot works fully
* remove debugging command. Cleaning.
* notebook cells now re-render upon metadata changes
* changed name validity checking, remove unneeded function
* use _document for cell data, use snippet choice, dto fix
* return subscription, for loop, uri fix, alter metadata in-place, better snippet
* metadata fix, object.equals, fix cellAttRenderer metadata call
* added comment with source of encodeBase64
* gate mkdn image paste behind experimental setting
2022-08-08 13:57:49 -07:00
Matt Bierner
68912bd844
Use 'import type' for '@jupyterlab/nbformat' ( #157153 )
...
This is a type only dev dep so we should prevent referencing it as a value
2022-08-04 23:46:53 +02:00
Michael Lively
61e8687fa3
Notebook Cells re-render upon changes to metadata ( #156917 )
...
* dataflow support for updated metadata
* update cellAttachmentRenderer.ts to reflect metadata being a getter() inside MarkupCell
* update condition to re-render cells, now includes metadata changes
* notebook cells now re-render upon metadata changes
* fix missing metadata update
Co-authored-by: Peng Lyu <penn.lv@gmail.com>
2022-08-03 09:46:12 -07:00
Michael Lively
6fbee10cc1
more checking for undefined objects, fixed bug casuing markdown renderer to entirely crash
2022-07-28 11:53:51 -07:00
Matt Bierner
241c770203
Exclude esbuild files from build ( #156362 )
2022-07-27 09:32:07 -04:00
Michael Lively
53c3028c47
add notebook-out to .gitignore
2022-07-26 12:29:23 -07:00
Michael Lively
2077ae5120
fix package.json/esbuild.js for files in publish
2022-07-26 12:19:27 -07:00
Peng Lyu
e6ad5f0a6f
Update ipynb yarn lock ( #156004 )
2022-07-22 23:26:14 +02:00
Michael Lively
eaf321d50d
formatting
2022-07-20 16:12:32 -07:00
Michael Lively
63142212a1
remove md-it dependency, added undefined check to attachments
2022-07-20 16:10:54 -07:00
Michael Lively
ff31f6b577
Update package.json
2022-07-20 15:01:40 -07:00
Michael Lively
3a23dda32c
removed commented code
2022-07-20 13:47:26 -07:00
Michael Lively
d7b6596808
yarn.lock with yarnpkg instead of npm
2022-07-20 12:35:42 -07:00
Michael Lively
6a73a0d22d
rm package-lock.json
2022-07-20 12:25:57 -07:00
Michael Lively
1b59f566bb
rendering of attachment images complete via tokens
2022-07-20 12:23:37 -07:00
Michael Lively
735ead82f5
added attachment and metadata support back in... rebasing is scary
2022-07-20 12:23:37 -07:00
Michael Lively
3981a5804c
added build stuff
2022-07-20 12:23:37 -07:00
Michael Lively
0fa857c9a1
okay now things are actually fresh and working
2022-07-20 12:23:24 -07:00
Johannes
0656d21d11
auto-fixed prefer-const violation
2022-06-08 17:49:21 +02:00
Matt Bierner
45304da73d
Finalize NotebookEditor api proposal ( #149767 )
...
* Finalize NotebookEditor api proposal
Fixes #149271
This finalizes most parts of the NotebookEditor api proposal. I haven't removed the proposal entirely as there are still a few parts being left behind:
- The deprecated properties/functions
- A few contribution points such as `notebook/cell/executePrimary`
* remove extra quote
2022-05-23 23:27:17 +00:00
Matt Bierner
ff975bc211
Update list of enabled APIs ( #149838 )
...
We use `notebookWorkspaceEdit` even though it's not enforced
2022-05-18 10:39:40 -07:00
Matt Bierner
c9c5990e38
Adopt notebookWorkspaceEdit proposal internally ( #149778 )
...
This switches us to use the new `notebookWorkspaceEdit` proposal instead of `notebookEditorEdit`
2022-05-17 18:51:25 -07:00
Johannes
9530dca29d
finalize notebookDocumentEvents
-API, https://github.com/microsoft/vscode/issues/144662
2022-04-20 13:58:37 +02:00
Johannes
b1faab40de
adopt tests to new notebook change event
2022-03-29 11:58:54 +02:00
Joyce Er
31c338e5fa
Fix https://github.com/microsoft/vscode/issues/146022
2022-03-24 22:31:50 -07:00
rebornix
157cba093c
fix #140673 .
2022-03-15 17:01:33 -07:00
aamunger
3b9868b099
include 'create notebook' in the command pallette
2022-03-09 13:39:16 -08:00
rebornix
e632f91b35
fix #143966 .
2022-03-02 16:55:55 -08:00
rebornix
998ee04a72
update nbformat typings
2022-03-01 12:59:58 -08:00
Peng Lyu
67cca9b62d
Merge pull request #143422 from microsoft/rebornix/nb-json-codelens
...
Add codelens to ipynb json file to open in notebook editor
2022-02-22 13:18:39 -08:00
rebornix
3567a2f2bc
Show codelens to ipynb json to open in notebook editor
2022-02-18 14:54:40 -08:00
Martin Aeschlimann
db9e8fba63
remove unecessary files in build
2022-02-18 20:38:55 +01:00
rebornix
4b17d05668
re #142872 . Contribute ipynb notebook to File -> New when no Jupyter extension enabled.
2022-02-16 11:42:45 -08:00
rebornix
8e3c41760e
re #142872 . Default language to python.
2022-02-16 11:42:45 -08:00
rebornix
cca25256a3
remvoe jupyter(json)
2022-02-15 17:45:09 -08:00
rebornix
7f99539fe7
re #142872 . Ignore whitespace only content error.
2022-02-15 17:45:09 -08:00
Johannes Rieken
7ccb868835
make sure to use .eslintignore
when running yarn eslint
, this will ensure that cli failure and editor squiggles are always equal
2022-02-02 12:37:29 +01:00
Rob Lourens
e9ca473f62
Change jupyter language name
...
to make it more clear that it is for raw JSON, not a notebook
2021-11-17 11:42:42 -08:00
Johannes Rieken
09c9d4c293
use enabledApiProposals
instead of wildcard property, also update compilation units to only include d.ts-files that are needed, https://github.com/microsoft/vscode/issues/131165
2021-11-12 11:05:57 +01:00
Johannes Rieken
a4d426a1c2
split vscode.proposed.d.ts into a file per proposal, https://github.com/microsoft/vscode/issues/131165
2021-11-12 09:48:17 +01:00
Johannes Rieken
68e819043c
use tsconfig.json#include for vscode.d.ts and vscode.proposed.d.ts, enables to remove most ref.d.ts-files
2021-11-09 15:53:35 +01:00
Johannes Rieken
9254a8cd27
move vscode.d.ts and vscode.proposed.d.ts into src/vscode-dts
-folder, https://github.com/microsoft/vscode/issues/131165
2021-11-09 15:00:03 +01:00
Rob Lourens
3df135c388
Fix jupyter version number, #136544
2021-11-05 14:50:10 -07:00
Rob Lourens
29c5f2d394
Show an error when opening an old unsupported jupyter format
...
Fix #136544
2021-11-05 14:06:39 -07:00
Rob Lourens
a14ebdfec4
Remove inputCollapsed and outputCollapsed metadata, make them view properties
...
Fix #125274
2021-11-03 17:22:07 -07:00
Don Jayamanne
79a3586d6c
Add cell_ids for ipynb with nbformat >= 4.5 ( #134835 )
2021-10-12 09:35:05 -07:00
Don Jayamanne
fd910caaf2
Support nbformat 4.5
2021-09-24 13:16:03 -07:00
Don Jayamanne
217e74508d
add new line
2021-09-24 12:48:03 -07:00
Don Jayamanne
0bf3b221ca
Fix unnecessary changes
2021-09-24 12:45:03 -07:00
Don Jayamanne
3e10e0c49b
oops
2021-09-24 10:51:16 -07:00
Don Jayamanne
2f43876783
Ensure nb cell source uses LF instead of CRLF
2021-09-24 10:35:22 -07:00
Don Jayamanne
245fffbce1
Misc
2021-09-21 10:17:33 -07:00
Don Jayamanne
68ba13d07c
Remove window keyword from serializer
2021-09-20 09:49:00 -07:00
Don Jayamanne
192e689be1
Fixes to image serializations
2021-09-16 16:27:44 -07:00
Don Jayamanne
1eb4ff560b
Fixes to image serialization
2021-09-16 15:59:41 -07:00
Don Jayamanne
c962433c68
Remove old API
2021-09-07 13:04:03 -07:00
Don Jayamanne
55af133ac4
Udpates
2021-09-07 09:40:55 -07:00
David Anthoff
426d60625c
Add language_info to setKernelSpec
2021-09-03 14:17:27 -07:00
David Anthoff
4f7a2ddf75
Add setKernelSpecAndLanguageInfo to ipynb ext
2021-09-03 13:17:09 -07:00
Sandeep Somavarapu
961c2e353d
remove web extension kind in builtin extensions
2021-09-01 15:09:21 +02:00
Matt Bierner
b2bbd76e80
Fix writing kernelspec
...
For #130602
I think we need to write it into metadata section instead of the top level
2021-08-25 13:27:02 -07:00
Matt Bierner
d082058d44
Add API for setting kernelspec in ipynb files ( #131219 )
...
* Add API for setting kernelspec in ipynb files
Fixes #130602
This adds a new API to the built-in ipynb extension that lets other extension set the kernelspec metadata on a notebook file
* Temporarily skip the notebook editor tests
We need the new webview content to be published before these can run
* Use `custom` instead of top level property
2021-08-24 18:06:53 -07:00
Don Jayamanne
7bbd66c2d2
Fixes with tests
2021-08-24 17:17:48 -07:00
Don Jayamanne
31abc3784e
Revert "Merge pull request #131592 from DonJayamanne/revertPerfFixes2"
...
This reverts commit 52baabff07
, reversing
changes made to 6e930fb6d4
.
2021-08-24 17:16:44 -07:00
Don Jayamanne
c397afa3bd
Revert "Merge pull request #131035 from DonJayamanne/issue129370"
...
This reverts commit b23486ef7a
, reversing
changes made to 9e0732389b
.
2021-08-24 16:27:10 -07:00
Don Jayamanne
23cfb0b997
Fixes
2021-08-19 12:23:01 -07:00
Don Jayamanne
6cbf300b65
Fixes
2021-08-19 12:22:08 -07:00
Don Jayamanne
9347bc5c24
More perf fixes after review
2021-08-19 12:20:39 -07:00
Don Jayamanne
09f68d545d
Optimize indentation detection
2021-08-17 14:51:53 -07:00
Don Jayamanne
0882f1e571
Perf improvements to the ipynb serializer
2021-08-17 12:52:59 -07:00
Rob Lourens
accf5ae359
Add Jupyter language with JSON syntax highlighting
...
#128495
2021-08-06 15:51:29 -07:00
Rob Lourens
1dae051c56
Change exportNotebook API to return string
2021-08-05 17:14:47 -07:00
Rob Lourens
2a933e4505
Add ipynb extension API to invoke the serializer.
...
So the jupyter extension can implement custom Export functionality, and can dump an unsaved notebook
#128495
2021-08-05 12:14:08 -07:00
Rob Lourens
190a89dd1b
Port unit tests from vscode-jupyter to ipynb extension
...
#129446
2021-08-03 11:19:22 -07:00
Rob Lourens
9539f015b1
Split up ipynb serializer file
2021-08-02 19:16:20 -07:00
Rob Lourens
7caab9b3bc
Serializer cleanup
2021-08-02 18:58:07 -07:00
Don Jayamanne
e8192ca6e3
Temp: swtich image rendering pref from svg to png
2021-07-29 11:44:08 -07:00
Rob Lourens
282dd872e2
Fix #129502 .
...
Builtin extensions are stricter and require "web" set for web extensions
2021-07-27 16:00:09 -07:00
Joyce Er
adf904df67
ipynb: fix readme
2021-07-27 13:54:19 -07:00
Rob Lourens
26625e8fb3
Fix incorrect buffer slices
2021-07-26 11:39:49 -07:00
Don Jayamanne
754b1defb0
Fix save error
2021-07-23 17:10:22 -07:00
Don Jayamanne
7f43ac34a1
re-use text encoder
2021-07-23 17:10:22 -07:00
Don Jayamanne
739cc8974f
Fix ipynb serializer
2021-07-23 17:10:20 -07:00
Joyce Er
4e5d793a78
ipynb extension need not handle NotebookDocument
and NotebookCell
...
Co-authored-by: rebornix <penn.lv@gmail.com>
2021-07-23 17:07:17 -07:00
Peng Lyu
4148736349
Migrate webview notebook editor backup to builtin serializer ( #129211 )
...
* Migrate webview notebook editor backup to builtin serializer
* update extension kind.
* discard webview backup once it is opened in notebook editor.
2021-07-23 16:25:37 -07:00
Rob Lourens
437f5b7559
ipynb: Prefer "workspace" to"ui"
...
and "web" is inferred from the browser entrypoint
2021-07-23 09:16:09 -07:00
Rob Lourens
2bc4f8f94b
Simplify TextDecoder call
2021-07-21 15:18:04 -07:00
Rob Lourens
35cc9582a4
Fix serializer buffer slice
2021-07-21 15:03:41 -07:00
Rob Lourens
6ed3b6cc0e
Clean up ipynb serializer
2021-07-21 15:03:37 -07:00
Rob Lourens
5793ae026a
Rename serializer extension and set up build scripts
2021-07-21 15:03:24 -07:00