Commit graph

49426 commits

Author SHA1 Message Date
Alex Dima ee618f47b5 Add IProductService.uiExtensions 2019-05-24 12:46:49 +02:00
Alex Dima f90265bc4e Reduce usage of package.json and product.json 2019-05-24 12:46:49 +02:00
Alex Dima 14c4e038ad Move remoteExtensionHostClient to /common/ 2019-05-24 12:46:49 +02:00
Alex Dima a55dbfe5ab Avoid using ipc in the extension host clients 2019-05-24 12:46:48 +02:00
Alex Dima 2a74e67041 Reduce usage of product.json and package.json 2019-05-24 12:46:48 +02:00
Alex Dima 2cc98f3aa9 Load uri transformer via common js 2019-05-24 12:46:48 +02:00
Alex Dima adee318d61 Introduce a raw uri transformer 2019-05-24 12:46:48 +02:00
Alex Dima 9fb9ca51a6 Add transformOutgoingScheme to IURITransformer 2019-05-24 12:46:48 +02:00
Benjamin Pasero 2006bdb942 debt - use progressservice2 in more places 2019-05-24 12:45:40 +02:00
Joao Moreno 3fabf39a5b Merge branch 'pr/62021' 2019-05-24 12:42:27 +02:00
Joao Moreno dfec8582d2 Merge commit 'refs/pull/62021/head' of github.com:Microsoft/vscode into pr/62021 2019-05-24 12:42:12 +02:00
isidor e4f060db20 fixes #73685 2019-05-24 12:26:21 +02:00
Joao Moreno c0004e9544 update distro 2019-05-24 12:16:00 +02:00
isidor 74b9543c75 fixes #72894 2019-05-24 12:15:13 +02:00
Sandeep Somavarapu fa304701bd Fix #73309 2019-05-24 12:11:54 +02:00
Sandeep Somavarapu 3d50031afe fix #73183 2019-05-24 11:59:47 +02:00
isidor 5e191fcfe9 fixes #72902 2019-05-24 11:58:12 +02:00
Sandeep Somavarapu f2d4b6243b Fix #74270 2019-05-24 11:55:33 +02:00
Isidor Nikolic faa8a49c16
Merge pull request #71458 from iansan5653/themed-debug-colors
Use active theme colors for styled text in the debug console
2019-05-24 11:48:57 +02:00
Johannes Rieken 74c297989e add test for #73850 (using default ranges) 2019-05-24 11:47:50 +02:00
Sandeep Somavarapu 1e7b2b1faf fix #72585 2019-05-24 11:44:44 +02:00
Johannes Rieken 323f92dfd5
Merge pull request #73850 from andrewbranch/bug/smart-select-line-range
Smart select: only add line ranges if they’re contained by the next range
2019-05-24 11:08:33 +02:00
Andre Weinand e480cea725 address translation issue; fixes #72065 2019-05-24 10:41:41 +02:00
isidor 11132726df fixes #73845 2019-05-24 10:40:04 +02:00
Johannes Rieken be897248a8 don't overwrite revealIfOpen-setting, fixes #74072 2019-05-24 10:34:21 +02:00
isidor bdd04b1e1e fixes #73633 2019-05-24 10:27:51 +02:00
Sandeep Somavarapu ec4b62e975
define extension kind in package.json schema (#73024)
define extension kind in package.json schema
2019-05-24 10:11:43 +02:00
Johannes Rieken 214707c1fc enable breadcrumbs by default, fixes #74048 2019-05-24 10:10:40 +02:00
Johannes Rieken f27d4ab760 support highlights for both - file names, and source matches, #52743 2019-05-24 10:02:20 +02:00
isidor 6bf5a93238 compoiste: do not show progress for show, since show is now sync 2019-05-24 09:38:32 +02:00
Isidor Nikolic 91d17baf10
Merge pull request #73954 from jeanp413/debughover-preserve-whitespace
Preserve whitespace in debug hover expresion value
2019-05-24 09:35:32 +02:00
Benjamin Pasero 211fdbc9bc debt - more async/await adoption 2019-05-24 08:13:24 +02:00
Matt Bierner 0f32f0ef5f Clean up some usages of IDisposable[]
Part of #74250

- Extend `Disposable` in classes where it makes sense
- Use `DisposableStore` for lists of disposables
- Make `combinedDisposable` take arguments instead of an array (so that you can't pass in an array and then modify the array after the fact)
2019-05-23 22:58:16 -07:00
Matt Bierner 5e1f9440d2 Fix compile errors related to toDispose refactoring
Not sure why incremental builds missed this
2019-05-23 19:35:15 -07:00
Matt Bierner 3d5ce6be5e Introduce DisposableStore
Fixes #74242

Our current usage of dispoable arrays can leak disposables (see #74242 for details). This change introduces a new class called `DisposableStore` that can be used mostly as a drop in replacement for an array of disposables but will not leak disposbles if it is disposed

`DisposableStore` was extracted from the existing `Dispoable` class, which already implements this pattern. However `Disposable` is intended to be used as a base class while `DispoableStore` is a value class.

In addition, this change hides the `toDispose` / `_toDipose` members of `Disposable` as direct write access to the disposable array also allows for leaks (and breaks encapsulation)
2019-05-23 19:25:16 -07:00
Matt Bierner ae8da480f0 Use fileService and Blob for resource viewer
Fixes #74191

Instead of using a base64 encoded data uri to display images, use the fileService to read Buffer, convert this to a Blob, and display the blob
2019-05-23 18:32:02 -07:00
Matt Bierner f3b8d15b0d Add DocumentLink.tooltip api proposal
For #72824
2019-05-23 17:57:04 -07:00
Bowden Kelly 5b9869eb02
Merge pull request #74167 from microsoft/wilkelly/pom
Add rnpm-plugin-windows and pom.xml check
2019-05-23 17:01:21 -07:00
Peng Lyu 346da6b01a dispose empty comment thread when collapse. 2019-05-23 16:37:42 -07:00
Matt Bierner a9e31b19d7 Make sure we don't de-prioritize this. member suggestions
Fixes #74164
2019-05-23 16:06:34 -07:00
Matt Bierner a4532de9af Make sure we reset editors being iterations of test 2019-05-23 16:06:34 -07:00
Peng Lyu fa69b4e7d6 Show context for diff view of merge conflict and introduce compareAll. 2019-05-23 14:19:09 -07:00
Daniel Imms 3bcb1fa9d8 Remove comments, polish jsdoc 2019-05-23 12:47:58 -07:00
Daniel Imms b3ab7bd13e Disallow runInBackground unless proposed is enabled 2019-05-23 12:42:22 -07:00
Daniel Imms 1f6bf9b92c Add some runInBackground terminal tests 2019-05-23 12:38:25 -07:00
Daniel Imms 9b3544000e Merge remote-tracking branch 'origin/master' into tyriar/72518_runInBackground 2019-05-23 12:08:42 -07:00
Daniel Imms 87b18670bf Get onData listener working 2019-05-23 12:07:52 -07:00
Johannes Rieken 499a38b1ec make sure to dispose CancellationToken so that it doesn't steal ESC 2019-05-23 21:04:13 +02:00
Johannes Rieken b6476d6c09 bring back anyScore but make it more strict (== easer to understand), #74203 2019-05-23 20:36:31 +02:00
Johannes Rieken 741d30409d show statusbar message, cancel on ESC, active code editor must be on symbol 2019-05-23 20:20:01 +02:00