Johannes
a3d8c33761
Revert "Clean up how the notebook renderer entrypoint is passed around ( #163373 )"
...
This reverts commit 8b0248854ahttps://github.com/microsoft/vscode/issues/163415
2022-10-12 11:25:02 +02:00
Ladislau Szomoru
8c946e23f4
Git - Fix typo in setting description ( #163400 )
...
Fix typo in setting description
2022-10-12 09:12:39 +02:00
Alexandru Dima
72a982d0d3
Fix typo in regex ( #163404 )
2022-10-12 00:08:09 -07:00
Tyler James Leonhardt
3e4e351816
Enforce ILocalizedString usage with f1 property via types ( #162991 )
...
* Enforce ILocalizedString usage with f1 property via types
* complete comment
* Visit all symbols when encountering a union type
* use ILocalizedString
* fix tests
Co-authored-by: Alex Dima <alexdima@microsoft.com>
2022-10-11 21:24:43 -07:00
Jean Pierre
24b8eb0d54
Fixes simple browser webview is not reused if restored ( #163389 )
...
Fixes #163387
2022-10-11 20:59:54 -07:00
Rob Lourens
cf47b76c63
Finalize notebookDebugOptions API ( #163316 )
...
* Finalize notebookDebugOptions API
Fix #147264
* Backcompat for the option from vscode-jupyter
* Undo comment
* Fix build
2022-10-11 20:25:51 -07:00
Matt Bierner
fdb8812822
Always mark notebook list rendering elementDisposables as disposed ( #163382 )
...
Mark notebook list rendering elementDisposables as disposed
This updates `disposeTemplate` for notebook list rendering to mark the `elementDisposables` as disposed instead of simply clearing them. This is helpful if you are using `TRACK_DISPOSABLES`, and will also log if you try adding to the disposable after it has been disposed of
Also marks more template fields as readonly
2022-10-11 19:31:41 -07:00
Matt Bierner
8b0248854a
Clean up how the notebook renderer entrypoint is passed around ( #163373 )
...
This internally makes entrypoint into a single property instead of splitting it across `entrypoint` and `extends`
Also removes unused properties from `INotebookRendererInfo`
2022-10-11 19:03:42 -07:00
Rob Lourens
bad5e65a09
Don't log this error ( #163384 )
...
I think it's expected that sometimes the resource from the debug session will outlive the session itself
Fix #163270
2022-10-11 18:21:42 -07:00
Matt Bierner
e1a373defd
Finalize markdown link updating on file move ( #163378 )
...
Fixes #148146
2022-10-11 17:42:10 -07:00
Matt Bierner
6cf68a1f23
Remove .only and fix tests ( #163376 )
...
Fixes #162159
2022-10-11 17:41:13 -07:00
Rob Lourens
28891790e9
Send breakpoint init requests in parallel ( #163250 )
...
* Send breakpoint init requests in parallel
Fix #163248
* Keep serial breakpoint init style when the DA does not support the configurationDone request
* Extract complex setBreakpoints expression
2022-10-11 17:27:39 -07:00
Matt Bierner
1bda1e241c
Pick up latest TS for building VS Code ( #163375 )
2022-10-11 17:13:00 -07:00
Ian Huff
6d96eb0dfb
update distro to allow Jupyter access to notebookControllerAffinityHidden ( #163369 )
...
Co-authored-by: Ian Huff <ianhuff@Ians-MacBook-Pro.local>
2022-10-11 16:27:24 -07:00
Matt Bierner
fa6b137214
Inline factory methods ( #163363 )
2022-10-11 16:15:28 -07:00
Matt Bierner
d05d85a78b
Move html rewriting for old webviews to ( #163367 )
...
The `asWebviewUri` methods was introduced in VS Code 1.38. It's silly that we still force every single webview to pay the cost of trying to rewrite the old style uris we supported in very old versions of VS Code
Instead I've moved this logic into the extension host and disabled it for all extensions that target VS Code 1.60+ or newer. This means it never applies to internal webviews, notebooks, webview views, or custom editors (these public apis were all introduced after the switch to `asWebviewUri`)
2022-10-11 16:08:17 -07:00
Matt Bierner
0abb1e99c2
Align switch case style in service worker ( #163364 )
2022-10-11 16:06:58 -07:00
Matt Bierner
cc8feda380
Use Object.entries for updating styles in webview ( #163359 )
...
Use Object.entries for updating styles
2022-10-11 16:05:08 -07:00
Matt Bierner
d9166909b6
Small clean up to mainthread and exthost custom editor code ( #163350 )
...
- Align property names
- Move private method to function
- Formatting
2022-10-12 00:36:48 +02:00
Matt Bierner
84e5fd623d
Remove unused method ( #163361 )
2022-10-11 15:12:05 -07:00
Rob Lourens
baa2dedb94
Make notebook singletons lazy ( #162758 )
...
* Address #159178 for notebooks
* Add method to list editor decorations so they can be initialized in the lazy instantiated NotebookService
2022-10-11 15:02:17 -07:00
Don Jayamanne
43957ccfe1
Compress streams in notebook outputs ( #160946 )
...
* Revert "Compress notebook output streams before rendering (#160667 )"
This reverts commit 4230c22a08
2022-10-11 14:43:46 -07:00
Tyler James Leonhardt
4322170fd8
comment is an array ( #163348 )
2022-10-11 13:39:12 -07:00
Rob Lourens
f5047cb4f0
Fix build ( #163347 )
2022-10-11 21:55:49 +02:00
Logan Ramos
e814cb5c65
Telemetry API ( #160902 )
...
* First run of scaffolding out a telemetry API
* Make telemetry config up to date
* Further work on telemetry API
* Implement telemetry logging extension host
* Add logging to exthost logger
* Extract telemetry cleaning
* Add data cleaning
* Update email regex
2022-10-11 15:44:18 -04:00
Tyler James Leonhardt
53785ee45d
Finalize localization API ( #163344 )
2022-10-11 12:39:39 -07:00
Sandeep Somavarapu
864b8b2b6c
Fix #163005 ( #163339 )
2022-10-11 12:03:05 -07:00
Matt Bierner
34b0554228
Use map instead of objects for storing contributions and actions ( #163342 )
...
This fixes a typing error where `getAction` could return null, but our types weren't catching this
2022-10-11 11:58:12 -07:00
Matt Bierner
f27886d7d4
Document webview view service ( #163341 )
2022-10-11 11:57:58 -07:00
Rob Lourens
3305ea470a
Start optimizing DebugService creation ( #162879 )
...
* Debug editor contribs should not force DebugService to be created immediately
Fix #159886
* Do slow registration of debug fs provider later
* Small optimization to context keys in DebugService
2022-10-11 11:54:16 -07:00
Matt Bierner
fad9089781
Normalize resources when checking valid roots ( #163327 )
...
Fix MSCR 74267
Fix https://github.com/microsoft/vscode-internalbacklog/issues/3140
Remove extra indexOf check
This could cause failures for files such as `img..png`
2022-10-11 11:00:31 -07:00
Joyce Er
7666d7acd4
Avoid * activating ipynb extension ( #163325 )
2022-10-11 10:53:07 -07:00
Peng Lyu
f1b301bb77
Merge pull request #163052 from r3m0t/notebook-tab-move-fix-134158
...
Fix 'join all editor groups' for notebooks Fixes #134158
2022-10-11 10:45:45 -07:00
Matt Bierner
d2cff714d5
Add allow list of valid notebook command uris ( #163322 )
...
This restricts notebooks to run three command uris. These 3 commands should all be safe to run, even with untrusted inputs
2022-10-11 10:42:05 -07:00
Sandeep Somavarapu
eaec601dd6
Merge pull request #162844 from laurentlb/comment_css
...
Update column names in 'Feature Contributions'
2022-10-11 19:27:20 +02:00
Matt Bierner
01de02ba72
Also make getEditorActions return an iterable instead of an array ( #163320 )
...
This lets us avoid an extra `.slice(0)` when returning the actions
2022-10-11 10:22:38 -07:00
Sandeep Somavarapu
dace01386e
fix #163317 ( #163319 )
2022-10-11 10:18:14 -07:00
SteVen Batten
9cc932ee6b
update custom menubar to show toggle title info ( #163315 )
2022-10-11 10:12:08 -07:00
Andrea Mah
661382f5e4
fix memory leak and switch to use disposableStore ( #163022 )
...
fix memory leak at switch to use disposableStore
2022-10-11 09:55:41 -07:00
Matt Bierner
90054ae22f
Make returned editor contributions an iterable instead of an array ( #163309 )
...
This lets us avoid having to call `.slice(0)` for the contributions
2022-10-11 18:35:32 +02:00
Andrea Mah
63351a794f
Search Focus Cleanup ( #162903 )
...
* aligned replace and remove in search focus
* always refocus replace
2022-10-11 09:18:53 -07:00
Johannes Rieken
89f8e8b4de
pause/resume suggest widget events when doing splice and select/focus ( #163307 )
...
fixes https://github.com/microsoft/vscode/issues/163284
2022-10-11 08:52:57 -07:00
Henning Dieterichs
391a6825bd
Fixes #161993 ( #163303 )
2022-10-11 17:42:03 +02:00
Connor Peet
b42f25b50b
address pr comments
2022-10-11 08:30:43 -07:00
Alexandru Dima
4b48c2dac2
Add support for transparency in editorOverviewRuler.background ( #163302 )
...
Fixes #159843 : Add support for transparency in `editorOverviewRuler.background`
2022-10-11 08:06:54 -07:00
Henning Dieterichs
597d485d3f
Exclude code lens contributions from result merge editor ( #163301 )
2022-10-11 08:05:02 -07:00
Henning Dieterichs
f232fdac98
Fixes #162111 ( #163300 )
2022-10-11 08:00:17 -07:00
Sandeep Somavarapu
adefb9aae2
change the default log format ( #163268 )
...
* change the default log format
* also change in file log
* fix compilation
2022-10-11 07:30:41 -07:00
Alexandru Dima
2149a31611
Toggle word wrap state (if defined) also on the other side when opening a diff editor ( #163297 )
...
Fixes #161412 : Toggle word wrap state (if defined) also on the other side when opening a diff editor
2022-10-11 07:25:07 -07:00
Alexandru Dima
9b0ae4dd79
Push an undo stop before committing an inline suggestion ( #163296 )
2022-10-11 06:52:33 -07:00
