Logan Ramos
4acf2d9b46
Update the telemetry modules ( #170512 )
...
Update the module
2023-01-03 15:10:45 -05:00
Matt Bierner
c390a331c5
Switch to standard imports ( #169451 )
2022-12-17 00:22:53 +01:00
Tyler James Leonhardt
461b3f6184
Only have a single window store the session ( #169356 )
...
Before this change, every single window was writing to the same secret at basically the same time because they would all refresh the token and then attempt to store that refresh token.
I believe this was causing a few race condition bugs that users were seeing.
With this change we now so our best to have only 1 window store the session by relying on the window focused state.
If the window is focused or becomes focused, we will store the refresh token.
If the window detects that another window has stored something, we will not attempt to wait for focus to store something.
If nothing has happened, and it's been 5 hrs (+/- some seconds) go ahead and store it. This is the scenario of when a user has VS Code in the background for like ages but never goes to it.
ref #165115
ref #130893
ref #168485
2022-12-16 06:58:32 +01:00
Logan Ramos
b1076b41f3
Bump telemetry packages ( #169283 )
2022-12-15 17:29:10 +01:00
Joyce Er
3bdea7784d
authentication implicit activation events (#166715 )
...
* `authentication` implicit activation events
* More safety accessing `.id`
2022-11-19 08:30:48 -08:00
Logan Ramos
73d882bcf7
Update telemetry package ( #166292 )
2022-11-14 09:30:33 -08:00
Tyler James Leonhardt
ef415578d1
Take advantage of platform features in Microsoft Authentication extension ( #166066 )
2022-11-10 18:26:48 -08:00
Sandeep Somavarapu
2cd8ea24f2
#159892 Finalize ( #165925 )
2022-11-09 10:28:27 -05:00
Logan Ramos
bf1697d98c
Consume proposed telemetry API ( #165862 )
...
* Consume proposed telemetry API
* Update webpack
2022-11-08 21:58:28 -05:00
Tyler James Leonhardt
6684350a58
Onboard GitHub & Microsoft auth extensions to l10n ( #163662 )
...
* onboard github-auth completely to l10n
* onboard microsoft-authentication entirely on to l10n
2022-10-14 08:41:21 -07:00
Tyler James Leonhardt
29e985eca0
rev vscode-nls to version that doesn't ask for vscode-nls-web-data ( #161819 )
...
ref #161297
2022-09-26 11:10:54 -07:00
Sandeep Somavarapu
35c7ee9d02
Support log output channels for extensions ( #161249 )
...
* introduce log api in extension context
* separate registering output vs log channel
* Separate extension log channels in show logs command
* add logging error to embedder logger
* show extension log in the extension editor
* configure log level per extension
* change the order of log entries
* introduce logger
* align with output chanel
* revert changes
* fixes
2022-09-19 09:03:41 -07:00
Tyler James Leonhardt
dc9336c303
make sure we add offline_access when creating sessions ( #159116 )
2022-08-25 08:48:01 -04:00
ChaseKnowlden
19d0675506
Add offline_access to list of default scopes ( #157453 )
...
Add a new scope to default scopes
2022-08-08 14:55:13 -07:00
Tyler James Leonhardt
d8453c0440
Rev built-in versions of vscode-nls to 5.1.0 ( #157530 )
...
* rev version of vscode-nls to 5.1.0
* and yarn lock
2022-08-08 18:43:45 +02:00
Tyler James Leonhardt
d859b334cb
We only need to wait on the input box for un-supported environments ( #157157 )
...
we only need to wait on the input box for un-supported environments
2022-08-04 23:55:51 +02:00
Tyler James Leonhardt
4017fd126f
Show quick pick when redirect fails to complete redirect to be more robust ( #156515 )
...
* show quick pick when redirect fails to complete redirect to be more robust
* matt feedback
2022-07-28 10:26:18 -07:00
Logan Ramos
a20329d291
Switch extensions to 1DS ( #154299 )
...
* Move extensions to 1DS
* Switch extensions to 1DS
2022-07-06 17:18:41 -07:00
Logan Ramos
4a7a6a597a
Update extension telemetry modules ( #153057 )
2022-06-24 00:53:23 +00:00
Johannes
0656d21d11
auto-fixed prefer-const violation
2022-06-08 17:49:21 +02:00
Tyler James Leonhardt
847629239b
add owner and comment to some telemetry events ( #148752 )
2022-05-05 17:30:51 -04:00
Tyler Leonhardt
e2ec6f0a54
more accurate naming of pages
2022-04-27 15:40:41 -07:00
Tyler Leonhardt
9c15f4185a
add favicon and nonce enforcement in microsoft auth
2022-04-15 15:47:20 -07:00
Tyler Leonhardt
52a394bdea
Introduce removeSessionByIToken to remove sessions that aren't in this._tokens yet. Fixes #145189
2022-04-14 15:21:54 -07:00
Tyler Leonhardt
5919378269
don't surface error on gets and remove microsoft secret migration. Fixes #146553
2022-04-14 12:18:33 -07:00
Tyler Leonhardt
39c6779828
depend on stable vscode.dev for auth extensions
2022-03-21 09:35:34 -07:00
Tyler Leonhardt
f728c9289e
use global URLSearchParams
2022-03-18 14:52:18 -07:00
Logan Ramos
9b7268acf9
Update telemetry module
2022-03-18 11:34:33 -04:00
Tyler James Leonhardt
00888f774d
depend on redirect route within Microsoft auth ( #145263 )
...
* depend on redirect service
* better server query parameter handling
2022-03-16 13:41:44 -07:00
Robo
32d40cf44e
chore: update to electron 17 ( #143223 )
...
* chore: bump electron@17.0.0
* Revert "chore: revert to electron@13 (#143851 )"
This reverts commit df645f1450c3e948aa30
2022-03-11 00:51:37 +09:00
Tyler Leonhardt
739dfea8e6
try to use an existing refresh token to get a token with the specified scopes. Fixes #114003
2022-03-03 14:54:48 -08:00
Robo
df645f1450
chore: revert to electron@13 ( #143851 )
...
* Revert "chore: update to electron 16 (#137241 )"
This reverts commit 01df559c1846301339b7
2022-02-24 17:49:49 +01:00
Tyler Leonhardt
a0da9978b1
include profile for specific claims in idtoken. Fixes #143463
2022-02-20 16:58:07 -08:00
Tyler Leonhardt
ae8bacb9d3
ensure getSessions also asks for email and openid scopes and fix #142776
2022-02-17 10:27:36 -08:00
Tyler Leonhardt
6a01cda605
use 127.0.0.1 instead of localhost
2022-02-08 15:39:34 -08:00
Yash Goel
5ea92ff535
fixed settings sync has duplicate logins ( #142340 )
...
* added check and swaped logic
* improved label for usename
* fixed eslint issues
* updated text
2022-02-08 12:14:52 -08:00
Robo
01df559c18
chore: update to electron 16 ( #137241 )
...
* chore: bump electron@15.3.0
* chore: bump node@16.x
* chore: enable render process reuse
* Revert "watcher - use `type` property for crash reporter location"
This reverts commit bfa488dd8f#136264 )"
This reverts commit af261488f8💄 changes
* align with changes
* adopt more fs.rm
* 💄
* chore: bump @vscode/sqlite3@5.0.4
* fix layers check to account for duplicated types from node.js
* update todo for type casts
* smoke - fix compile issue
* chore: update module cache
* watcher - fix unhandled rejection (fix #137416 )
* ci: update node version
* enable stack dumping
* update electron types to 16.x
* chore: bump @vscode/sqlite3@5.0.5
Refs https://github.com/microsoft/vscode/issues/137496
* fix layer issue
* add `AbortSignal` to core types
* chore: update linux compile flags
Refs 797723ec83https://github.com/microsoft/vscode/issues/137659
* ci: switch to buster for linux arm
Refs https://github.com/microsoft/vscode/issues/137927
* ci: fix build on linux arm64
* ci: fix arm client compiler toolchain
Refs #137927
* chore: bump electron@16.0.3
* ci: fix compile flags for the c toolchain
* chore: bump electron@16.0.4
* Add experimental dark mode flag (#139109 )
* Add experimental dark mode flag
* Apply PR feedback
* chore: bump electron@16.0.6
* chore: bump electron@16.0.7
Fixes https://github.com/microsoft/vscode/issues/138792
Fixes https://github.com/microsoft/vscode/issues/139300
* chore: experimental highlight API
* smoke - fix compile issue
* FIXME: custom ELECTRON_RUN_AS_NODE with node worker
* Revert "chore: bump electron@16.0.7"
This reverts commit 5fd01cf37ca7f1b73951https://github.com/microsoft/vscode/issues/137927
* ci: force build
* chore: update yarn.lock
* address feedback
* Revert "FIXME: custom ELECTRON_RUN_AS_NODE with node worker"
This reverts commit 7b48fa3732🆙 `versionSpec`
Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
Co-authored-by: Raymond Zhao <raymondzhao@microsoft.com>
2022-02-08 20:09:00 +01:00
Tyler Leonhardt
e485dc292f
improve logic around auth server
2022-02-06 14:56:22 -08:00
Tyler Leonhardt
eb295e4195
enable migration parts
2022-02-03 14:50:48 -08:00
Johannes Rieken
4a130c40ed
enable @typescript-eslint/member-delimiter-style, https://github.com/microsoft/vscode/issues/140391
2022-02-02 14:35:33 +01:00
Tyler Leonhardt
f498b374c0
large refactor including new secret storage wrapper and overall code clean up and organization
2022-02-01 18:14:31 -08:00
dependabot[bot]
dbf955b07a
Bump node-fetch in /extensions/microsoft-authentication ( #141536 )
...
Bumps [node-fetch](https://github.com/node-fetch/node-fetch ) from 2.6.1 to 2.6.7.
- [Release notes](https://github.com/node-fetch/node-fetch/releases )
- [Commits](https://github.com/node-fetch/node-fetch/compare/v2.6.1...v2.6.7 )
---
updated-dependencies:
- dependency-name: node-fetch
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2022-01-26 10:16:24 -08:00
Tyler Leonhardt
9403de257a
proposed api for an idToken on AuthenticationSession. ref #140929
2022-01-24 20:02:31 -08:00
Logan Ramos
c047af40b2
Fix compilation
2022-01-19 16:18:14 -05:00
Logan Ramos
b22ee20028
Move to @vscode/extension-telemetry
2022-01-19 15:57:17 -05:00
Tyler Leonhardt
12902bc7a1
allow overridding of client id and tenant for microsoft auth
2022-01-14 14:36:34 -08:00
Logan Ramos
932ab8e485
Update vscode extension telemetry modules
2021-12-28 11:06:48 -05:00
Matt Bierner
e7b3724e0c
Enable no-case-declarations in codebase ( #139243 )
...
Fixes #139236
This can catch tricky programming mistakes that cause a runtime error. See 7e266b2c42
2021-12-15 17:15:35 -08:00
Tyler Leonhardt
53e8f2c26e
handle 4XX errors differently from others
2021-11-22 16:20:47 -08:00
Tyler Leonhardt
33a6ac6639
simplify polling when getting a network error
2021-11-22 15:28:13 -08:00
