Commit graph

77473 commits

Author SHA1 Message Date
Benjamin Pasero 97dfc57ffd tests - a lot more detailed getUntitledWorkspaceSync test (#116288) 2021-02-19 10:36:34 +01:00
isidor c9cbeda067 actionBar: allow to go over disabled items
fixes #116722
2021-02-19 10:24:18 +01:00
Benjamin Pasero 6186bfc78f files - make save error actions context aware (#115840) 2021-02-19 09:39:45 +01:00
Sandeep Somavarapu d8b1c8d697
Merge pull request #116964 from microsoft/sandy081/fix116722
Fix focussing actions in extension view
2021-02-19 09:35:35 +01:00
Johannes Rieken f1de1700dd editable changes in notebooks 2021-02-19 09:00:58 +01:00
Jean Pierre d151e0a33c
Fix #116199 (#116268) 2021-02-19 09:00:12 +01:00
Eric Amodio d53a27d7c2 Fixes rendering issue in Firefox 2021-02-19 01:16:23 -05:00
Don Jayamanne 73ccfc027c Oops 2021-02-18 20:36:06 -08:00
Matt Bierner 192c817fd3 Make jsdoc completions text kind instead of snippet kind
Fixes #116941

Snippet completions can be disabled by `editor.snippetSuggestions`. It likely isn't expected that this setting could disable JSDoc completions too
2021-02-18 19:34:12 -08:00
Habib Karim 9f08368e92
Handle normalized absolute file paths on markdown preview link click (#116649)
* Handle normalized absolute file paths on markdown preview link click #115812

* Parse file path using vscode.Uri
2021-02-18 19:07:22 -08:00
Matt Bierner 094777f392
Fix alt for menus inside of webviews (#116830)
Fixes #104329

This fixes two things:

- Keyup events from webviews were not dispatched back to the main window. We usually listen on keydown but the menubar listeners needs both keydown and keyup

- Instead of listening on document.body for keypress events, we need to listen on window
2021-02-18 19:05:47 -08:00
Jackson Kearl 096e5555b6 Allow welcome page to not be active on account of focus potentially going to a getting started item. 2021-02-18 18:57:24 -08:00
Megan Rogge ba05eeda2e log something in ptyService 2021-02-18 18:54:47 -08:00
Connor Peet c3695af6d2
testing: fix unit test 2021-02-18 18:07:03 -08:00
Megan Rogge a172be74ef use persistentTerminalId instead of pid 2021-02-18 17:53:19 -08:00
Connor Peet 5a0bf3751a
testing: add method to publish extension-provided results 2021-02-18 17:33:24 -08:00
Rachel Macfarlane 52ebf0c7f8 Add 'deny' option to account access prompt 2021-02-18 17:05:58 -08:00
Jackson Kearl ca02f19daf Fix #115314 2021-02-18 16:57:40 -08:00
rebornix 482013c77e set minHeight on outputs when rerendering outputs to avoid shrinking. 2021-02-18 16:55:09 -08:00
Jackson Kearl 8f2e85abd6 Fix #116574: Make it easier to jump from one Getting Started section to the next 2021-02-18 16:07:39 -08:00
Megan Rogge 1d3343a109 remove stuff from process in platform 2021-02-18 15:49:02 -08:00
Matt Bierner 8806d063fe Enable extensible markdown notebook rendering in VS Code workspace 2021-02-18 15:37:00 -08:00
Matt Bierner 25c0fb7f2f Fix _getViewIndexUpperBound throwing if the view model is undefined
Return -1 instead, which the callers check
2021-02-18 15:37:00 -08:00
Matt Bierner 03b6a2e6b7 Null out webview on dispose
Fixes #116955

Make sure we null out the webview when the notebook editor is disposed. Fixes a few places where we may hit a null webview in async cases
2021-02-18 15:37:00 -08:00
Rachel Macfarlane d131331195 Remove extra info from onDidChangeSessions event 2021-02-18 15:36:28 -08:00
Megan Rogge dd2bb8cd3a
Update src/vs/platform/terminal/electron-browser/localPtyService.ts
Co-authored-by: Daniel Imms <daimms@microsoft.com>
2021-02-18 15:29:59 -08:00
Connor Peet 45dc2f5fa0
testing: allow contributing menu items to test view
Fixes #116806
2021-02-18 15:29:00 -08:00
Megan Rogge 88f459a2ad return terminal launch error 2021-02-18 15:25:56 -08:00
Jackson Kearl 7aff64c42d Remove unused 2021-02-18 15:18:56 -08:00
Jackson Kearl 840f19af06 Contriburte extension items at top-level
Ref #116414
2021-02-18 15:18:17 -08:00
Megan Rogge 9c8e2ae7af move stuff back to workbench and remove log statements and use pid 2021-02-18 15:15:24 -08:00
Megan Rogge e95a5c1e1c
Update src/vs/platform/terminal/common/terminalDataBuffering.ts
Co-authored-by: Daniel Imms <daimms@microsoft.com>
2021-02-18 14:48:56 -08:00
rebornix 2d263be14f fix #115722. 2021-02-18 14:43:24 -08:00
Andre Weinand b882940dc6 align InlineValuesProvider with EvaluatableExpressionProvider 2021-02-18 23:13:22 +01:00
Miguel Solorio a90d4ab5cf Move notebook markdown cell margin to its own const, tweak margins 2021-02-18 13:39:39 -08:00
Megan Rogge 070a33c7d6
Update src/vs/platform/terminal/common/terminal.ts
Co-authored-by: Daniel Imms <daimms@microsoft.com>
2021-02-18 13:15:15 -08:00
Megan Rogge 8039b6416c
Update src/vs/workbench/contrib/terminal/browser/terminalInstanceService.ts
Co-authored-by: Daniel Imms <daimms@microsoft.com>
2021-02-18 13:14:46 -08:00
isidor 6fae7792bb untitled hint: polish 2021-02-18 21:52:09 +01:00
isidor 98c1cd2ca8 untiltedHint: introdcue button option, use it as an editor contribution
#114307
2021-02-18 21:42:42 +01:00
Megan Rogge 0eaf2bab81 enable flow control for local terminals 2021-02-18 12:08:55 -08:00
rebornix 9c77f4d86a add NotebookDocument.save(). 2021-02-18 11:57:49 -08:00
rebornix df04e1388d fix #115596. 2021-02-18 11:56:23 -08:00
rebornix f79a2119bd fix #115326. 2021-02-18 11:56:23 -08:00
rebornix 933ca3a395 fix #113381. 2021-02-18 11:56:23 -08:00
rebornix e8836805dc remove attachedEditors. 2021-02-18 11:56:18 -08:00
Connor Peet bcc49ca4b6
testing: fix comp error 2021-02-18 11:48:48 -08:00
Jackson Kearl f4ce983bcd Open first section if no items completed
Closes #116570
2021-02-18 11:24:31 -08:00
Jackson Kearl 657398dedf Back => More
Ref #116570
2021-02-18 11:24:31 -08:00
Megan Rogge 7130344e98 Merge branch 'main' into tyriar_megan_reconnect 2021-02-18 11:22:23 -08:00
Connor Peet 26b6f4d088
testing: fix show in active file not working when first turned on 2021-02-18 11:07:10 -08:00