Commit graph

38 commits

Author SHA1 Message Date
Benjamin Pasero f9b5584b73
aux window - reduce direct setInterval uses (#197741) 2023-11-08 16:09:30 +01:00
Benjamin Pasero 38db856f35
debt - use globalThis and remove deprecated globals (#197712)
* debt - use `globalThis` and remove deprecated `globals`

* fix build
2023-11-08 09:13:03 +01:00
Benjamin Pasero 3453c4f9f0
aux window - avoid/flag more globals (#197614)
* aux window - avoid/flag more globals

* fix access from worker

* allow `queueMicrotask`

* more adoptions

* fix build

* avoid $globalThis
2023-11-07 12:52:20 +01:00
Benjamin Pasero 912c2d98e3
aux window - ensure native host service is properly typed in all contexts (#197527) 2023-11-06 12:00:24 +01:00
Robo ea490e5545
chore: update to Electron 25 (#188268)
* chore: update electron@25.3.0

* ci: update NodeTool version

* chore: update @types/node

* add more common types to layers checker

* chore: update debian dependencies

* chore: update rpm dependencies

* fix: use legacy dns result order of Node.js

* ci: remove deprecated always-auth npm config

Refs npm/cli@72a7eeb

* chore: update deb and rpm dependencies

* chore: update armhf rpm dependencies

* chore: update x64 debian dependencies

* chore: update x64 rpm dependencies

* chore: update electron@25.3.1

* chore: update electron@25.4.0

* chore: bump distro

* chore: bump distro

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2023-08-07 21:46:27 +09:00
Robo e5f61433b5
chore: update to Electron 22 (#177600)
* Revert "chore: revert to Electron 19 (#175851)"

This reverts commit 3a11b47eee.

* chore: bump electron@22.3.3

* build: use custom version for V8 sandbox

* chore: update electron@22.4.1

* chore: enable forceAllocationsToV8Sandbox for extension host

* chore: bump electron@22.4.2

* chore: bump electron@22.4.3

* sandbox - cleanup from electron 22 update (#178919)

* Revert "chore: revert to Electron 19 (#175851)"

This reverts commit 3a11b47eee.

* chore: bump electron@22.3.3

* build: use custom version for V8 sandbox

* chore: update electron@22.4.1

* chore: enable forceAllocationsToV8Sandbox for extension host

* chore: bump electron@22.4.2

* chore: bump electron@22.4.3

* temp: update distro

* sandbox - cleanup from electron 22 update

* missing comile

* more changes

* fix build

* restore

* 💄

* compile

---------

Co-authored-by: deepak1556 <hop2deep@gmail.com>

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2023-04-03 09:09:31 +02:00
Robo 3a11b47eee
chore: revert to Electron 19 (#175851)
* Revert "Update to min supported version of node (#175723)"

This reverts commit f749e6be2d.

* Revert "chore: update min node version for development (#175663)"

This reverts commit f2a822fbe9.

* Revert "electron 22 sandbox - enable for OSS (#175659)"

This reverts commit 2551af21f8.

* Revert "chore: update to Electron 22 (#166430)"

This reverts commit 6e85d2b51e.
2023-03-02 02:58:46 -08:00
Robo 6e85d2b51e
chore: update to Electron 22 (#166430)
* chore: bump electron@22.0.0-beta.5

* chore: bump electron@22.0.0-beta.7

* chore: update libc++ flags

* chore: switch to c++17

* chore: bump electron@22.0.0

* chore: bump electron@22.0.2

* chore: cleanup build config for linux

* chore: update debian dependencies

* chore: update rpm dependencies

* chore: update electron@22.0.3

* chore: bump electron@22.2.0

* chore: remove deprecated utility process invoker

* chore: bump electron@22.2.1

* chore: remove unused methods

* chore: update internal electron version

* chore: bump electron@22.3.0

* temp: update electron with default PGO

* chore: bump electron@22.3.1

* cleanup

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2023-02-28 07:04:00 -08:00
Benjamin Pasero 9bbce647b3
debt - strict layer rules for more services (#175411) 2023-02-25 15:49:47 +01:00
Matt Bierner 99e126b0b2
Pick up latest TS version for building VS Code (#162786)
Pick up latest TS for building VS Code
2022-10-06 12:08:45 -07:00
Benjamin Pasero 0895639566
debt - mention our wiki when putting out layer errors (#157768) 2022-08-10 15:37:21 +02:00
Matt Bierner a43e9acd68
Add AbortController to core types 2022-08-04 16:26:18 -07:00
Benjamin Pasero f4f1b04d87
Add a setting to enable sandbox: true for windows (#154062)
* sandbox - allow enabled sandbox in a full build

* sandbox - reduce `electron-browser` in workbench

* sandbox - reduce `electron-browser` in platform

* sandbox - add a setting to enable sandbox mode for window

* fix lint

* Revert "sandbox - reduce `electron-browser` in workbench"

This reverts commit 36a5167cf9.

* Revert "sandbox - reduce `electron-browser` in platform"

This reverts commit 6f49d704a5.

* fix layer issue

* fix some js errors
2022-07-05 09:54:28 +02:00
Benjamin Pasero be376cfef0
debt - improve ipc validation code 2022-04-12 07:46:21 +02:00
Benjamin Pasero 95c2a71018
Revert "ipcMain validation (#147071)"
This reverts commit 508b173177.
2022-04-11 19:34:12 +02:00
Benjamin Pasero 508b173177
ipcMain validation (#147071)
* first cut ipc validation

* clean up

* comment
2022-04-11 18:11:19 +02:00
João Moreno d06e16b59a
layer checker: follow parent symbols 2022-04-04 15:05:34 +02:00
Benjamin Pasero 693b2fdbaf
debt - make URL available as core type 2022-04-04 11:21:57 +02:00
Alex Dima 79e83ab7fa
Go back to using buitlin URL
This reverts commit 014814146e.
2022-03-25 09:25:49 +01:00
Benjamin Pasero 066b362943
fix layers checker to support trace 2022-03-15 21:06:22 +01:00
Robo 32d40cf44e
chore: update to electron 17 (#143223)
* chore: bump electron@17.0.0

* Revert "chore: revert to electron@13 (#143851)"

This reverts commit df645f1450.

* chore: bump electron@17.1.0

* Revert "ci: fix build with latest node-gyp"

This reverts commit c3e948aa30.

* chore: revert ci changes for node v16

* chore: update yarn.lock

* chore: bump electron@17.1.1
2022-03-11 00:51:37 +09:00
Robo df645f1450
chore: revert to electron@13 (#143851)
* Revert "chore: update to electron 16 (#137241)"

This reverts commit 01df559c18.
This reverts commit 46301339b7

* ci: fix remote compiler for sdl-scan

* chore: fix remote/.yarnrc

* chore: fix build/npm/postinstall.js

* chore: rm crash reporter from shared process

* chore: rm crash reporter from ext host

* chore: fix build/lib/layersChecker.ts

* :chore: preserve some more changes

* fix tests

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2022-02-24 17:49:49 +01:00
Benjamin Pasero ae0864d995
fix valid layers checker 2022-02-14 08:41:24 +01:00
Robo 01df559c18
chore: update to electron 16 (#137241)
* chore: bump electron@15.3.0

* chore: bump node@16.x

* chore: enable render process reuse

* Revert "watcher - use `type` property for crash reporter location"

This reverts commit bfa488dd8f.

* Revert "watcher - enable crash reports on linux (#136264)"

This reverts commit af261488f8.

* chore: enable crashpad on linux

* chore: bump electron@15.3.1

* chore: update api changes

* chore: bump @vscode/sqlite3@5.0.3

* spec: skip non-context aware module unittests

* chore: fix perf hook integration with node environment

* fix: adopt fs api changes

* chore: fix integration tests

* chore: bump electron@15.3.2

* chore: bump electron@16.0.0

* temp(macOS): kill test instances in OSS

* Revert "temp(macOS): kill test instances in OSS"

This reverts commit b0d796c8d64227a5ec012c060bbbee7d9da27568.

* chore: update chromium version for clang downloader

* some 💄 changes

* align with changes

* adopt more fs.rm

* 💄

* chore: bump @vscode/sqlite3@5.0.4

* fix layers check to account for duplicated types from node.js

* update todo for type casts

* smoke - fix compile issue

* chore: update module cache

* watcher - fix unhandled rejection (fix #137416)

* ci: update node version

* enable stack dumping

* update electron types to 16.x

* chore: bump @vscode/sqlite3@5.0.5

Refs https://github.com/microsoft/vscode/issues/137496

* fix layer issue

* add `AbortSignal` to core types

* chore: update linux compile flags

Refs 797723ec83

* ci: fix linux build

* ci: update github ci cache

* ci: fix remote build in github ci

* ci: better fix for remote build

* chore: bump azure cache

* chore: fix merge conflict

* :chore: update to electron@16.0.2

* chore: bump @vscode/sqlite3@5.0.7

* ci: update to gcc-4.9 for remote

Refs https://github.com/microsoft/vscode/issues/137659

* ci: switch to buster for linux arm

Refs https://github.com/microsoft/vscode/issues/137927

* ci: fix build on linux arm64

* ci: fix arm client compiler toolchain

Refs #137927

* chore: bump electron@16.0.3

* ci: fix compile flags for the c toolchain

* chore: bump electron@16.0.4

* Add experimental dark mode flag (#139109)

* Add experimental dark mode flag

* Apply PR feedback

* chore: bump electron@16.0.6

* chore: bump electron@16.0.7

Fixes https://github.com/microsoft/vscode/issues/138792
Fixes https://github.com/microsoft/vscode/issues/139300

* chore: experimental highlight API

* smoke - fix compile issue

* FIXME: custom ELECTRON_RUN_AS_NODE with node worker

* Revert "chore: bump electron@16.0.7"

This reverts commit 5fd01cf37c.

* Revert "Revert "chore: bump electron@16.0.7""

This reverts commit a7f1b73951.

* chore: fix github linux workflow

* chore: address review feedback

* chore: bump electron@16.0.8

* ci: revert to stretch distro for linux arm

Refs https://github.com/microsoft/vscode/issues/137927

* ci: force build

* chore: update yarn.lock

* address feedback

* Revert "FIXME: custom ELECTRON_RUN_AS_NODE with node worker"

This reverts commit 7b48fa3732.

* ci: fix remote folder build

* chore: fix github linux ci

* 🆙 `versionSpec`

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
Co-authored-by: Raymond Zhao <raymondzhao@microsoft.com>
2022-02-08 20:09:00 +01:00
João Moreno 5e630c145f
Enable IPC API for web (#138054)
* wip: ipc api

* wip: send message ports upfront

* address both inside and outside iframe

* fix build

* relay MessagePort to worker

* address api discussion feedback

* check for proposed api

* fix layer breakage

Co-authored-by: Alex Dima <alexdima@microsoft.com>
2022-01-05 02:11:12 -08:00
Benjamin Pasero 70489f2c90
layers - add trimStart and trimEnd 2021-12-14 12:32:10 +01:00
Logan Ramos 76c3eb94c9
On the fly tab model construction (#133025)
* Enrich the change event

* Initial tab model building

* Work in progress model construction

* Add pauseable emitter

* Attempt using microtask

* Make tests pass

* Update active tab logic

* Fix layering issue

* event rename

* PR feedback

* Remove stray new line

* Add test for microtask emitter

* Add move event

* Add mmerge functionality to Microtask emitter

* Fix compilation errrors

* Fix tests

* Add tests to address feedback

* Change editor change event to an array

* Add array support to editorsChangeEvent

* Update src/vs/workbench/common/editor/editorGroupModel.ts

Co-authored-by: Benjamin Pasero <benjpas@microsoft.com>

* Switch to a less efficient array method

* Add console.log for debugging

* Test with different notebook

* Fix notebook URI

* For now split up file open for better debugging

* Don't use notebook in test for now

* Cleanup event

* Fix tests

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
Co-authored-by: Benjamin Pasero <benjpas@microsoft.com>
2021-09-16 14:34:54 -04:00
Benjamin Pasero 8f1b7a36de
sandbox - allow to reuse environment service in sandbox 2021-03-15 11:27:31 +01:00
Benjamin Pasero a6946159d4 💄 layers checker 2020-12-08 09:29:16 +01:00
Benjamin Pasero 50ee84f780 debt - btoa/atob is not core 2020-10-15 13:55:18 +02:00
Benjamin Pasero 01472963d7 sandbox - rename electron service => native host service 2020-09-17 16:20:23 +02:00
Benjamin Pasero 82d30d49b2 sandbox - add electron service to layers checker 2020-09-17 15:43:15 +02:00
Benjamin Pasero b2acd8fa72 sandbox - make layers checker fit to complain about native things definedin common layer 2020-09-04 10:32:00 +02:00
Benjamin Pasero 3514e96bf5 sandbox - add rules for new electron-sandbox layer 2020-05-22 12:21:25 +02:00
Benjamin Pasero 2095810809 layers check - make sure to test editor contrib as well 2020-02-05 11:19:00 +01:00
Benjamin Pasero d59de94ba1 💄 2020-01-07 11:19:01 +01:00
Benjamin Pasero 9b6b25112e 💄 2020-01-07 11:10:01 +01:00
Benjamin Pasero 078b82d428 debt - rewrite layers checker to catch more cases 2020-01-07 11:04:05 +01:00