Matt Bierner
4efa993b13
Bump targets for test/automation and test/integration ( #165298 )
...
Also enables strict mode for test/integration since it only had strict null checks previously
2022-11-02 17:10:12 -07:00
Matt Bierner
57d64af6ad
Use ?. for property access ( #165295 )
2022-11-03 00:49:36 +01:00
David Dossett
2da60fd58b
Update quick pick placeholders and/or remove titles ( #165267 )
2022-11-02 15:43:18 -07:00
Megan Rogge
87bf03770e
tweak quick pick pin conditional ( #165285 )
...
tweak conditional
2022-11-02 18:25:32 -04:00
Ian Huff
9dd6ae2026
Remove ianhu from team github issue notebooks ( #165281 )
...
* remove ianhu from team github issue notebooks
* revert accidental line end change
Co-authored-by: Ian Huff <ianhuff@Ians-MacBook-Pro.local>
2022-11-02 15:12:18 -07:00
Sandeep Somavarapu
9c0c68c8cf
Fix #164690 #164730 ( #165279 )
...
- Maintain default installed extensions manifest always
- Adopt to default installed extensions manifest
- Add externally installed extension to default extensions manifest
2022-11-02 22:48:15 +01:00
Alex Ross
14d922cd51
Duplicating Menu Actions when switching profiles ( #165274 )
...
Fixes #161910
2022-11-02 22:44:37 +01:00
Alex Ross
9545edf1dc
TestInstantiationService in fileDialogService.test.ts ( #165270 )
...
Part of #164297
2022-11-02 22:44:13 +01:00
Megan Rogge
d1624fc87e
skip resolve (without backup) test ( #165277 )
2022-11-02 13:53:46 -07:00
Logan Ramos
86b8ed4649
Fix autoreveal on file nest ( #165272 )
2022-11-02 20:37:50 +01:00
Megan Rogge
469ee9360d
don't set quick pick items every time value changes ( #165113 )
2022-11-02 09:41:28 -07:00
Joyce Er
1b83b96a46
Save all dirty editors before storing edit session ( #165246 )
2022-11-02 09:36:56 -07:00
Matt Bierner
c36c93a37d
Let opener service validate that only specific commands can be run in command uris ( #165204 )
2022-11-02 09:26:49 -07:00
Logan Ramos
6aaf830b9c
Fix some cases of incremental naming disabled ( #165253 )
2022-11-02 09:05:41 -07:00
SphinxKnight
db1c4d4f85
Nit: fix Tip blocks case ( #165223 )
2022-11-02 12:00:13 -04:00
Johannes Rieken
f6f944e7ed
report perf marks whenever delivered ( #165250 )
2022-11-02 08:43:55 -07:00
Johannes Rieken
ba9be48390
adopt vscode.l10n in references view ( #165245 )
...
https://github.com/microsoft/vscode/issues/164438
2022-11-02 08:21:33 -07:00
Logan Ramos
cc7114b3ba
Switch to using CSS ( #165185 )
...
* Switch to using CSS
* Better fallback value
2022-11-02 09:10:49 -04:00
João Moreno
cbf6c41591
more test cleanup ( #165233 )
2022-11-02 11:52:32 +01:00
João Moreno
ff51b872df
cleanup ipc integration tests ( #165221 )
2022-11-02 09:17:43 +01:00
Ping
7fbec6dcc9
Fix KaTeX equation numbering in notebook preview ( #156276 )
...
Fixes https://github.com/microsoft/vscode/issues/155888
2022-11-02 01:09:32 -07:00
Megan Rogge
ad94ce6435
use ID for quick fix telemetry ( #165197 )
2022-11-02 08:11:14 +01:00
Peng Lyu
3ad328ce40
Merge pull request #165214 from microsoft/rebornix/disturbed-cobra
...
Reduce theme participant for notebook
2022-11-02 00:09:58 -07:00
rebornix
55a95c7086
Reduce theme participant for notebook diff editor
2022-11-01 22:36:34 -07:00
rebornix
19ca019845
Diff overview ruler css variables
2022-11-01 22:17:30 -07:00
Rob Lourens
28cf111d77
Don't clear the pause reason for other threads when processing a stopped event with allThreadsStopped=true ( #165180 )
...
Fix #165032
2022-11-01 22:12:15 -07:00
Peng Lyu
c51c91e232
Typo: folding controller. ( #165211 )
2022-11-01 20:29:22 -07:00
rebornix
abfb1f679b
Cell comments css variables
2022-11-01 20:23:46 -07:00
rebornix
c7330bb771
Notebook find widget and toolbar css variable.
2022-11-01 20:15:42 -07:00
Matt Bierner
7233e19dd5
Remove notebook content provider api ( #165195 )
...
Fixes #160580
Fixes #147248
2022-11-01 17:23:32 -07:00
SteVen Batten
bb4e4c44bd
don't create and dispose submenus ( #165206 )
...
fixes #161413
2022-11-01 17:03:34 -07:00
Matt Bierner
c6559ccf21
Pick up TS 4.9 rc for bundled VS Code version ( #165205 )
2022-11-01 16:39:15 -07:00
Matt Bierner
8ad43669a9
Prompt users to test with extensions disabled ( #165203 )
2022-11-01 16:38:45 -07:00
zhuowei
a9bf3117d8
webview: ignore Ctrl+W and Ctrl+N in webview for PWA ( #164981 )
...
This fixes closing Release Notes / Markdown Preview with Ctrl+W closing whole PWA.
PWAs can intercept the Ctrl+W/Ctrl+N keystrokes, and VSCode does this for editor tabs. However, webviews do not intercept these keystrokes.
If a webview such as Release Notes or Markdown Preview has focus:
- when the user presses Ctrl+N, another instance of the PWA is opened in a new window.
- when the user presses Ctrl+W, the whole PWA window closes.
See https://github.com/microsoft/vscode/issues/150735 for details.
This fixes the issue by ignoring Ctrl+W and Ctrl+N in webviews.
Tested on macOS 12.6 / Chrome Dev 109.0.5384.0:
- patch environmentService.ts webviewExternalEndpoint to use
http://localhost:8080/static/sources/out/vs/workbench/contrib/webview/browser/pre/
- followed the contributing instruction to run code-web
- in Chrome, More Tools -> Create Shortcut -> Open as window
- closed and re-opened Code OSS PWA window
- opened chrome://inspect and inspected the Code OSS window
- added an uncaught exception handler
- opened file.md and chose "Open preview"
- when it hit
`Expected '${parentOriginHash}' as hostname or subdomain!`
manually ran `start(parentOrigin)` in console and continued
- the markdown preview now displayed
- pressed Command+W
Before: the whole window closes
After: only the Markdown preview tab closes
2022-11-01 15:56:43 -07:00
Hugh Lilly
190db489e0
Markdown lang preview settings description ( #165109 )
...
* Change descriptions to just say “Enable…”
Previously these said “Enable or disable…”, which in the context of a tick box doesn’t make sense.
* Change “Enable/disable” wording in descriptions
2022-11-01 15:48:59 -07:00
Peng Lyu
1880c8ea6c
re #164939 . reduced unused exports in notebook worker. ( #165198 )
2022-11-01 14:19:29 -07:00
Peng Lyu
856a306d1a
re #164939 . reduced unused exports. ( #165196 )
2022-11-01 14:06:59 -07:00
Henning Dieterichs
d810d86c4c
Audio Cues: Don't play the same sound in parallel. Fixes #164921 ( #165194 )
2022-11-01 13:40:45 -07:00
Megan Rogge
e06811cd9e
use != operator instead of -ne ( #165191 )
...
use != operator
2022-11-01 16:37:22 -04:00
Alexandru Dima
a55eaa4d0c
Do not render synchronously when restoring the state, the desired scrollLeft is maintained even if the scrollWidth is small ( #165193 )
2022-11-01 13:34:50 -07:00
Henning Dieterichs
decab0af41
Limit shifting ( #165141 )
2022-11-01 13:15:30 -07:00
Matt Bierner
25c65295ab
Use css vars for lightbulb ( #165186 )
...
Fixes #165169
2022-11-01 12:47:13 -07:00
Megan Rogge
a9a1373b1f
prevent .zshenv recursion ( #165174 )
...
fix #163843
2022-11-01 15:42:49 -04:00
SteVen Batten
8f06fd3722
only renderBody when view is visible/expanded ( #165187 )
...
fixes PaneView calls renderBody even when the pane is collapsed #164662
2022-11-01 20:22:22 +01:00
Matt Bierner
d5d392b03d
Use _ for privates in webview code ( #165183 )
2022-11-01 11:41:34 -07:00
Alex Ross
fa2be83ef0
Remove unneeded export ( #165178 )
...
Part of #164933
2022-11-01 11:02:24 -07:00
Andre Weinand
d126b9f53a
Remove a few exports ( #165158 )
...
* Remove a few `export`s
* don't omit indirect exports
2022-11-01 10:57:05 -07:00
SteVen Batten
35a0299ff6
use ctxt menu event for all actBar context menus ( #165177 )
...
fixes #163247
2022-11-01 10:48:15 -07:00
Alex Ross
5ab1806804
Fix tree data provider being accessed after disposed ( #165087 )
...
* Fix tree data provider being accessed after disposed
Fixes microsoft/vscode-pull-request-github#4002
* Use setTimeout0
2022-11-01 13:28:53 -04:00
Rob Lourens
fe689beb75
Clean up some unused exports ( #165107 )
...
For #164937
2022-11-01 09:54:56 -07:00
