Commit graph

10 commits

Author SHA1 Message Date
Robo
e5f61433b5
chore: update to Electron 22 (#177600)
* Revert "chore: revert to Electron 19 (#175851)"

This reverts commit 3a11b47eee.

* chore: bump electron@22.3.3

* build: use custom version for V8 sandbox

* chore: update electron@22.4.1

* chore: enable forceAllocationsToV8Sandbox for extension host

* chore: bump electron@22.4.2

* chore: bump electron@22.4.3

* sandbox - cleanup from electron 22 update (#178919)

* Revert "chore: revert to Electron 19 (#175851)"

This reverts commit 3a11b47eee.

* chore: bump electron@22.3.3

* build: use custom version for V8 sandbox

* chore: update electron@22.4.1

* chore: enable forceAllocationsToV8Sandbox for extension host

* chore: bump electron@22.4.2

* chore: bump electron@22.4.3

* temp: update distro

* sandbox - cleanup from electron 22 update

* missing comile

* more changes

* fix build

* restore

* 💄

* compile

---------

Co-authored-by: deepak1556 <hop2deep@gmail.com>

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2023-04-03 09:09:31 +02:00
Robo
3a11b47eee
chore: revert to Electron 19 (#175851)
* Revert "Update to min supported version of node (#175723)"

This reverts commit f749e6be2d.

* Revert "chore: update min node version for development (#175663)"

This reverts commit f2a822fbe9.

* Revert "electron 22 sandbox - enable for OSS (#175659)"

This reverts commit 2551af21f8.

* Revert "chore: update to Electron 22 (#166430)"

This reverts commit 6e85d2b51e.
2023-03-02 02:58:46 -08:00
Don Jayamanne
f749e6be2d
Update to min supported version of node (#175723) 2023-03-01 03:02:10 +01:00
Errietta Erry Kostala
9e0de4af67
Add .nvmrc (#152883)
Since the contribution guidelines advise on a specific version of node,
it adding .nvmrc for those that use nvm will automatically let them use the
correct version of node if they do nvm use

just a small QOL thing for devs.

Co-authored-by: João Moreno <joao.moreno@microsoft.com>
2022-07-22 15:55:53 +02:00
João Moreno
0f779f644f
remove nvmrc 2020-09-30 11:09:03 +02:00
Alasdair McLeay
65579c1715
Update .nvmrc
How to contribute lists recommendation of node 10:

> Node.JS, 64-bit, recommended >=10.15.1, < 11.0.0
https://github.com/Microsoft/vscode/wiki/How-to-Contribute#prerequisites

Updating .nvmrc to match
2019-03-18 15:13:14 +00:00
Thien Do
13b73269d9
Update nvmrc
As noted in [the wiki](https://github.com/Microsoft/vscode/wiki/How-to-Contribute#prerequisites) node's version should be larger than 8.12 so 8.9.2 will not work.

In fact, I think we only need to define the target version as `8` so we can have the latest version that satisfies the requirement (`>= 8.12.0, < 9.0.0`). At the time of writing it is `8.15` which works perfectly fine (install + watch + run).
2019-01-28 00:57:32 +07:00
Tomer Ohana
3070e87332 Add .nvmrc file 2017-12-06 19:10:45 +02:00
Joao Moreno
800e3db207 Revert "add .nvmrc for using osx native fs-events with gulp"
This reverts commit bdbd4fa2f2.
2016-03-09 18:36:35 +01:00
Joao Moreno
bdbd4fa2f2 add .nvmrc for using osx native fs-events with gulp 2016-03-09 17:40:45 +01:00