rebornix
a03daaf850
Merge branch 'notebook/dev' into main
2021-05-21 14:13:43 -07:00
Matt Bierner
22dc518a21
Remove unused type
2021-05-21 12:16:49 -07:00
Matt Bierner
97bbacd808
Remove extra call to with
2021-05-21 12:16:49 -07:00
Matt Bierner
79dea51e79
Rewrite webview urls to be more url-ish
...
## Problem
Webview uris currently have the form:
```
https://uuid.vscode-webview.net/vscode-resource/scheme/authority/path ...
```
We have this syntax because we need to be able to recover the original scheme and authority of the resource in order to load it from disk
However this syntax means that absolute urls don't behave as you'd expect. For example, if you have a webview that sets a `<base>` to a document in the workspace, an absolute url `/abs/path.png` ends up being resolved to:
```
https://uuid.vscode-webview.net/abs/path.png
```
This drops the original scheme and authority, which prevents us from loading the resource
## Fix
With this change, I've moved the original scheme and authority into the authority of the webview uri instead of the path:
```
https://scheme+authority.vscode-resource.uuid.vscode-webview.net/path ...
```
With this change, absolute paths should correctly be resolved
2021-05-21 09:28:43 -07:00
Rob Lourens
70c87f0db9
Fix #124240
2021-05-21 09:12:57 -07:00
Johannes Rieken
effac5be7f
drop as-prefix for ICreateCellInfo
2021-05-21 17:30:29 +02:00
Alex Dima
85f518b255
Add RemoteAuthorityResolver.getCanonicalURI
2021-05-21 16:48:14 +02:00
Martin Aeschlimann
32a06b9be2
[typescript] add limited description
2021-05-21 15:38:02 +02:00
Johannes Rieken
375a15f07e
Merge branch 'main' into notebook/dev
2021-05-21 12:59:49 +02:00
Johannes Rieken
494e827e35
expose output item bytes to renderers and provide util functions: asText, asJSON, asBytes, asBlob, fyi @connor4312, https://github.com/microsoft/vscode/issues/123884
2021-05-21 12:36:10 +02:00
Martin Aeschlimann
73c6f34f9e
Do not recognize Debian's .install file as a shell script. Fixes #124295
2021-05-21 11:20:33 +02:00
rebornix
894b7782cc
Merge branch 'notebook/dev' into main
2021-05-20 14:17:28 -07:00
Raymond Zhao
9627b4ea63
Emmet identify CDATA for wrap, fixes #123136
2021-05-20 13:20:50 -07:00
Andrea Mah
18c254987c
Merge branch 'main' into dev/t-andreamah/markdown-static-preview-scroll-state
2021-05-20 09:47:29 -06:00
rebornix
f583b4b336
Merge branch 'main' into notebook/dev
2021-05-19 19:02:13 -07:00
Matt Bierner
34180ac9be
Remove code allowing multiple ids for a command
...
This doesn't appear to be used anywhere
2021-05-19 18:23:51 -07:00
Matt Bierner
35eafb7873
Add sort imports command
...
Fixes #122593
Sort imports just sorts imports, vs organize imports which also removes unused imports
2021-05-19 18:20:16 -07:00
Andrea Mah
4fbd548d72
Merge branch 'main' into dev/t-andreamah/markdown-static-preview-scroll-state
2021-05-19 17:25:56 -06:00
Andrea Mah
f594bb47e5
removing more unecessary whitespace
2021-05-19 17:00:55 -06:00
Andrea Mah
41606da2dc
removing unecessary spaces
2021-05-19 16:59:26 -06:00
Andrea Mah
9ee1906718
pr feedback and combining prevEditor info for preview and non-preview
2021-05-19 16:57:12 -06:00
Matt Bierner
f433b4781a
Pick up TS 4.3.1-rc
2021-05-19 15:47:35 -07:00
Matt Bierner
d921cc41fc
Update markdown grammar
2021-05-19 15:34:07 -07:00
Rob Lourens
0d33806803
Add suiteRepeat test util
2021-05-19 14:29:32 -07:00
rebornix
5b3cf7cc2a
Merge branch 'notebook/dev' into main
2021-05-19 14:12:17 -07:00
João Moreno
25a12c75c5
use dummy uri
2021-05-19 20:40:07 +02:00
Andrea Mah
44d135e94f
Merge branch 'main' into dev/t-andreamah/markdown-static-preview-scroll-state
2021-05-19 12:15:49 -06:00
Connor Peet
b02acf3908
Merge pull request #123738 from microsoft/dev/mjbvz/unify-renderers-api
...
First cut at unifying notebook renderers apis
2021-05-19 08:52:02 -07:00
Johannes Rieken
b63ad124d2
mark untitled notebooks as dirty by default, don't hold on to untitled notebooks eagerly, https://github.com/microsoft/vscode/issues/121974
2021-05-19 17:16:48 +02:00
Johannes Rieken
53352a2954
add API to open an untitled notebook, https://github.com/microsoft/vscode/issues/121974
2021-05-19 15:27:23 +02:00
Benjamin Pasero
159479eb5a
Allow to show status bar entries with an id and name ( fix #74972 )
2021-05-19 14:03:37 +02:00
Rob Lourens
97518f5e86
Copy testRepeat helper to extension integration tests
2021-05-18 21:53:57 -07:00
Connor Peet
616e0fd992
refactor: polish
...
- Fix mis-used dependencies. Add the roughly proposed 'extends' model
for notebook renderers. Keep it out of contribution schema for now
until we can work it more.
- Made new loading work with JS modules.
- Consolidated the 'old style' code in the renderer so that we can just
delete it when the time comes.
- Removed duplicated code and sharp edges from the 'queue' mechaism.
2021-05-18 16:59:09 -07:00
rebornix
df93e53dfb
Merge branch 'notebook/dev' into main
2021-05-18 14:30:53 -07:00
Connor Peet
5c4fae9176
Merge remote-tracking branch 'origin/notebook/dev' into dev/mjbvz/unify-renderers-api
2021-05-18 12:55:33 -07:00
Miguel Solorio
455a8b6949
List focus colors are too dark ( Fixes #123703 )
2021-05-18 10:24:01 -07:00
Alex Ross
e4159c8f89
Add protocol to portsAttributes
...
Part of #123750
2021-05-18 12:55:17 +02:00
Johannes Rieken
956347c4ed
better logic for "notebook open/close, notebook ready when cell-document open event is fired", https://github.com/microsoft/vscode/issues/123655
2021-05-18 09:40:31 +02:00
Alex Ross
736896527c
Improve npm trust message
2021-05-17 10:50:33 +02:00
Alex Ross
c8b4656197
Add requireLocalPort property to portsAttributes
...
Fixes microsoft/vscode-remote-release#4958
2021-05-14 16:01:40 +02:00
Andrea Mah
94498778fb
cleanup
2021-05-13 15:24:56 -06:00
Rob Lourens
f9df7b2f1a
Merge branch 'main' into notebook/dev
2021-05-13 12:48:47 -07:00
Andrea Mah
9731995d94
addressed ! nit
2021-05-13 12:39:52 -06:00
Andrea Mah
3dec3b3385
applied PR feedback
2021-05-13 12:30:10 -06:00
Matt Bierner
66fa5c41b3
First cut at unifying notebook renderers apis
...
This implements the api described in #123540 . Major points:
- Instead of having the `markdown-it` renderer pull it its dependencies, instead the dependencies can call `getRenderer` to import the object returned by the `markdown-it` renderer
- We try to detect if a renderer is using the old or new api. Old renderers are still run as globals while new ones are loaded with `import`
- I have only hooked up the new API for markdown renderers so far
2021-05-12 19:32:57 -07:00
Rob Lourens
2b8d74c4a8
Make metadata/internalMetadata non-optional
2021-05-12 18:19:10 -07:00
Andrea Mah
d2894562d5
fixing issue with static scroll alongside text editor
2021-05-12 17:59:00 -06:00
Andrea Mah
ee4510b4bf
Merge branch 'main' into dev/t-andreamah/markdown-static-preview-scroll-state
2021-05-12 17:01:41 -06:00
Andrea Mah
18950181eb
scroll state persists while toggling between static preview and text
2021-05-12 16:59:57 -06:00
rebornix
c5a8e59db7
update notebook contributions.
2021-05-12 14:56:55 -07:00
rebornix
a41b51ab3f
update notebook contributions.
2021-05-12 14:56:27 -07:00
rebornix
a37ee2baf1
Merge branch 'notebook/dev' into main
2021-05-12 14:37:05 -07:00
Matt Bierner
11a8c4b4bc
Merge the notebookMarkupRenderer contribution point into the renderers contribition point
...
For #123540
2021-05-12 13:28:28 -07:00
Johannes Rieken
0a14a26cd3
rename latestExecutionSummary to executionSummary
2021-05-12 09:34:21 +02:00
Johannes Rieken
0b3618c6e9
fix integration test
2021-05-12 08:53:18 +02:00
Andrea Mah
927e791753
Fix Initial Scroll Position on Markdown Dynamic Preview ( #123613 )
...
* added semicolons to pass code check
* removed preliminary work for static preview
* cleanup
Co-authored-by: Andrea Mah <t-andreamah@microsoft.com>
2021-05-11 17:12:19 -07:00
rebornix
05d4a5c56d
skip test.
2021-05-11 15:01:45 -07:00
rebornix
eb6e048ca3
Merge branch 'notebook/dev' into main
2021-05-11 14:08:05 -07:00
Alex Dima
5f3466a21e
Change grunt, gulp and jake task auto detection to be off by default ( #123588 )
2021-05-11 19:09:56 +02:00
Martin Aeschlimann
4151b62cfa
update seti contribution guide
2021-05-11 17:58:26 +02:00
Martin Aeschlimann
86bc05155f
update seti theme
2021-05-11 17:35:15 +02:00
Johannes Rieken
b58a33aba7
Merge branch 'main' into notebook/dev
2021-05-11 16:03:52 +02:00
Martin Aeschlimann
1e810cafb7
The default Monokai highlight color is displayed incorrectly. Fixes #123044
2021-05-11 13:46:56 +02:00
Johannes Rieken
d5ab22d7db
test that no RPC leaks via NotebookController
2021-05-11 09:39:01 +02:00
Matt Bierner
d60cbb0eae
Pick up latest TS nightly for extension
2021-05-10 19:09:41 -07:00
Peng Lyu
ae998a9261
Merge remote-tracking branch 'origin/notebook/dev' into main
2021-05-10 23:44:32 +00:00
Martin Aeschlimann
05d22c6853
[html] duplicated onDocumentRangeFormatting handler ( #122994 )
2021-05-10 18:09:18 +02:00
Alex Ross
8de5c819a1
Add test for C# grammar but
...
Part of https://github.com/microsoft/vscode/issues/123333
2021-05-10 15:05:52 +02:00
Alex Ross
66eb516dc3
Revert C# grammar
...
Part of https://github.com/microsoft/vscode/issues/123333
2021-05-10 14:59:58 +02:00
Johannes Rieken
06fa8b8543
API 💄 for NotebookCellData
2021-05-10 11:33:41 +02:00
Johannes Rieken
7ea5b137ea
rename cell kind Markdown to Markup, https://github.com/microsoft/vscode/issues/105933
2021-05-10 10:56:13 +02:00
Johannes Rieken
b9c5d61dfe
Merge branch 'main' into notebook/dev
2021-05-10 08:42:19 +02:00
Rob Lourens
b987317d1a
Rename onDidChangeNotebookCellExecutionState
2021-05-07 17:00:09 -07:00
Rob Lourens
4a76f0b19a
registerNotebookCellStatusBarItemProvider should use viewType instead of NotebookSelector
...
Fix #122347
2021-05-07 15:23:19 -07:00
Kevin Abel
4978a1891e
Implement GitHub Enterprise authn provider ( #115940 )
2021-05-07 14:13:11 -07:00
rebornix
e2fe443491
Merge branch 'notebook/dev' into main
2021-05-07 13:46:51 -07:00
rebornix
110c966887
💄
2021-05-07 13:13:22 -07:00
rebornix
0568de16a8
support multiple cell ranges.
2021-05-07 13:12:14 -07:00
Connor Peet
54ce4a405e
server-ready: support debugWithEdge as well as debugWithChrome
2021-05-07 12:02:36 -07:00
Martin Aeschlimann
81643c948f
HTML, CSS, JSON language servers don't provide the documentFormattingProvider capability. Fixes #122994
2021-05-07 17:03:16 +02:00
Johannes Rieken
1ab76005d3
even more strict assertions in flaky integration tests
2021-05-07 15:19:53 +02:00
Johannes Rieken
dbdcdecdaa
skipped/failing test for https://github.com/microsoft/vscode/issues/123270
2021-05-07 11:59:29 +02:00
Johannes Rieken
b2341b9cc6
run saveAllFilesAndCloseAll in setup and teardown and don't have it in each and every test, avoid usage of 'vscode.openWith'-command and prefer showNotebookDocument
-API
2021-05-07 11:50:22 +02:00
Matt Bierner
40321932fc
Render KaTeX errors in notebooks
...
Fixes #122413
2021-05-06 17:10:33 -07:00
Matt Bierner
0bae48f6c1
Enable markdown notebook extensions in untrusted workspaces
2021-05-06 16:05:47 -07:00
Matt Bierner
8c186e8f4a
Enable notebook markdown-extensions in virtualWorkspaces
...
Fixes #123067
2021-05-06 15:28:54 -07:00
Matt Bierner
f25ffb76ed
Fix stopping load indicator when updateOpen completes
...
Fixes #122979
We can consider the project loaded when `updateOpen` completes for all servers. Previously we were only waiting on the first one
2021-05-06 14:54:53 -07:00
Miguel Solorio
fe23c2041f
Merge pull request #122893 from microsoft/misolori/quick-pick-list-update
...
Update quick pick list widget focus colors
2021-05-05 20:38:05 -07:00
rebornix
ee927cc1b8
Merge branch 'notebook/dev' into main
2021-05-05 14:37:30 -07:00
Matt Bierner
13d81db250
Don't insert link element into the markdown cell preview body
...
Fixes #123012
2021-05-05 14:35:46 -07:00
Matt Bierner
2cf38034a3
Pick up new TS nightly
2021-05-05 10:57:19 -07:00
Johannes Rieken
2c91a75e21
Merge branch 'main' into notebook/dev
2021-05-05 08:33:09 +02:00
Johannes Rieken
8a41ae1d93
less openWith-command, more editor asserting, https://github.com/microsoft/vscode/issues/122851
2021-05-05 08:32:06 +02:00
rebornix
d631beda22
Merge branch 'notebook/dev' into main
2021-05-04 15:31:11 -07:00
Rob Lourens
c22fad1fa4
Fix php autoindent with ])
...
Fix #122899
2021-05-04 15:06:52 -07:00
Logan Ramos
656e1e6086
More deprecated assertion cleanup
2021-05-04 15:55:26 -04:00
Logan Ramos
af69dc26ca
notEqual -> notStrictEqual
2021-05-04 15:55:25 -04:00
Connor Peet
d639345791
notebooks: improve renderer message passing
...
Fixes https://github.com/microsoft/vscode/issues/122944
2021-05-04 12:35:06 -07:00
Logan Ramos
025fcaf611
remove old asserts from git tests
2021-05-04 15:32:21 -04:00
Logan Ramos
775ef54707
Remove assert.equal from custom editor tests
2021-05-04 15:09:54 -04:00