Connor Peet
cacaccb42f
net: gracefully disconnect better from remote ( #218972 )
...
* net: gracefully disconnect better from remote
This adds in a step to gracefully disconnect (send a "disconnect"
message and then await the flush) before closing the workbench. In some
cases, like Remote - SSH, sending messages is more async than others. In
the exec server connection we handle a `zlib.flate` stream to compress
data to and from the VS Code server, and its API is asynchronous, so
this lets us ensure the stream is drained before giving the go-ahead
to close up shop
This lifecycle phase is a little awkward and I ended it putting it
directly in the lifecycle service: we don't want to do this in
`onWillShutdown` because some contributions want to save data to the
remote workspace, and if shutdown is vetoed it would leave a broken
state. But `onDidShutdown` is synchronous and already depended upon by
several other points, and changing that also felt a bit risky.
cc @alexdima
Refs #211462 , will require some small adoption in Remote - SSH to close.
* undo unrelated change
* add priority to joiners
* some cleanup
* cleanup
* tweaks
* `runWithFakedTimers`
* comment
* 💄
---------
Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2024-07-02 08:56:00 -07:00
Ladislau Szomoru
48e40d3c8e
SCM - 💄 adopt observable in working sets ( #219701 )
2024-07-02 16:32:59 +02:00
Ladislau Szomoru
3c7cbd264e
Git - include unstaged changes when amending a commit and smart commit is enabled ( #219675 )
2024-07-02 14:50:50 +02:00
João Moreno
c395df82fb
bump node-gyp once again
2024-07-02 14:12:39 +02:00
Benjamin Christopher Simmonds
c57f7bbe78
fixes #213334 ( #219669 )
...
fixes 213334
2024-07-02 12:33:13 +02:00
Ladislau Szomoru
c1f025d79f
SCM - 💄 use editor placeholder instead of custom solution ( #219662 )
2024-07-02 12:13:39 +02:00
Benjamin Christopher Simmonds
4fb0b15298
Fix issue with clicking between active tabs ( #219651 )
...
* fix #213160
* cleanup
* 💄
2024-07-02 11:10:11 +02:00
Johannes Rieken
b5c96d96ca
debt - remove defaultImplicitVariables from agents and remove variable resolvers for inline chat (editor, notebook) ( #219659 )
2024-07-02 11:09:55 +02:00
Henning Dieterichs
ad50f01dc1
Enables advanced hot reloading in monaco playground server.
2024-07-02 10:45:59 +02:00
Henning Dieterichs
0a16d3c1be
Allows multiple hot reload handlers to participate
2024-07-02 10:45:30 +02:00
Henning Dieterichs
0cc941e893
Fixes placeholder placement issues
2024-07-02 10:27:03 +02:00
João Moreno
3ad2eb18b5
bump node-gyp in build/npm/gyp ( #219647 )
2024-07-02 09:43:59 +02:00
Henning Dieterichs
01b9e01112
Fixes mangling issue in CI
2024-07-02 09:11:19 +02:00
Rob Lourens
42b3bac02e
Dispose some child InstantiationServices ( #219607 )
...
#212879
2024-07-02 01:01:01 +02:00
Rob Lourens
0db947b90c
Small chat renderer cleanup ( #219597 )
2024-07-01 15:52:12 -07:00
Robo
a02f3c923d
cli: restrict pkg config search directory to sysroot ( #219572 )
2024-07-01 19:59:38 +02:00
Henning Dieterichs
3652f9c8b3
Repairs hot reload for monaco editor playground.
2024-07-01 19:47:59 +02:00
Henning Dieterichs
01a77403bf
Fixes wrapInReloadableClass* functions.
2024-07-01 19:46:18 +02:00
Henning Dieterichs
013b1861dc
Fixes potential leak
2024-07-01 19:40:01 +02:00
Henning Dieterichs
cf3e2a4e81
Fixes #211403
2024-07-01 19:35:00 +02:00
Benjamin Pasero
327279994e
debt - update path.ts to node.js 20.x ( #219560 )
...
first cut update
2024-07-01 18:30:08 +02:00
Henning Dieterichs
db7e8f1f1d
Disables wrapInReloadableClass ( #219555 )
2024-07-01 08:32:55 -07:00
Sandeep Somavarapu
2601618162
fix #219336 ( #219553 )
...
fix #219336 (#219337 )
* fix #219336
* fix owner
2024-07-01 16:37:47 +02:00
Benjamin Christopher Simmonds
473e348591
Improve compact badge display ( #219552 )
...
Show up to 3 characters in compact badge
2024-07-01 16:31:26 +02:00
Henning Dieterichs
b213c86284
Extracts hot reload utilities, makes placeholderText contribution hot reloadable
2024-07-01 16:16:06 +02:00
Benjamin Pasero
af5cf640d8
🆙 "@playwright/test": "^1.45.0" ( #219324 )
2024-07-01 12:23:41 +02:00
Martin Aeschlimann
4c69ceba2f
rename editor.collapsedText to foldPlaceholderForeground ( #219338 )
...
rename vscode-editor-collapsedText
2024-07-01 12:13:03 +02:00
Benjamin Pasero
d65fd5ba2e
nls follow up debt work ( #219265 )
2024-07-01 11:44:19 +02:00
Johannes Rieken
376a7f73ed
Merge pull request #218896 from microsoft/joh/debt/inlineChatAgentAndCommands
...
let inline chat use default command and agent completions
2024-07-01 11:30:34 +02:00
Johannes Rieken
ea03089bee
fixup ChatRequestNotebookData ( #219331 )
...
re https://github.com/microsoft/vscode/issues/218363
2024-07-01 10:29:54 +02:00
Robo
d3035ba351
ci: disable cli glibc checks ( #219327 )
2024-07-01 09:26:45 +02:00
Benjamin Pasero
abe5b7d16f
debt - more direct fs use ( #219261 )
2024-07-01 09:18:40 +02:00
Johannes
44ac947b5f
review feedback: remove unneccessary check
2024-07-01 09:02:51 +02:00
Johannes
e7e83d6442
Merge branch 'main' into joh/debt/inlineChatAgentAndCommands
2024-07-01 08:58:54 +02:00
Ladislau Szomoru
0426dd4e2a
SCM - 💄 adopt observables ( #219162 )
2024-06-29 20:06:00 +02:00
Sandeep Somavarapu
0225546178
#212879 dispose child instantiation service ( #219217 )
...
* #212879 dispose child instantiation service
* fix tests
2024-06-29 19:40:07 +02:00
Benjamin Pasero
943b47ae17
debt - adopt nlsCoreBaseUrl ( #219165 )
2024-06-29 17:47:45 +02:00
Rob Lourens
39aba8e0af
Tune chat render rate ( #219241 )
...
Count words more correctly
Don't measure the time before text starts to appear
Better logs
2024-06-29 14:31:50 +02:00
Rob Lourens
5bece9e46a
Clear all workspace chats should also clear all open chats ( #219198 )
...
Fix #218034
2024-06-29 00:39:18 +02:00
Rob Lourens
c8a4a25577
Add 'command' to chat telemetry ( #219218 )
2024-06-28 14:25:19 -07:00
Aaron Munger
032c1b7544
don't show output items if they are empty ( #216844 )
...
* wait for content to attach toolbar
* command to show hidden outputs
* avoid perf hit of checking innerText on resize
* empty based on 0 content height
* just rely on height=0 for empty output
* use event to attach toolbar
* leave border in, but account for the height it adds
* hide again if content goes back to zero height
* zero
* tests, fix memory leaks
* move magic number to common function
2024-06-28 23:07:28 +02:00
Rob Lourens
206e438ff4
Fix #218031 ( #219215 )
2024-06-28 13:48:14 -07:00
Sandeep Somavarapu
da36fe717e
fix #218133 ( #219212 )
2024-06-28 13:47:41 -07:00
Sandeep Somavarapu
5fc4b6e873
skip version check in oss ( #219206 )
2024-06-28 13:31:08 -07:00
Justin Chen
fe473c806f
issue reporter short circuit logic fix ( #219002 )
...
* add better desccription check
* check on listener change
2024-06-28 13:05:29 -07:00
Rob Lourens
46362deb36
Support <sub> and <sup> in chat ( #219053 )
2024-06-28 11:06:45 -07:00
Johannes Rieken
5da15f50df
Merge pull request #218393 from c-claeys/instantiation-dfs
...
Fix exponential runtime in service instantiation
2024-06-28 18:11:12 +02:00
Johannes
6e187c64b1
Merge branch 'main' into joh/debt/inlineChatAgentAndCommands
2024-06-28 18:01:27 +02:00
Sandeep Somavarapu
d9744cf206
skip version check in oss ( #219127 )
2024-06-28 17:59:27 +02:00
Johannes Rieken
dd7d9376fb
remove dead types from old proposal versions ( #219120 )
2024-06-28 17:03:26 +02:00
