Commit graph

1253 commits

Author SHA1 Message Date
Kartik Raj 22631c1bdc Do not return variable property 2023-04-12 17:40:00 +00:00
Kartik Raj 8c3884bed5 Fix terminal integration test 2023-04-12 03:28:13 +00:00
Matt Bierner 3e5253b143
Remove notebook controller kind API proposal (#175962)
Fixes #168535
2023-03-16 08:52:09 +11:00
aamunger 869f18c010
fail with more info 2023-03-01 15:31:54 -08:00
Aaron Munger fae46b88cf
Merge pull request #175704 from amunger/differentiateTest
unique test names
2023-02-28 22:02:32 -08:00
aamunger f2550cb362
unique test names 2023-02-28 14:54:54 -08:00
aamunger 2d169f44a3
small diagnostics update 2023-02-28 14:50:03 -08:00
Benjamin Pasero 6a1eb923ca
Integration test failure - vscode API - commands (fix #174319) (#174320) 2023-02-14 10:24:46 +01:00
Benjamin Pasero 14f13b1f20
skip flaky notebook tests (#173124)
* skip flaky notebook test

* link to issue

* skipe the suite
2023-02-02 09:58:05 +01:00
Peng Lyu c581592f24
Re #170072, disable nb flaky test. (#173091) 2023-02-02 06:02:14 +01:00
Martin Aeschlimann 7dff9e992b
add executeFoldingRangeProvider command (#172968)
* add executeFoldingRangeProvider command

* add jsdoc for FoldingRangeKind.fromValue
2023-02-01 01:03:02 -08:00
Benjamin Pasero f01a44b447
Editors can steal focus later when opening slowly (fix #128117) (#170328)
* Editors can steal focus later when opening slowly (fix #128117)

* play it a bit safer

* fix tests
2023-01-01 16:31:26 +01:00
Peng Lyu bf6305fb52
Re #125369. Reduce commands in nb integration test. (#169684)
Re #125369. Reduce commands
2022-12-20 22:47:01 +01:00
Matt Bierner 57dd298b47
Add typings for test runner scripts (#169196) 2022-12-15 02:19:24 +01:00
Benjamin Pasero ac084d723b
notebook tests - run verbose (#165149) (#167212)
* notebook tests - run verbose (#165149)

* bumpb

* 💄
2022-11-26 11:37:52 -08:00
Peng Lyu 4ed4cf6042
Remove unused proposed api enablement. (#167077) 2022-11-23 09:53:18 -08:00
aamunger 2deaa43aa6
specify notebook document 2022-11-16 14:01:31 -08:00
Benjamin Pasero f176ad8e28
workspace.applyEdit drops the TextEdit if there is a RenameFile later #77735 (fix #166436) (#166439) 2022-11-16 09:43:07 +01:00
Sandeep Somavarapu 2cd8ea24f2
#159892 Finalize (#165925) 2022-11-09 10:28:27 -05:00
Matt Bierner 7233e19dd5
Remove notebook content provider api (#165195)
Fixes #160580
Fixes #147248
2022-11-01 17:23:32 -07:00
Sandeep Somavarapu fe882ab334
api feedback (#164470)
* api feedback
- remove critical log level
- move log level off to be 0

* handle off log level

* fix disabling log level in tests

Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com>
2022-11-01 10:41:19 -04:00
João Moreno 18f1101f70
skip flaky test (#165150)
* skip flaky test

related to #165149

* skip the entire suite
2022-11-01 06:26:44 -07:00
Matt Bierner b97827dacf
Adopt notebook serializer for notebook document tests (#165081)
For #160580

Also remove one test that is no longer relevant
2022-10-31 12:56:40 -07:00
Matt Bierner c60980ca7a
Adopt notebook serializer for test (#165078)
For #160580
2022-10-31 12:01:38 -07:00
Matt Bierner 4eef476a4f
Remove old notebook editor api proposal (#164504)
All consumers should now be on the finalized api

Fixes #151661
2022-10-24 14:40:53 -07:00
Ladislau Szomoru 76191c7c75
Engineering - Remove proposal that has been finalized (#164127)
Remove proposal that has been finalized
2022-10-20 04:30:27 -07:00
Sandeep Somavarapu 894aa9a7a7
Log improvements (#163532)
* - expose log level in the proposed api
- ability to set log level per logger

* fix tests
2022-10-13 03:48:52 -07:00
Rob Lourens cf47b76c63
Finalize notebookDebugOptions API (#163316)
* Finalize notebookDebugOptions API
Fix #147264

* Backcompat for the option from vscode-jupyter

* Undo comment

* Fix build
2022-10-11 20:25:51 -07:00
Alex Ross 23e6c032af
Start enforcing the tunnels API (#163187)
* Start enforcing the tunnels API

* Fix API test
2022-10-10 10:10:24 -07:00
Matt Bierner c2a2ad4f63
Rename image-preview extension to media-preview (#162093)
Fixes #162092

Also removes `aac` from the list of supported audio formats
2022-09-27 21:01:14 -07:00
Rob Lourens 0e333cd799
Convert NotebookCellStatusBarItem test from integration test to unit test (#161274)
Fix #157828
2022-09-20 09:55:58 +02:00
Benjamin Pasero ec56dddd9f
tests - remove snippetWorkspaceEdit usage (#161043) 2022-09-16 00:34:30 -07:00
Tyler James Leonhardt ccddb94f98
initial cut of vscode.l10n (#158328) 2022-09-14 16:48:25 -07:00
Rob Lourens 37f08d1195
Remove notebookEditorEdit proposal requirement (#160912) 2022-09-14 09:41:21 -07:00
Daniel Imms a4cce8f575
Merge pull request #160900 from babakks/add-change-shell-event
Add `onDidChangeShell` event to the API
2022-09-14 07:53:50 -07:00
Daniel Imms c4611298a3
Add envShellEvent to vscode-api-tests 2022-09-14 07:32:41 -07:00
Matt Bierner 1d500fb4de
Add CodeActionKind.RefactorMove (#160730)
Fixes #160728
2022-09-12 15:14:06 -07:00
Matt Bierner 2514759850
Remove notebook content provider save and backup functionality (#160581)
For #147248

When stepping through the liveshare code, we figured out they do not appear to be using `save`, `saveAs`, or `backup` (they return empty results for these)

This PR removes this part of the proposal so we can track just the parts of the api that they are using
2022-09-12 14:08:25 -07:00
Benjamin Simmonds 8268e5d27d
Remove enabledApiProposals badge from test ext (#160526) 2022-09-09 15:36:53 +02:00
Logan Ramos b8afe8d6ed
Skip tab getter tests on web because notebooks are flaky (#160403)
Skip tab tests on web because notebooks are flaky
2022-09-08 04:59:12 -07:00
Johannes Rieken 9bbc7b2bb0
Merge pull request #160193 from microsoft/joh/ordinary-canidae
support `contents` option with `WorkspaceEdit#createFile`
2022-09-07 16:33:42 +02:00
Johannes 4da1e34afe
add content property to vscode-dts-defined properties 2022-09-07 13:21:05 +02:00
Johannes Rieken 50cdf1d71b
Merge pull request #160176 from microsoft/joh/nasty-rook
have an explicit `SnippetTextEdit` and all to set them onto a workspace edit
2022-09-07 00:02:46 +02:00
Johannes b0140c2ca4
support contents option with WorkspaceEdit#createFile 2022-09-06 16:19:08 +02:00
Johannes bcf6547e92
fix API tests for new API 2022-09-06 14:53:43 +02:00
Benjamin Simmonds f51258b93b
Optional TreeItem Checkbox (#158250) 2022-09-06 12:41:57 +02:00
Benjamin Pasero 968d9eda2c
Integration test failure: openTextDocument, untitled closes on save (#157897) (#159888) 2022-09-02 13:43:44 +02:00
Logan Ramos a2cd34f347
Allow showTextDocument to open notebook cell URIs (#158477)
* Fix #123270

* Update to use `getCodeEditor`
2022-08-30 06:39:00 -04:00
Matt Bierner 07025f0b0d
Remove notebook editor edit api (#158988)
Fixes #149181
2022-08-29 09:34:57 -07:00
Logan Ramos 67e628e18a
The quest to debug vscode.open continues (#158483) 2022-08-18 15:13:18 +02:00
Benjamin Pasero 032662071c
openIntegration test failure: openTextDocument, untitled closes on save (#157897) (#158482) 2022-08-18 14:56:50 +02:00
Rob Lourens 8c2fd550a3
Notebook cell execute in Interactive Window Test Fails on MacOS (#157963)
* Notebook cell execute in Interactive Window Test Fails on MacOS
Fixes #157826

* Remove .only
2022-08-12 09:31:11 -07:00
Aaron Munger 74f8a781d0
Merge pull request #157923 from amunger/interactiveExecute
add parameter to Interactive Execute to specify resource
2022-08-11 11:20:12 -07:00
aamunger 694324e3ac
add parameter to Interactive Execute to specify resource 2022-08-11 10:45:24 -07:00
Benjamin Pasero c6bcc3fcbf
API command test fail on MacOS (for #157824) (#157885)
API command test fail on MacOS (fix #157824)
2022-08-11 09:57:19 -04:00
Benjamin Pasero a3067cbbc6
assert that closed is defined (for #157897) (#157901) 2022-08-11 06:46:19 -07:00
Rob Lourens 8671778f8d
Fix notebook execution test failures (#157290)
* Fix notebook execution test failures
An error thrown in an event handler did not cause the test to fail, using DeferredPromise. Adjusting the api event to account for Unconfirmed vs Pending states. And accounting for onDidChangeNotebookDocument being fired multiple times during a test, causing the test to complete early while execution was still happening.
Fixes #157067

* Remove log
2022-08-05 11:07:20 -07:00
Benjamin Pasero 73fd3f1103
fix build (#157217)
* fix build

* fix compile

* flaky

* .
2022-08-05 09:16:20 +02:00
Matt Bierner c5f857f0cf
Remove skipped webview tests (#157155)
Fixes #153066

It's unclear what is causing these to occasionally fail in CI but keeping around these skipped tests is not useful
2022-08-04 23:49:05 +02:00
rebornix 336373dfc5
bring back kernel execute test 2022-08-03 10:14:45 -07:00
rebornix 82314b9ed5
remove outdated test 2022-08-03 10:08:02 -07:00
Peng Lyu 7833aade5a
Separate notebook kernel and api test (#156946)
* Separate notebook kernel and api test.

* no need to test reopen dirty document
2022-08-03 07:03:10 +02:00
Peng Lyu 418b944396
debt: move insert command towards unit tests. (#156929) 2022-08-03 01:42:53 +02:00
Peng Lyu 4b551dab35
Turn on notebook document test. (#156932) 2022-08-02 23:20:00 +02:00
Peng Lyu fded572606
Re #155587. Move undo/redo to unit tests. (#156849) 2022-08-02 09:28:37 +02:00
Peng Lyu f31a88e161
Remove move cell integration test (#156825)
* Remove move cell integration test

* 💄

* test didn't really run locally
2022-08-01 16:54:49 -04:00
Peng Lyu f4433141c7
Move off asPromise (#155920)
* Troubleshoot asPromise

* Update batch edit api

* Update workspace edit

* fix #156663

* 💄
2022-08-01 21:09:41 +02:00
Benjamin Pasero 6cad4b9494
skip test & 💄 (#155826) 2022-07-21 12:47:23 +02:00
Benjamin Pasero 477af8c842
skip flaky test (#152145) (#155809) 2022-07-21 11:46:51 +02:00
Rich Chiodo 052d5b0027
Fix issue with kernel preselection being overridden by view state (#154968)
* Fix view state overriding selected kernel

* Add test to verify correct kernel is used
2022-07-12 18:03:49 -07:00
Johannes Rieken c46640d635
remove obsolete API proposal name from api-tests, fyi @Tyriar (#154902) 2022-07-12 11:35:56 +02:00
jeanp413 318bdcc4cc Fix tests 2022-07-08 00:16:11 -05:00
Johannes Rieken e5f5a16b74
joh/issue145374 (#154360)
* enroll more places into `snippetWorkspaceEdit` proposal,

https://github.com/microsoft/vscode/issues/145374

* tweak API proposal for snippet edits, make this `WorkspaceEdit` only, remove old proposal bit

https://github.com/microsoft/vscode/issues/145374
2022-07-07 12:55:51 +00:00
Johannes Rieken 71c221c532
joh/theoretical quokka (#154157)
* add `SnippetController#apply(ISnippetEdit[])`

This replaces the initial ugly trick with a more sound implementation of arbitrary snippet edits. A snippet edit can cover disconnected regions, each will be applied as separate text edit but everything will become a single `OneSnippet` instance

* add integration test for SnippetString-text edit inside workspace edit
2022-07-05 12:30:01 -07:00
Johannes fb97ffc160
be tolerant to other events happing but still enforce that the expected events are there
fixes https://github.com/microsoft/vscode/issues/153288
2022-07-01 15:39:51 +02:00
Rob Lourens 50e1886048
Fix slow integration test (#153735)
Fixes #152886
2022-06-29 18:22:29 +00:00
Benjamin Pasero 0dfbf42795
tests - skip all flaky webview tests (#153066) (#153067) 2022-06-23 22:51:58 -07:00
Alex Dima bae316c7ad
Merge remote-tracking branch 'origin/main' into alexd/worrying-bandicoot 2022-06-23 22:45:59 +02:00
Benjamin Pasero a9cacc5d9a
skip flaky webview test (#150682) (#153006) 2022-06-23 17:43:04 +00:00
Benjamin Pasero 886c112cbd
Merge branch 'main' into alexd/worrying-bandicoot 2022-06-22 06:48:39 +02:00
Rich Chiodo f361c5b71d
Halve the number of executions to speed up test (#152768) 2022-06-22 06:24:21 +02:00
Benjamin Pasero 0203aabaa5
fix integration tests 2022-06-18 07:44:05 +02:00
Benjamin Pasero 0662ad271a
tests - skip flake (#152145) (#152442) 2022-06-17 11:56:58 +02:00
Benjamin Pasero 68433fb7fd
tests - remote invalid proposed API (#152181) 2022-06-15 14:34:56 +02:00
Matt Bierner 8b0b3ee72e
Remove notebook editor decoration type (#151574)
* Remove the notebookEditorDecorationType API proposal

Fixes #146838

* Remove all the infastructure around the now removed notebookEditorDecorationType api
2022-06-13 13:51:10 -07:00
Johannes ed9ed45794
Merge branch 'main' into joh/voluminous-lobster 2022-06-10 09:07:30 +02:00
Rob Lourens d5e7687940
Fix updating outputs of another cell using a NotebookCellExecution (#151573)
Fixes #151468
2022-06-09 20:27:36 -07:00
Johannes 43c31079ee
manual fixing of prefer-const violations 2022-06-09 10:19:56 +02:00
Johannes 3622010b64
Merge branch 'main' into joh/voluminous-lobster 2022-06-09 09:08:20 +02:00
Rob Lourens c38afc571d
Switch deprecated editor.document -> editor.notebook (#151530) 2022-06-08 09:35:00 -07:00
Johannes 0656d21d11
auto-fixed prefer-const violation 2022-06-08 17:49:21 +02:00
Megan Rogge 7c22caad55
Use I prefix for task interfaces (#151350) 2022-06-07 09:27:44 -07:00
Rich Chiodo b658848c9b Fix test to work 2022-06-06 17:04:26 -07:00
Rich Chiodo 416ad2cbc6 Can't get tests to run with local bits, try submitting 2022-06-06 16:48:56 -07:00
Rich Chiodo 8f345dea8e Add unit test 2022-06-06 16:14:14 -07:00
Tyler James Leonhardt db60eaa2ee
Enable locale picker in web (#150496)
* Enable locale picker in web

* fix the test by getting the locale from the loader config
2022-06-06 10:34:00 -07:00
Rich Chiodo dae2490dbb Merge remote-tracking branch 'upstream/main' into rchiodo/iw_output_scrolling 2022-05-24 11:15:35 -07:00
Rich Chiodo b79d02db5c Add test for scrolling 2022-05-24 11:01:51 -07:00
Rich Chiodo 9322fd543d Fix test to pass 2022-05-24 10:13:04 -07:00
Rich Chiodo 5d8bd23756 Add a test 2022-05-23 17:25:00 -07:00
Matt Bierner 45304da73d
Finalize NotebookEditor api proposal (#149767)
* Finalize NotebookEditor api proposal

Fixes #149271

This finalizes most parts of the NotebookEditor api proposal. I haven't removed the proposal entirely as there are still a few parts being left behind:

- The deprecated properties/functions
- A few contribution points such as `notebook/cell/executePrimary`

* remove extra quote
2022-05-23 23:27:17 +00:00
Matt Bierner 67014adc30
Remove the textDocumentNotebook API proposal (#149277)
* Remove the textDocumentNotebook API proposal

All consumers have now been migrated off of this proposal, so it is safe to remove from our code

* Remove deprecated api usage from test
2022-05-12 08:59:11 +02:00
Ladislau Szomoru 2a9f19d36f
Engineering - create pull request pipeline (#149171) 2022-05-11 03:08:54 -07:00
Jason Williams e19f09713b
Enable globs on tasks otherwise fallback to default - fixes #88106 (#141230)
* use glob on tasks otherwise fallback to default

* add support for test commands also

* try to find one globbed task otherwise fallback to defaults

* - get relativePath (but fallback to absolute if outside of workspace)
- bring back json schema

* Refactor and reduce duplicate code

* remove glob, make isDefault a string or boolean

* update taskConfig

* - rebase
- type updates
- splitPerGroupType should check explicitly for true on isDefault
- hygiene check

* Remove task glob from API

* Task group DTO updates

* Make sure globs run ahead of default task if there's multiple globs matching

* Style and name changes

* More naming and code re-use

* Glob doesn't work when only 1 glob match

Co-authored-by: Alex Ross <alros@microsoft.com>
2022-05-03 09:56:24 +02:00
Benjamin Pasero c6bd448948
debt - bring @types/mocha up to date with version 9.x 2022-05-02 08:30:27 +02:00
Megan Rogge 280460e3cc
clean up after test (#147941) 2022-04-22 12:07:31 -07:00
Johannes 90a6367e2c
remove mentionings of tabs proposal, fyi@lramos15 2022-04-22 11:51:53 +02:00
Logan Ramos aa69f3d762
Fix #15178 Finalize tabs API 🎉 2022-04-21 11:08:12 -04:00
Johannes 2b3212ead0
enable proposal for integration API tests 2022-04-21 16:54:11 +02:00
Megan Rogge 7e2fccd89a
fix #147780 (#147798) 2022-04-20 15:32:36 -07:00
Johannes 9530dca29d
finalize notebookDocumentEvents-API, https://github.com/microsoft/vscode/issues/144662 2022-04-20 13:58:37 +02:00
Johannes 8783c56eb7
fix https://github.com/microsoft/vscode/issues/147711 2022-04-20 11:30:37 +02:00
Matt Bierner 50ea16198d
Remove the concat text document api proposal
Fixes #146781
2022-04-14 14:39:44 -07:00
Johannes 4ea02deebd
ignore text document version whenever that document is marked as being created, fixes https://github.com/microsoft/vscode/issues/146964 2022-04-14 11:04:35 +02:00
Benjamin Pasero 8e8b3026fc
tests - reduce spam and work 2022-04-06 19:34:41 +02:00
Logan Ramos 9d0c4574f2
Fix compile 2022-04-05 15:28:05 -04:00
Logan Ramos 29e28ccf01
Update window tests 2022-04-05 15:25:57 -04:00
rebornix 943186d56c
update nb tests. 2022-04-01 12:10:23 -07:00
Johannes d58ff261d4
add integration tests for LiveShare specific notebook commands, https://github.com/microsoft/vscode/issues/125757 2022-04-01 10:57:49 +02:00
Matt Adam a727329516
Implement badge API for webviews and treeviews (#144775)
* Implement badge API for webviews and treeviews

* Address PR feedback

* Set badge priority

Part of #62783
2022-03-30 14:34:11 +02:00
Johannes Rieken 43d0483dae
Merge pull request #146185 from microsoft/joh/notebookCleanup 2022-03-30 09:18:44 +02:00
rebornix b8f14d243b
fix #138683. 2022-03-29 17:18:13 -07:00
Johannes b1faab40de
adopt tests to new notebook change event 2022-03-29 11:58:54 +02:00
Benjamin Pasero 126e4744ec
blue print tests for #145846 2022-03-24 17:02:17 +01:00
Benjamin Pasero 5f57f8c001
Editor is improperly marked isPreview in tabs api (fix #145755) 2022-03-23 10:39:21 +01:00
Logan Ramos a2d8edb83d
Tabs API renaming 2022-03-21 13:35:34 -04:00
Logan Ramos 8d99738d84
Remove unnecessary return in tab close 2022-03-18 17:28:42 -04:00
Logan Ramos 9f0bdbc6c5
Add active tab test 2022-03-18 16:12:06 -04:00
Logan Ramos 00a4adef89
Enable active tab integration test 2022-03-18 15:32:28 -04:00
Logan Ramos 799eb643c4
Re-enable some integration tests 2022-03-18 15:25:45 -04:00
Logan Ramos b906904089
Fix compile errors 2022-03-18 14:26:51 -04:00
Johannes c385364f5d
tabs - move move into TabGroups 2022-03-18 14:35:46 +01:00
Logan Ramos 85c3df0dde
Tie in tab input, remove cleanup .d.ts 2022-03-17 16:54:44 -04:00
Logan Ramos 1e0f8c9ba1
Re-enable vscode.open tab est 2022-03-17 10:59:27 -04:00
Logan Ramos dfd1f28552
Skip test 2022-03-16 18:10:37 -04:00
Logan Ramos 53aaa205e6
Fix #144605 2022-03-14 13:26:45 -04:00
Robo 32d40cf44e
chore: update to electron 17 (#143223)
* chore: bump electron@17.0.0

* Revert "chore: revert to electron@13 (#143851)"

This reverts commit df645f1450.

* chore: bump electron@17.1.0

* Revert "ci: fix build with latest node-gyp"

This reverts commit c3e948aa30.

* chore: revert ci changes for node v16

* chore: update yarn.lock

* chore: bump electron@17.1.1
2022-03-11 00:51:37 +09:00
Rob Lourens 5a7db04b89 Fix #144043 2022-03-09 10:49:08 -08:00
Alex Ross c468903ff7
Finalize tree drag and drop API
Fixes #32592
2022-03-02 15:39:36 +01:00
Matt Bierner a068ebee8d
Finalize markdownstring.baseUri
Fixes #142051
2022-03-01 15:48:53 -08:00
Robo df645f1450
chore: revert to electron@13 (#143851)
* Revert "chore: update to electron 16 (#137241)"

This reverts commit 01df559c18.
This reverts commit 46301339b7

* ci: fix remote compiler for sdl-scan

* chore: fix remote/.yarnrc

* chore: fix build/npm/postinstall.js

* chore: rm crash reporter from shared process

* chore: rm crash reporter from ext host

* chore: fix build/lib/layersChecker.ts

* :chore: preserve some more changes

* fix tests

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2022-02-24 17:49:49 +01:00
Benjamin Pasero 6640f3c721
skip flaky test (#139960) 2022-02-24 13:27:04 +01:00
Benjamin Pasero 6dee30baa8
tests - restore test coverage for #139786 2022-02-23 13:17:21 +01:00
Logan Ramos 8437d74b8b
Fix #139786 2022-02-17 15:15:51 -05:00
Logan Ramos 0a9e7a5f49
Re-enable tab getter test 2022-02-16 15:09:08 -05:00
Matt Bierner 21da6eeafa
Delay getting workspace uri until tests are running
For #143226
2022-02-16 10:59:03 -08:00
Logan Ramos ec9df1d972
Update tabs model to utilize the new API shape (#142668)
* Change shape of the tabs API

* Disable tab tests for now

* Add an onDidChangeTabGroup event

* Optimize for group activate

* Update events to no longer be an array

* Further tab optimization
2022-02-10 15:09:11 -05:00
Johannes Rieken b7955eac38
finalize inlay hints provider API, https://github.com/microsoft/vscode/issues/16221 2022-02-09 15:32:46 +01:00
Daniel Imms 339cbb38e2 Skip environment variable collection tests only on Windows
Guessing conpty is causing problems
2022-02-09 05:26:19 -08:00
Alex Ross 5bdfec8311
Dispose of all terminals before running task test
Fixes #142565
2022-02-09 14:06:09 +01:00