Commit graph

49831 commits

Author SHA1 Message Date
SteVen Batten 22e00149f1 update menu and titlebar platform checks 2019-06-06 00:32:35 +00:00
Matt Bierner 619851fe2e Don't use Symbol
Not supported by ie11 for monaco
2019-06-05 16:29:55 -07:00
Matt Bierner 2641bd536d Adding disposable tracking helpers 2019-06-05 16:11:13 -07:00
Matt Bierner 139d51aec4 Use Disposable.None 2019-06-05 16:11:13 -07:00
Matt Bierner f94d5ba08e Fix merge conflict 2019-06-05 16:11:13 -07:00
Matt Bierner d57db50463 Fixing a few possible leaked disposables 2019-06-05 15:42:26 -07:00
Matt Bierner 3d3f1bae93 Fixing a few more dispoable cases 2019-06-05 15:42:26 -07:00
Matt Bierner 8de04a7442 Use map for storing registry values 2019-06-05 15:42:26 -07:00
Matt Bierner 29475925f4 Extend disposable 2019-06-05 15:42:26 -07:00
Matt Bierner d34324f8b3 Make WindowsManager disposable
This class registers emitters which should be disposed
2019-06-05 15:42:26 -07:00
Matt Bierner 3132d26813 Have Panel extend Disposable
The panel currently exposes a `disposables` protected member. In order to catch possible leaks of disposables, we should extend `Disposable` instead
2019-06-05 15:42:25 -07:00
Matt Bierner cd82bcb5bd Make Action extend Disposable
This class already is an implicit IDisposable and a number of subclasses to it re-implement the Disposable logic
2019-06-05 15:41:46 -07:00
Matt Bierner 025c005ffc Remove extra indirection in toDisposable 2019-06-05 15:41:46 -07:00
Matt Bierner a1c5ded681 Remove n-arg version of dispose
This overload was not heavily used and added complexity
2019-06-05 15:41:46 -07:00
Matt Bierner 6b7b5c0e0c Extend lifecycle/Disposable in more places instead of re-implementing it
`lifecycle/Disposable` includes some important fixes that can help catch common programming mistakes
2019-06-05 15:41:46 -07:00
Matt Bierner 680b30a370 Remove unused interface method 2019-06-05 15:41:46 -07:00
Matt Bierner 88e7b22359 Use clearer name 2019-06-05 15:41:46 -07:00
Matt Bierner 8f496f2242 Make sure we dispose of emitters for TerminalProcessExtHostProxy 2019-06-05 15:41:46 -07:00
Matt Bierner a6b38fc755 Use readonly instead of getters 2019-06-05 15:41:45 -07:00
Matt Bierner a6ea8be992 Make sure we dispose of emitters in a few more places
Emitters should be disposed of properly in order to help prevent leaks
2019-06-05 15:41:45 -07:00
Matt Bierner 79781e0fe2 Extend disposable 2019-06-05 15:41:45 -07:00
Matt Bierner 5d4e42422d Make sure we dispose of emitter 2019-06-05 15:41:45 -07:00
Matt Bierner 2c8de04126 Fix merge error related to disposables 2019-06-05 15:41:45 -07:00
Matt Bierner 1cdf995036 Build with TS 3.5.1
The dom.d.ts types changed to not allow null on the outline styles. I believe that setting this to empty string should be equivalent
2019-06-05 15:41:45 -07:00
Matt Bierner b33f52a46e Update highlightjs version 2019-06-05 15:41:45 -07:00
Matt Bierner 809386b670 Working on getting ts server class in a testable state 2019-06-05 15:41:45 -07:00
Matt Bierner 0b4d3cd604 Remove use of IDisposable[] in a few more places 2019-06-05 15:41:45 -07:00
Matt Bierner 869e5921d8 Update more places where we are using an IDispoable[]
Either extend `Disposable` or use a readonly `DispoableStore`
2019-06-05 15:41:45 -07:00
Matt Bierner 2be7ab1ef6 implement IDisposable instead of extending base class 2019-06-05 15:41:44 -07:00
Sandeep Somavarapu 5845970591 #74918 Move markers status contribution to markers 2019-06-06 00:21:23 +02:00
Rob Lourens acad875120 Remove references to deleted icons 2019-06-05 14:50:13 -07:00
Rob Lourens f6bee434bb Remove unused dep clean-css 2019-06-05 14:40:44 -07:00
Rob Lourens 7be8f03d46 Update distro 2019-06-05 14:17:04 -07:00
Rob Lourens 205337f4ad Allow shell environment probe to be disabled
for microsoft/vscode-remote-release#544
2019-06-05 14:12:15 -07:00
Sandeep Somavarapu 46698488c5 remove theming for severity icon 2019-06-05 22:52:59 +02:00
Sandeep Somavarapu 0ed7ab83d2 Merge branch 'master' into sandy081/statusOcticons 2019-06-05 22:46:43 +02:00
Sandeep Somavarapu 4afdee043c #74580 Fix warning colors in overview ruler 2019-06-05 22:39:59 +02:00
Sandeep Somavarapu b85f6d7d7d use editor error color as base color 2019-06-05 22:32:32 +02:00
Miguel Solorio 9039b6a00d Center activity bar icons 2019-06-05 12:40:26 -07:00
Sandeep Somavarapu 67f63fee7a Use svgs instead of octicons 2019-06-05 20:50:40 +02:00
Sandeep Somavarapu 69ec81be9f Revert "remove status icons and adopt octicons"
This reverts commit d0e1fe599f.
2019-06-05 19:16:12 +02:00
Sandeep Somavarapu d0e1fe599f remove status icons and adopt octicons 2019-06-05 19:03:31 +02:00
Rob Lourens 9be296470a Fix #74875 2019-06-05 09:53:58 -07:00
Sandeep Somavarapu 12c8145a6d Merge branch 'master' into sandy081/statusOcticons 2019-06-05 18:51:02 +02:00
Sandeep Somavarapu bacc931c39 Fix #74580 2019-06-05 18:47:49 +02:00
Sandeep Somavarapu 160e8c18af #74580 reuse severity icon widget 2019-06-05 18:47:49 +02:00
Sandeep Somavarapu 40bee4adad use status octicons 2019-06-05 17:16:04 +02:00
Alex Ross f3086a6e11 Remove sync fs use in tasks
Fixes #70577
2019-06-05 17:10:13 +02:00
isidor 19b4a01889 debug mac toolbar make step action more stable position wise
fixes #54084
2019-06-05 16:58:02 +02:00
isidor cec3dd914e fixes #74551 2019-06-05 16:46:29 +02:00